)]}'
{"tempest/api/identity/v3/test_users.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2ddd449c65a357f828d8e99b7f29617bd1002c9d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def test_user_account_lockout(self):"},{"line_number":136,"context_line":"        # NOTE: If CONF.identity.user_lockout_duration is too long, just skip"},{"line_number":137,"context_line":"        # this testcase to avoid overall too long running time."},{"line_number":138,"context_line":"        if CONF.identity.user_lockout_duration \u003e 60:"},{"line_number":139,"context_line":"            raise self.skipException("},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration(%ss) is too long, please \""},{"line_number":141,"context_line":"                \"set a smaller value for testing this feature.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b40ce73a","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":46},"updated":"2018-10-19 06:39:17.000000000","message":"but this default value is 5 sec and if it configured to higher value then, tester knows how long they want to wait for account unlock. \n\nBy skipping this test based on higher value can leads to false skip and hide the failure.","commit_id":"83bca3f08f22f188a5748875f940789d7cbf5802"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e7f5f792c62eb735362e45bad4c7332cd0132c5d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def test_user_account_lockout(self):"},{"line_number":136,"context_line":"        # NOTE: If CONF.identity.user_lockout_duration is too long, just skip"},{"line_number":137,"context_line":"        # this testcase to avoid overall too long running time."},{"line_number":138,"context_line":"        if CONF.identity.user_lockout_duration \u003e 60:"},{"line_number":139,"context_line":"            raise self.skipException("},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration(%ss) is too long, please \""},{"line_number":141,"context_line":"                \"set a smaller value for testing this feature.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_47892723","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":46},"in_reply_to":"3f79a3b5_14aa7b83","updated":"2018-10-19 08:06:18.000000000","message":"or other way we can say, timeout for 1800 value is right thing to do. while testing we can increase the test timeout and test 1800 sec also. if we check such condition then we are restricting the testing for system and test env which are configured for such large value.\n\nsop we leave to tester how they configure (system and test env/timeout), we test.","commit_id":"83bca3f08f22f188a5748875f940789d7cbf5802"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dc1eb1ce94a50697f47df1ead5aff46342232a0c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def test_user_account_lockout(self):"},{"line_number":136,"context_line":"        # NOTE: If CONF.identity.user_lockout_duration is too long, just skip"},{"line_number":137,"context_line":"        # this testcase to avoid overall too long running time."},{"line_number":138,"context_line":"        if CONF.identity.user_lockout_duration \u003e 60:"},{"line_number":139,"context_line":"            raise self.skipException("},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration(%ss) is too long, please \""},{"line_number":141,"context_line":"                \"set a smaller value for testing this feature.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_87c09f4c","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":46},"in_reply_to":"3f79a3b5_14aa7b83","updated":"2018-10-19 08:02:53.000000000","message":"yeah that is what we should do, i added those info in help of these config options. So tester needs to configure the system in testable way like this options. - https://review.openstack.org/#/c/611797/\n\nWhat we should have check in this test is-\n1. if user_lockout_failure_attempts is not \u003e 0 or user_lockout_duration is not \u003e 0  then skip the test\n\nbecause in that case we will not be able to test the feature.","commit_id":"83bca3f08f22f188a5748875f940789d7cbf5802"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5e11e51d73903ce039852f84c864b4cf33003bed","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def test_user_account_lockout(self):"},{"line_number":136,"context_line":"        # NOTE: If CONF.identity.user_lockout_duration is too long, just skip"},{"line_number":137,"context_line":"        # this testcase to avoid overall too long running time."},{"line_number":138,"context_line":"        if CONF.identity.user_lockout_duration \u003e 60:"},{"line_number":139,"context_line":"            raise self.skipException("},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration(%ss) is too long, please \""},{"line_number":141,"context_line":"                \"set a smaller value for testing this feature.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_056fa7c4","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":46},"in_reply_to":"3f79a3b5_47892723","updated":"2018-10-19 09:33:51.000000000","message":"Agree that it should be left to tester to decide.\nSo I just skip the testcase if both CONF.identity.user_lockout_failure_attempts and CONF.identity.user_lockout_duration are 0.","commit_id":"83bca3f08f22f188a5748875f940789d7cbf5802"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"140c425f924f8524183ee652f51d2f74c8a869b2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def test_user_account_lockout(self):"},{"line_number":136,"context_line":"        # NOTE: If CONF.identity.user_lockout_duration is too long, just skip"},{"line_number":137,"context_line":"        # this testcase to avoid overall too long running time."},{"line_number":138,"context_line":"        if CONF.identity.user_lockout_duration \u003e 60:"},{"line_number":139,"context_line":"            raise self.skipException("},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration(%ss) is too long, please \""},{"line_number":141,"context_line":"                \"set a smaller value for testing this feature.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_14aa7b83","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":46},"in_reply_to":"3f79a3b5_b40ce73a","updated":"2018-10-19 07:08:45.000000000","message":"I get into trouble when I run Tempest on a system with keystone.conf:security_compliance.user_lockout_duration set to 1800(which is 30mins), so, if I set CONF.identity.user_lockout_duration to 1800, I\u0027ll have to wait 30mins for one testcase which seems unacceptable; otherwise the testcase will fail(CONF.identity.user_lockout_duration default to 5).\nSo, I think if I want to test this lockout feature, I\u0027d better modify the tested system\u0027s keystone.conf:security_compliance.user_lockout_duration first(to a smaller value, like 10s), otherwise this testcase can be skipped(I don\u0027t want to wait 30mins nor to modify keystone.conf).","commit_id":"83bca3f08f22f188a5748875f940789d7cbf5802"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5b15a367f78bd621f5838c5ab9d70968f9e4b8dd","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                CONF.identity.user_lockout_duration \u003c\u003d 0):"},{"line_number":138,"context_line":"            raise self.skipException("},{"line_number":139,"context_line":"                \"Both CONF.identity.user_lockout_failure_attempts and \""},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration should be greater than \""},{"line_number":141,"context_line":"                \"zero to test this feature\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        password \u003d self.creds.password"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5c401560","line":140,"range":{"start_line":140,"start_character":17,"end_line":140,"end_character":52},"updated":"2018-10-19 14:13:34.000000000","message":"Is this true given that L164 will be 1 second (because of + 1)?","commit_id":"270c25a5ef7e8e8eacfb0462ddefdcf561a13be9"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"64bf17d745a28a71aa9375e74bae9f899a67d362","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                CONF.identity.user_lockout_duration \u003c\u003d 0):"},{"line_number":138,"context_line":"            raise self.skipException("},{"line_number":139,"context_line":"                \"Both CONF.identity.user_lockout_failure_attempts and \""},{"line_number":140,"context_line":"                \"CONF.identity.user_lockout_duration should be greater than \""},{"line_number":141,"context_line":"                \"zero to test this feature\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        password \u003d self.creds.password"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_48da7d4a","line":140,"range":{"start_line":140,"start_character":17,"end_line":140,"end_character":52},"in_reply_to":"3f79a3b5_5c401560","updated":"2018-10-22 01:13:04.000000000","message":"Yes. We skip the testcase if CONF.identity.user_lockout_duration is set to 0, which means this feature is disabled. The \"+1\" in L164 is just to ensure the duration time is expired","commit_id":"270c25a5ef7e8e8eacfb0462ddefdcf561a13be9"}]}