)]}'
{"tempest/api/identity/admin/v3/test_trusts.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"37f46972df2202a472402de1c8b7a0636e0e6322","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        self.check_trust_roles()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        self.delete_trust()"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":244,"context_line":"    def test_trust_expire_invalid(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8pPM%3D","line":241,"updated":"2013-12-23 19:50:51.000000000","message":"Looking at the setup/cleanup logic this delete is not necessary.  Some of these tests do this and others don\u0027t. It would good to have these tests be consistent and remove this from all of them.","commit_id":"dfb84c7f57ed2003b88214c8a601f84e37aeb024"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"2a939d98633000af5ca8a36d3440ff5ffab5b98b","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        self.check_trust_roles()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        self.delete_trust()"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":244,"context_line":"    def test_trust_expire_invalid(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8o9E%3D","line":241,"in_reply_to":"AAAATn%2F8pPM%3D","updated":"2013-12-23 21:27:02.000000000","message":"I actually added the explicit delete deliberately, because I wanted the test to prove that the various types of trust (with and without impersonation, with and without expiry) are deletable.\n\nIf we remove them as you suggest, any delete failure will be silently ignored because it\u0027s happening in a cleanup function rather than teardown wont it?\n\nThe reason some tests don\u0027t test delete is because it\u0027s already tested (deleting a trust with the exact same parameters) in test_trust_impersonate.\n\nI guess an alternative would be to put the delete in a tearDown function?\n\nI\u0027m happy to post a followup patch with whatever approach you prefer, but I would like to make sure we still test delete.","commit_id":"dfb84c7f57ed2003b88214c8a601f84e37aeb024"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"ec9643a0b626290aff4adfd8067da21699fa4012","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self.delete_trust()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":226,"context_line":"    def test_trust_expire(self):"},{"line_number":227,"context_line":"        # Test case to check we can create, get and delete a trust"},{"line_number":228,"context_line":"        # with an expiry specified"},{"line_number":229,"context_line":"        expires_at \u003d timeutils.utcnow() + datetime.timedelta(hours\u003d1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F9u8%3D","line":226,"updated":"2013-12-26 07:06:17.000000000","message":"Suggest to use the function name \"test_trust_with_expiry\".\nEnglish is not my mother language, i am not sure if it is a better choice.","commit_id":"c234ada4478c76ec8a693760d52e00be2964b639"}]}