)]}'
{"tempest/api/compute/admin/test_security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ac497d4ddd41ed3edf22e0f205e13de643781d3c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        fetched_list \u003d (self.client.list_security_groups(all_tenants\u003d\u0027true\u0027)"},{"line_number":75,"context_line":"                        [\u0027security_groups\u0027])"},{"line_number":76,"context_line":"        sec_group_id_list \u003d [sg[\u0027id\u0027] for sg in fetched_list]"},{"line_number":77,"context_line":"        # Now check if all created Security Groups are present in fetched list"},{"line_number":78,"context_line":"        for sec_group in security_group_list:"},{"line_number":79,"context_line":"            if sec_group[\u0027tenant_id\u0027] \u003d\u003d client_tenant_id:"},{"line_number":80,"context_line":"                self.assertIn(sec_group[\u0027id\u0027], sec_group_id_list,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f13fd1dc","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":78},"updated":"2018-10-19 06:29:47.000000000","message":"you can modify this to:\n\n# Now check that \u0027all_tenants\u003d\u0027true\u0027 filter for non-admin user only provide the requested non-admin user\u0027s created security groups not all security groups which includes sec groups created by other users.","commit_id":"2d065ee65ee288286e19449b59fda93b7c8311e9"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7fcd3bec45e16a4b382a46eed8299f4d76c5ed2f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        fetched_list \u003d (self.client.list_security_groups(all_tenants\u003d\u0027true\u0027)"},{"line_number":75,"context_line":"                        [\u0027security_groups\u0027])"},{"line_number":76,"context_line":"        sec_group_id_list \u003d [sg[\u0027id\u0027] for sg in fetched_list]"},{"line_number":77,"context_line":"        # Now check if all created Security Groups are present in fetched list"},{"line_number":78,"context_line":"        for sec_group in security_group_list:"},{"line_number":79,"context_line":"            if sec_group[\u0027tenant_id\u0027] \u003d\u003d client_tenant_id:"},{"line_number":80,"context_line":"                self.assertIn(sec_group[\u0027id\u0027], sec_group_id_list,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b491479e","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":78},"in_reply_to":"3f79a3b5_f13fd1dc","updated":"2018-10-19 06:51:25.000000000","message":"Thanks, much clearer, done.","commit_id":"2d065ee65ee288286e19449b59fda93b7c8311e9"}]}