)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e7ae1d8c35315c2a8e2b93c69fa5137240b8d5f1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tests in test_auth_token didn\u0027t really add an value. They just"},{"line_number":10,"context_line":"ran a server list command and hoped it didn\u0027t throw an exception. If"},{"line_number":11,"context_line":"there was an issue with this then all the api tests would fail, so"},{"line_number":12,"context_line":"there is no value in these tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I14e0c0284170219c028454990f189440ffeb0b08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9S3U%3D","line":11,"updated":"2013-12-12 22:58:26.000000000","message":"This test was added to make sure that a bug was fixed. The bug was that if you used a token that was provided by the v3 identity API then the auth_token middleware would fail. This was because the auth_token middleware didn\u0027t use the fields in the token after the code changed in keystone and not in keystoneclient.\n\nI\u0027m not sure that if there was an issue with v3 tokens again that all the api tests would fail because these tests were all using v2 tokens before. Maybe this is tested elsewhere, and maybe this test belongs elsewhere (a scenario makes more sense to me now that I\u0027ve looked around tempest some more).","commit_id":"7b1ec17f1b390d18d0eab62c3004afdb74539832"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"543cc2f2e22b75daee05981374e93e6a026a0822","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tests in test_auth_token didn\u0027t really add an value. They just"},{"line_number":10,"context_line":"ran a server list command and hoped it didn\u0027t throw an exception. If"},{"line_number":11,"context_line":"there was an issue with this then all the api tests would fail, so"},{"line_number":12,"context_line":"there is no value in these tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I14e0c0284170219c028454990f189440ffeb0b08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9SUE%3D","line":11,"in_reply_to":"AAAATn%2F9S3U%3D","updated":"2013-12-13 01:30:27.000000000","message":"So the tests in the file I removed here have no value, I\u0027d argue they are not even tests. All they do is run a server list using either v2 or v3 auth, which will pass as long as an exception is not raised. That is far too broad to be a valid test case, and is honestly covered by every other api call we make. (granted only with v2 by default) If it didn\u0027t work then we would have bigger issues.\n\nNow it sounds like the there is a specific case that needs to be tested. Which if so this file only hit tangentially. The proper way to do that type of test is to specifically check the conditions you need to reproduce and use asserts to verify the API responses you are getting are what is expected. The proper place for this testing would be tempest.api.identity. We have v3 token tests there currently, see:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/identity/admin/v3/test_tokens.py\n\nBased on your description it sounds like what you\u0027re looking for is not covered there. So you should either add onto that test file or make a non-admin v3 token test to specifically test what is needed. It is completely ok to use the nova client (or another tempest client) in an identity api test if that is what you need to do to verify the functionality. A scenario test would not do what you are looking for because scenario tests use the official clients, and you needed to verify the keystone API.\n\nRegardless the file here is not doing anything useful, and we should remove it to both remove useless tests and prevent confusion.","commit_id":"7b1ec17f1b390d18d0eab62c3004afdb74539832"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"896ef5d774930e84674b0423a736278ee4e912bd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tests in test_auth_token didn\u0027t really add an value. They just"},{"line_number":10,"context_line":"ran a server list command and hoped it didn\u0027t throw an exception. If"},{"line_number":11,"context_line":"there was an issue with this then all the api tests would fail, so"},{"line_number":12,"context_line":"there is no value in these tests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I14e0c0284170219c028454990f189440ffeb0b08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9Pjo%3D","line":11,"in_reply_to":"AAAATn%2F9SUE%3D","updated":"2013-12-13 15:39:47.000000000","message":"I\u0027ll work on putting a test in identity to cover using the v3 token with the auth_token middleware.","commit_id":"7b1ec17f1b390d18d0eab62c3004afdb74539832"}]}