)]}'
{"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0192981b7bb475b551bf7c0e45fb66f40a316ee8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":39,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":40,"context_line":"        # root password should be set to that password."},{"line_number":41,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":42,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Verify the password is set correctly in the response"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1d065e75","line":41,"updated":"2018-10-30 07:41:40.000000000","message":"Why not add `wait_until\u003d\u0027ACTIVE\u0027` here like others?","commit_id":"233297175d536c9102cbde34d25e7c9073452930"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"49ecb60381e62e328e47a8e2f4b86d6ce1ef9638","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":39,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":40,"context_line":"        # root password should be set to that password."},{"line_number":41,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":42,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Verify the password is set correctly in the response"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3d0f9a38","line":41,"in_reply_to":"3f79a3b5_1d065e75","updated":"2018-10-30 08:02:05.000000000","message":"oh, the \u0027adminPass\u0027 is only present in the response body of create_server, so I guess the original design thinks it no need to wait for server active.","commit_id":"233297175d536c9102cbde34d25e7c9073452930"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c6d14b5bd2d4de7c3392c456bd62cd4adb0e3416","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":39,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":40,"context_line":"        # root password should be set to that password."},{"line_number":41,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":42,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Verify the password is set correctly in the response"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d540a4a6","line":41,"in_reply_to":"3f79a3b5_3d0f9a38","updated":"2018-10-31 09:25:40.000000000","message":"It\u0027s really a little confusing, so I add a comment for it.","commit_id":"233297175d536c9102cbde34d25e7c9073452930"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fb67ba719492dc927e073ff2620cca485d6a5047","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":39,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":40,"context_line":"        # root password should be set to that password."},{"line_number":41,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":42,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Verify the password is set correctly in the response"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_56a1823a","line":41,"in_reply_to":"3f79a3b5_d540a4a6","updated":"2018-11-22 02:54:03.000000000","message":"Heh Kenichi and Felipe think it no need to add extra comment, so how about just keep it as is?:)","commit_id":"233297175d536c9102cbde34d25e7c9073452930"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"758809ed602b3c58a0679589830b2ea8cfbfa97f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":39,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":40,"context_line":"        # root password should be set to that password."},{"line_number":41,"context_line":"        # NOTE: \u0027adminPass\u0027 is not present in the response body of"},{"line_number":42,"context_line":"        # create_server, so here we don\u0027t need to wait for server active."},{"line_number":43,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":44,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f1def10d","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":73},"updated":"2018-11-15 20:50:46.000000000","message":"I think this NOTE makes confusions.\nadminPass is present in the response body of \"create a server\" API. Here\u0027s create_server means a wrapper method of Tempest, the method returns the response body of \"get a server\" API for waiting for server active. Then this NOTE is written, right?\n\nThat is difficult to maintain/understand the background, how about just removing?","commit_id":"2bea2311c1b0b21834f1426d23f3b48020e2ce59"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e91cb1213eb033ec53a008ce1f083ff00cb8ab60","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":39,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":40,"context_line":"        # root password should be set to that password."},{"line_number":41,"context_line":"        # NOTE: \u0027adminPass\u0027 is not present in the response body of"},{"line_number":42,"context_line":"        # create_server, so here we don\u0027t need to wait for server active."},{"line_number":43,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":44,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a0f1019a","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":73},"in_reply_to":"3f79a3b5_f1def10d","updated":"2018-11-16 05:39:15.000000000","message":"I\u0027d want to express that \"show a server\" api won\u0027t return adminPass, and only \"create a server\" api will return adminPass:)\nI\u0027m ok to remove it:)","commit_id":"2bea2311c1b0b21834f1426d23f3b48020e2ce59"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"93205b368ed445d43275ef6a4a08eda55b734808","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                          enable_instance_password,"},{"line_number":38,"context_line":"                          \u0027Instance password not available.\u0027)"},{"line_number":39,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":40,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":41,"context_line":"        # root password should be set to that password."},{"line_number":42,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":43,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":44,"context_line":"                        self.servers_client, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4334ade0","side":"PARENT","line":41,"range":{"start_line":40,"start_character":8,"end_line":41,"end_character":55},"updated":"2018-11-16 21:05:14.000000000","message":"nit: I\u0027m not sure why this was removed. This comment is still valid and makes sense to explain what is going on with this test. That is, this comment and the one on L49 go hand in hand.","commit_id":"75048e4c86e777a6db87de47dd3e20ed9f57fa9e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fd2889cef9732d79b00212e51da4a6e2f597a544","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                          enable_instance_password,"},{"line_number":38,"context_line":"                          \u0027Instance password not available.\u0027)"},{"line_number":39,"context_line":"    def test_create_server_with_admin_password(self):"},{"line_number":40,"context_line":"        # If an admin password is provided on server creation, the server\u0027s"},{"line_number":41,"context_line":"        # root password should be set to that password."},{"line_number":42,"context_line":"        server \u003d self.create_test_server(adminPass\u003d\u0027testpassword\u0027)"},{"line_number":43,"context_line":"        self.addCleanup(waiters.wait_for_server_termination,"},{"line_number":44,"context_line":"                        self.servers_client, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e8b350ea","side":"PARENT","line":41,"range":{"start_line":40,"start_character":8,"end_line":41,"end_character":55},"in_reply_to":"3f79a3b5_4334ade0","updated":"2018-11-19 01:00:55.000000000","message":"oh, my fault, I don\u0027t mean to remove it. restored.","commit_id":"75048e4c86e777a6db87de47dd3e20ed9f57fa9e"}]}