)]}'
{"tempest/api/network/test_floating_ips.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"7a70d382c72303eece34ee3a694d1cfab9cf04fc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_create_list_show_update_delete_floating_ip(self):"},{"line_number":65,"context_line":"        # Creates a floating IP"},{"line_number":66,"context_line":"        created_floating_ip \u003d self.create_floating_ip("},{"line_number":67,"context_line":"            self.ext_net_id, port_id\u003dself.port[0][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":70,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F837A%3D","line":67,"updated":"2013-12-19 10:03:54.000000000","message":"my concern is that it doesn\u0027t check return code after using self.create_floating_ip. I think we should keep a place to check return code.","commit_id":"6de9eaf79bf8b0d3e8623decb4b99b0ae4500866"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"6be9e0cc11cef8af8724f0bd776a9e9d9243ebf7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_create_list_show_update_delete_floating_ip(self):"},{"line_number":65,"context_line":"        # Creates a floating IP"},{"line_number":66,"context_line":"        created_floating_ip \u003d self.create_floating_ip("},{"line_number":67,"context_line":"            self.ext_net_id, port_id\u003dself.port[0][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":70,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F832g%3D","line":67,"in_reply_to":"AAAATn%2F837A%3D","updated":"2013-12-19 10:25:45.000000000","message":"The return code could be checked in \t\ntempest/api/network/base.py line 176. Anyway no other similar function checks that, see create_pool for example. Are you proposing to change them all?","commit_id":"6de9eaf79bf8b0d3e8623decb4b99b0ae4500866"}]}