)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5b56938b3201cf105225341cd53a11ffa860b632","unresolved":false,"context_lines":[{"line_number":12,"context_line":"but in this case the test failed at teardown time (double port delete)"},{"line_number":13,"context_line":"Turned out the test case normally not even deletes the fixed_ip port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There is no match point for having 3 interface in this test, so just"},{"line_number":16,"context_line":"adding the fixed_ip port and deleting it in the test case."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1790864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_475d79e9","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":17},"updated":"2018-11-04 19:38:54.000000000","message":"more","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"76906f14761e66612588962b7b32c8169afd81e7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"but in this case the test failed at teardown time (double port delete)"},{"line_number":13,"context_line":"Turned out the test case normally not even deletes the fixed_ip port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There is no match point for having 3 interface in this test, so just"},{"line_number":16,"context_line":"adding the fixed_ip port and deleting it in the test case."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1790864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1b003169","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":17},"in_reply_to":"3f79a3b5_475d79e9","updated":"2018-11-05 13:50:36.000000000","message":"\u0027not match\u0027","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"}],"tempest/api/compute/servers/test_attach_interfaces.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9828f99ebba5aa021ed0a3b2dfc079f553d8908d","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        except lib_exc.BadRequest as e:"},{"line_number":266,"context_line":"            msg \u003d (\u0027Multiple possible networks found, use a Network ID to be \u0027"},{"line_number":267,"context_line":"                   \u0027more specific.\u0027)"},{"line_number":268,"context_line":"            if not CONF.compute.fixed_network_name and six.text_type(e) \u003d\u003d msg:"},{"line_number":269,"context_line":"                raise"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            ifs.append(iface)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_dd02b808","side":"PARENT","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":21},"updated":"2018-11-05 03:12:22.000000000","message":"Only when CONF.compute.fixed_network_name is not set should this exception be raised, so I don\u0027t know why in the bug report, this exception is raised with \"fixed_network_name \u003d public\" in tempest.conf.","commit_id":"da8aec9aedcac940ba1dbc3beee50f05f13af3f1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5b56938b3201cf105225341cd53a11ffa860b632","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        iface \u003d self.interfaces_client.create_interface("},{"line_number":169,"context_line":"            server[\u0027id\u0027], net_id\u003dnetwork_id,"},{"line_number":170,"context_line":"            fixed_ips\u003dfixed_ips)[\u0027interfaceAttachment\u0027]"},{"line_number":171,"context_line":"        def _clean_port_accept_already_deleted(pc, port_id):"},{"line_number":172,"context_line":"            try:"},{"line_number":173,"context_line":"                pc.delete_port(port_id)"},{"line_number":174,"context_line":"            except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_87495130","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":46},"updated":"2018-11-04 19:38:54.000000000","message":"Why not use:\n\n    self.addCleanup(test_utils.call_and_ignore_notfoundexc, self.ports_client.delete_port, iface[\u0027port_id\u0027])","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"76906f14761e66612588962b7b32c8169afd81e7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        iface \u003d self.interfaces_client.create_interface("},{"line_number":169,"context_line":"            server[\u0027id\u0027], net_id\u003dnetwork_id,"},{"line_number":170,"context_line":"            fixed_ips\u003dfixed_ips)[\u0027interfaceAttachment\u0027]"},{"line_number":171,"context_line":"        def _clean_port_accept_already_deleted(pc, port_id):"},{"line_number":172,"context_line":"            try:"},{"line_number":173,"context_line":"                pc.delete_port(port_id)"},{"line_number":174,"context_line":"            except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7b3da527","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":46},"in_reply_to":"3f79a3b5_7d2a8478","updated":"2018-11-05 13:50:36.000000000","message":"if test name contains the `delete` it should delete the `foo` inside the test case, but in case of other failure we should try to avoid leakage of resources and should try to have 2th delete attempt at cleanup stage.","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9828f99ebba5aa021ed0a3b2dfc079f553d8908d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        iface \u003d self.interfaces_client.create_interface("},{"line_number":169,"context_line":"            server[\u0027id\u0027], net_id\u003dnetwork_id,"},{"line_number":170,"context_line":"            fixed_ips\u003dfixed_ips)[\u0027interfaceAttachment\u0027]"},{"line_number":171,"context_line":"        def _clean_port_accept_already_deleted(pc, port_id):"},{"line_number":172,"context_line":"            try:"},{"line_number":173,"context_line":"                pc.delete_port(port_id)"},{"line_number":174,"context_line":"            except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7d2a8478","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":46},"in_reply_to":"3f79a3b5_87495130","updated":"2018-11-05 03:12:22.000000000","message":"Yes.\nBesides, I wonder whether the port should be deleted automatically? or both are ok?","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"76906f14761e66612588962b7b32c8169afd81e7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        iface \u003d self.interfaces_client.create_interface("},{"line_number":169,"context_line":"            server[\u0027id\u0027], net_id\u003dnetwork_id,"},{"line_number":170,"context_line":"            fixed_ips\u003dfixed_ips)[\u0027interfaceAttachment\u0027]"},{"line_number":171,"context_line":"        def _clean_port_accept_already_deleted(pc, port_id):"},{"line_number":172,"context_line":"            try:"},{"line_number":173,"context_line":"                pc.delete_port(port_id)"},{"line_number":174,"context_line":"            except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3b03ad77","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":46},"in_reply_to":"3f79a3b5_87495130","updated":"2018-11-05 13:50:36.000000000","message":"will do","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9828f99ebba5aa021ed0a3b2dfc079f553d8908d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        try:"},{"line_number":228,"context_line":"            iface \u003d self._test_create_interface(server)"},{"line_number":229,"context_line":"        except lib_exc.BadRequest as e:"},{"line_number":230,"context_line":"            msg \u003d (\u0027Multiple possible networks found, use a Network ID to be \u0027"},{"line_number":231,"context_line":"                   \u0027more specific.\u0027)"},{"line_number":232,"context_line":"            if not CONF.compute.fixed_network_name and six.text_type(e) \u003d\u003d msg:"},{"line_number":233,"context_line":"                raise"},{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            ifs.append(iface)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_dd1b986c","line":233,"range":{"start_line":230,"start_character":0,"end_line":233,"end_character":21},"updated":"2018-11-05 03:12:22.000000000","message":"If test_create_list_show_delete_interfaces_by_fixed_ip failed, I wonder why this not failed?","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"76906f14761e66612588962b7b32c8169afd81e7","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        try:"},{"line_number":228,"context_line":"            iface \u003d self._test_create_interface(server)"},{"line_number":229,"context_line":"        except lib_exc.BadRequest as e:"},{"line_number":230,"context_line":"            msg \u003d (\u0027Multiple possible networks found, use a Network ID to be \u0027"},{"line_number":231,"context_line":"                   \u0027more specific.\u0027)"},{"line_number":232,"context_line":"            if not CONF.compute.fixed_network_name and six.text_type(e) \u003d\u003d msg:"},{"line_number":233,"context_line":"                raise"},{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            ifs.append(iface)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7ba12592","line":233,"range":{"start_line":230,"start_character":0,"end_line":233,"end_character":21},"in_reply_to":"3f79a3b5_dd1b986c","updated":"2018-11-05 13:50:36.000000000","message":"it only raises when CONF.compute.fixed_network_name is not set, this config options seams to be pre historic, `single flat network` case.","commit_id":"2a815b851315294e26ed6c7e4b45463d54b8fff6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4d0a574e1c5fc0e121d55199f45a3afb450a8d06","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        interface_count \u003d len(ifs)"},{"line_number":261,"context_line":"        self.assertGreater(interface_count, 0)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        try:"},{"line_number":264,"context_line":"            iface \u003d self._test_create_interface(server)"},{"line_number":265,"context_line":"        except lib_exc.BadRequest as e:"},{"line_number":266,"context_line":"            msg \u003d (\u0027Multiple possible networks found, use a Network ID to be \u0027"},{"line_number":267,"context_line":"                   \u0027more specific.\u0027)"},{"line_number":268,"context_line":"            if not CONF.compute.fixed_network_name and six.text_type(e) \u003d\u003d msg:"},{"line_number":269,"context_line":"                raise"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            ifs.append(iface)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        iface \u003d self._test_create_interface_by_fixed_ips(server, ifs)"},{"line_number":274,"context_line":"        ifs.append(iface)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5a7b632a","side":"PARENT","line":271,"range":{"start_line":263,"start_character":0,"end_line":271,"end_character":29},"updated":"2018-11-13 21:45:41.000000000","message":"TBH, this test code seemed a little tricky and it was hard to understand the purpose. So good for me to remove it.","commit_id":"da8aec9aedcac940ba1dbc3beee50f05f13af3f1"}]}