)]}'
{"tempest/lib/api_schema/response/volume/volumes.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"498e74d3e52142a73b77735ea7437c0974cde8ac","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":67,"context_line":"        \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":70,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":71,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":72,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bf7f3767","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":49},"updated":"2018-11-09 23:11:41.000000000","message":"Missing in the API docs for https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dshow-a-volume-s-details-detail#show-a-volume-s-details","commit_id":"6bc85cea39fe70683e48170277e5ec7967d01444"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"acc4b40f1845adeecc04c67c21c46c39bd4edbf0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":67,"context_line":"        \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":70,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":71,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":72,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_853222bf","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":49},"in_reply_to":"3f79a3b5_bf7f3767","updated":"2018-11-12 02:37:16.000000000","message":"Yes https://review.openstack.org/#/c/616779/ will fix it","commit_id":"6bc85cea39fe70683e48170277e5ec7967d01444"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"498e74d3e52142a73b77735ea7437c0974cde8ac","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":175,"context_line":"                    \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":176,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":177,"context_line":"                    \u0027group_id\u0027: parameter_types.uuid_or_null"},{"line_number":178,"context_line":"                },"},{"line_number":179,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":180,"context_line":"                \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3f9327a6","line":177,"range":{"start_line":177,"start_character":20,"end_line":177,"end_character":60},"updated":"2018-11-09 23:11:41.000000000","message":"Ditto","commit_id":"6bc85cea39fe70683e48170277e5ec7967d01444"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"107fa6a330490d85f1baa3acb05e498e19bebcd7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"common_show_volume \u003d {"},{"line_number":39,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":40,"context_line":"    \u0027properties\u0027: {"},{"line_number":41,"context_line":"        \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_7db74df7","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":18},"updated":"2019-08-23 01:30:39.000000000","message":"confirmed","commit_id":"49d31305d44d0632bac7e1b661f03f3b7b1bf182"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"107fa6a330490d85f1baa3acb05e498e19bebcd7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"show_volume \u003d {"},{"line_number":117,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":118,"context_line":"    \u0027response_body\u0027: {"},{"line_number":119,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_1dcc1989","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":11},"updated":"2019-08-23 01:30:39.000000000","message":"confirmed","commit_id":"49d31305d44d0632bac7e1b661f03f3b7b1bf182"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"107fa6a330490d85f1baa3acb05e498e19bebcd7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"# TODO(zhufl): count is added in 3.45, we should move it to the 3.45 schema"},{"line_number":130,"context_line":"# file when microversion is supported in volume interfaces"},{"line_number":131,"context_line":"list_volumes_detail[\u0027properties\u0027].update({\u0027count\u0027: {\u0027type\u0027: \u0027integer\u0027}})"},{"line_number":132,"context_line":"list_volumes_with_detail \u003d {"},{"line_number":133,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":134,"context_line":"    \u0027response_body\u0027: {"},{"line_number":135,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_ddc5215e","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":24},"updated":"2019-08-23 01:30:39.000000000","message":"confirmed","commit_id":"49d31305d44d0632bac7e1b661f03f3b7b1bf182"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"107fa6a330490d85f1baa3acb05e498e19bebcd7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"create_volume \u003d {"},{"line_number":149,"context_line":"    \u0027status_code\u0027: [202],"},{"line_number":150,"context_line":"    \u0027response_body\u0027: {"},{"line_number":151,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_3d8eb532","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":13},"updated":"2019-08-23 01:30:39.000000000","message":"confirmed","commit_id":"49d31305d44d0632bac7e1b661f03f3b7b1bf182"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"107fa6a330490d85f1baa3acb05e498e19bebcd7","unresolved":false,"context_lines":[{"line_number":194,"context_line":"update_volume \u003d copy.deepcopy(create_volume)"},{"line_number":195,"context_line":"update_volume.update({\u0027status_code\u0027: [200]})"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"delete_volume \u003d {\u0027status_code\u0027: [202]}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"show_volume_summary \u003d {"},{"line_number":200,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_fd97bd44","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":13},"updated":"2019-08-23 01:30:39.000000000","message":"confirmed","commit_id":"49d31305d44d0632bac7e1b661f03f3b7b1bf182"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"107fa6a330490d85f1baa3acb05e498e19bebcd7","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"delete_volume \u003d {\u0027status_code\u0027: [202]}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"show_volume_summary \u003d {"},{"line_number":200,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":201,"context_line":"    \u0027response_body\u0027: {"},{"line_number":202,"context_line":"        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_dd9a016e","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":19},"updated":"2019-08-23 01:30:39.000000000","message":"confirmed","commit_id":"49d31305d44d0632bac7e1b661f03f3b7b1bf182"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":67,"context_line":"        \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":70,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":71,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":72,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_8dce8a57","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":49},"updated":"2020-05-19 21:47:05.000000000","message":"let\u0027s add this with TODO and commented.","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":67,"context_line":"        \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":70,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":71,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":72,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_4f445f47","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":49},"in_reply_to":"ff570b3c_8dce8a57","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":70,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":71,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":72,"context_line":"        # is supported in volume interfaces."},{"line_number":73,"context_line":"        \u0027service_uuid\u0027: parameter_types.uuid_or_null,"},{"line_number":74,"context_line":"        \u0027shared_targets\u0027: {\u0027type\u0027: \u0027boolean\u0027}"},{"line_number":75,"context_line":"    },"},{"line_number":76,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":77,"context_line":"    \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_4de912b5","line":74,"range":{"start_line":70,"start_character":0,"end_line":74,"end_character":45},"updated":"2020-05-19 21:47:05.000000000","message":"let\u0027s comment L7374 also so that this schema can capture if \u0027count\u0027 is returned in base API version.","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":70,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":71,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":72,"context_line":"        # is supported in volume interfaces."},{"line_number":73,"context_line":"        \u0027service_uuid\u0027: parameter_types.uuid_or_null,"},{"line_number":74,"context_line":"        \u0027shared_targets\u0027: {\u0027type\u0027: \u0027boolean\u0027}"},{"line_number":75,"context_line":"    },"},{"line_number":76,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":77,"context_line":"    \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_ef6e13c7","line":74,"range":{"start_line":70,"start_character":0,"end_line":74,"end_character":45},"in_reply_to":"ff570b3c_4de912b5","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"},{"line_number":78,"context_line":"                 \u0027updated_at\u0027, \u0027replication_status\u0027, \u0027id\u0027,"},{"line_number":79,"context_line":"                 \u0027size\u0027, \u0027user_id\u0027,"},{"line_number":80,"context_line":"                 \u0027os-vol-tenant-attr:tenant_id\u0027,"},{"line_number":81,"context_line":"                 \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":82,"context_line":"                 \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":83,"context_line":"                 \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_8d6a0a17","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":48},"updated":"2020-05-19 21:47:05.000000000","message":"this is extension things so not in required.","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"},{"line_number":78,"context_line":"                 \u0027updated_at\u0027, \u0027replication_status\u0027, \u0027id\u0027,"},{"line_number":79,"context_line":"                 \u0027size\u0027, \u0027user_id\u0027,"},{"line_number":80,"context_line":"                 \u0027os-vol-tenant-attr:tenant_id\u0027,"},{"line_number":81,"context_line":"                 \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":82,"context_line":"                 \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":83,"context_line":"                 \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_6f6203da","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":48},"in_reply_to":"ff570b3c_8d6a0a17","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"},{"line_number":78,"context_line":"                 \u0027updated_at\u0027, \u0027replication_status\u0027, \u0027id\u0027,"},{"line_number":79,"context_line":"                 \u0027size\u0027, \u0027user_id\u0027,"},{"line_number":80,"context_line":"                 \u0027os-vol-tenant-attr:tenant_id\u0027,"},{"line_number":81,"context_line":"                 \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":82,"context_line":"                 \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":83,"context_line":"                 \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0f66e7ed","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":48},"in_reply_to":"ff570b3c_8d6a0a17","updated":"2020-06-04 09:33:01.000000000","message":"are we sure because in the doc it\u0027s not marked as optional:\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-a-volume-s-details-detail","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                 \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":82,"context_line":"                 \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":83,"context_line":"                 \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":84,"context_line":"                 \u0027volume_type\u0027]"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"list_volumes_no_detail \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_4d37524e","line":84,"range":{"start_line":84,"start_character":30,"end_line":84,"end_character":31},"updated":"2020-05-19 21:47:05.000000000","message":"Below fields are also mandatory as per [1]\n- availability_zone\n- snapshot_id\n- source_volid\n\n[1] https://github.com/openstack/cinder/blob/85e60732e21ee30937d43d8b77295e4525e1c8fc/cinder/api/v2/views/volumes.py#L70","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                 \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":82,"context_line":"                 \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":83,"context_line":"                 \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":84,"context_line":"                 \u0027volume_type\u0027]"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"list_volumes_no_detail \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_efa3b3fe","line":84,"range":{"start_line":84,"start_character":30,"end_line":84,"end_character":31},"in_reply_to":"ff570b3c_4d37524e","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                 \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":82,"context_line":"                 \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":83,"context_line":"                 \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":84,"context_line":"                 \u0027volume_type\u0027]"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"list_volumes_no_detail \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_6f6163d3","line":84,"range":{"start_line":84,"start_character":30,"end_line":84,"end_character":31},"in_reply_to":"ff570b3c_4d37524e","updated":"2020-06-04 09:33:01.000000000","message":"but per the doc they are not mandatory:\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-a-volume-s-details-detail","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                        \u0027links\u0027: parameter_types.links,"},{"line_number":98,"context_line":"                        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":99,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":100,"context_line":"                        # TODO(zhufl): count is added in 3.45, we should move"},{"line_number":101,"context_line":"                        # it to the 3.45 schema file when microversion is"},{"line_number":102,"context_line":"                        # supported in volume interfaces"},{"line_number":103,"context_line":"                        \u0027count\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":104,"context_line":"                    },"},{"line_number":105,"context_line":"                    \u0027additionalProperties\u0027: False,"},{"line_number":106,"context_line":"                    \u0027required\u0027: [\u0027links\u0027, \u0027id\u0027, \u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_cd71a246","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":52},"updated":"2020-05-19 21:47:05.000000000","message":"let\u0027s comment L103 also so that this schema can capture if \u0027count\u0027 is returned in base API version.","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                        \u0027links\u0027: parameter_types.links,"},{"line_number":98,"context_line":"                        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":99,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":100,"context_line":"                        # TODO(zhufl): count is added in 3.45, we should move"},{"line_number":101,"context_line":"                        # it to the 3.45 schema file when microversion is"},{"line_number":102,"context_line":"                        # supported in volume interfaces"},{"line_number":103,"context_line":"                        \u0027count\u0027: {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":104,"context_line":"                    },"},{"line_number":105,"context_line":"                    \u0027additionalProperties\u0027: False,"},{"line_number":106,"context_line":"                    \u0027required\u0027: [\u0027links\u0027, \u0027id\u0027, \u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0fac27eb","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":52},"in_reply_to":"ff570b3c_cd71a246","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"list_volumes_detail \u003d copy.deepcopy(common_show_volume)"},{"line_number":129,"context_line":"# TODO(zhufl): count is added in 3.45, we should move it to the 3.45 schema"},{"line_number":130,"context_line":"# file when microversion is supported in volume interfaces"},{"line_number":131,"context_line":"list_volumes_detail[\u0027properties\u0027].update({\u0027count\u0027: {\u0027type\u0027: \u0027integer\u0027}})"},{"line_number":132,"context_line":"list_volumes_with_detail \u003d {"},{"line_number":133,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":134,"context_line":"    \u0027response_body\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0d68ba1a","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":72},"updated":"2020-05-19 21:47:05.000000000","message":"ditto, let\u0027s comment this but leave as TODO","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"list_volumes_detail \u003d copy.deepcopy(common_show_volume)"},{"line_number":129,"context_line":"# TODO(zhufl): count is added in 3.45, we should move it to the 3.45 schema"},{"line_number":130,"context_line":"# file when microversion is supported in volume interfaces"},{"line_number":131,"context_line":"list_volumes_detail[\u0027properties\u0027].update({\u0027count\u0027: {\u0027type\u0027: \u0027integer\u0027}})"},{"line_number":132,"context_line":"list_volumes_with_detail \u003d {"},{"line_number":133,"context_line":"    \u0027status_code\u0027: [200],"},{"line_number":134,"context_line":"    \u0027response_body\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_af39bba4","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":72},"in_reply_to":"ff570b3c_0d68ba1a","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":175,"context_line":"                    \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":176,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":177,"context_line":"                    \u0027group_id\u0027: parameter_types.uuid_or_null"},{"line_number":178,"context_line":"                },"},{"line_number":179,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":180,"context_line":"                \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0d539a18","line":177,"range":{"start_line":177,"start_character":17,"end_line":177,"end_character":60},"updated":"2020-05-19 21:47:05.000000000","message":"this is added in \u00273.13\u0027, let\u0027s remove this from base schema so that we can capture if this is returned in old API version also. We will add once we implement the microversion schema\n\n- https://github.com/openstack/cinder/blob/85e60732e21ee30937d43d8b77295e4525e1c8fc/cinder/api/v3/views/volumes.py#L49","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":175,"context_line":"                    \u0027created_at\u0027: parameter_types.date_time,"},{"line_number":176,"context_line":"                    \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":177,"context_line":"                    \u0027group_id\u0027: parameter_types.uuid_or_null"},{"line_number":178,"context_line":"                },"},{"line_number":179,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":180,"context_line":"                \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_6f49635e","line":177,"range":{"start_line":177,"start_character":17,"end_line":177,"end_character":60},"in_reply_to":"ff570b3c_0d539a18","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                             \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":184,"context_line":"                             \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":185,"context_line":"                             \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":186,"context_line":"                             \u0027volume_type\u0027]"},{"line_number":187,"context_line":"            }"},{"line_number":188,"context_line":"        },"},{"line_number":189,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0d055a11","line":186,"range":{"start_line":186,"start_character":42,"end_line":186,"end_character":43},"updated":"2020-05-19 21:47:05.000000000","message":"Below fields are also mandatory as per [1]\n- availability_zone\n- snapshot_id\n- source_volid\n\n[1] https://github.com/openstack/cinder/blob/85e60732e21ee30937d43d8b77295e4525e1c8fc/cinder/api/v2/views/volumes.py#L70","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                             \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":184,"context_line":"                             \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":185,"context_line":"                             \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":186,"context_line":"                             \u0027volume_type\u0027]"},{"line_number":187,"context_line":"            }"},{"line_number":188,"context_line":"        },"},{"line_number":189,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_2fc80ba4","line":186,"range":{"start_line":186,"start_character":42,"end_line":186,"end_character":43},"in_reply_to":"ff570b3c_0d055a11","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                             \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":184,"context_line":"                             \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":185,"context_line":"                             \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":186,"context_line":"                             \u0027volume_type\u0027]"},{"line_number":187,"context_line":"            }"},{"line_number":188,"context_line":"        },"},{"line_number":189,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_4fb1ff43","line":186,"range":{"start_line":186,"start_character":42,"end_line":186,"end_character":43},"in_reply_to":"ff570b3c_0d055a11","updated":"2020-06-04 09:33:01.000000000","message":"not based on the documentation:\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dcreate-a-volume-detail","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aac7fdbc0ea8838f539b4cb47e8aa39bd43ab7ef","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                             \u0027metadata\u0027, \u0027status\u0027, \u0027description\u0027,"},{"line_number":184,"context_line":"                             \u0027multiattach\u0027, \u0027consistencygroup_id\u0027,"},{"line_number":185,"context_line":"                             \u0027name\u0027, \u0027bootable\u0027, \u0027created_at\u0027,"},{"line_number":186,"context_line":"                             \u0027volume_type\u0027]"},{"line_number":187,"context_line":"            }"},{"line_number":188,"context_line":"        },"},{"line_number":189,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_e8b55b7f","line":186,"range":{"start_line":186,"start_character":42,"end_line":186,"end_character":43},"in_reply_to":"ff570b3c_4fb1ff43","updated":"2020-06-05 02:29:14.000000000","message":"maybe the doc is not accurate?:)","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    # TODO(zhufl): count is added in 3.36, we should move"},{"line_number":210,"context_line":"                    # it to the 3.36 schema file when microversion is"},{"line_number":211,"context_line":"                    # supported in volume interfaces"},{"line_number":212,"context_line":"                    \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":215,"context_line":"                \u0027required\u0027: [\u0027total_size\u0027, \u0027total_count\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_6dd056ca","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":51},"updated":"2020-05-19 21:47:05.000000000","message":"ditto","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    # TODO(zhufl): count is added in 3.36, we should move"},{"line_number":210,"context_line":"                    # it to the 3.36 schema file when microversion is"},{"line_number":211,"context_line":"                    # supported in volume interfaces"},{"line_number":212,"context_line":"                    \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":215,"context_line":"                \u0027required\u0027: [\u0027total_size\u0027, \u0027total_count\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_ef0d73e8","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":51},"in_reply_to":"ff570b3c_6dd056ca","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                    # TODO(zhufl): visibility and protected are added in 3.1,"},{"line_number":237,"context_line":"                    # we should move it to the 3.1 schema file when"},{"line_number":238,"context_line":"                    # microversion is supported in volume interfaces"},{"line_number":239,"context_line":"                    \u0027visibility\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":240,"context_line":"                    \u0027protected\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":241,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":242,"context_line":"                    \u0027image_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":243,"context_line":"                    \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_68b5e4ed","line":240,"range":{"start_line":239,"start_character":0,"end_line":240,"end_character":53},"updated":"2020-05-19 21:47:05.000000000","message":"ditto let\u0027s comment these also and test response in base schema.","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                    # TODO(zhufl): visibility and protected are added in 3.1,"},{"line_number":237,"context_line":"                    # we should move it to the 3.1 schema file when"},{"line_number":238,"context_line":"                    # microversion is supported in volume interfaces"},{"line_number":239,"context_line":"                    \u0027visibility\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":240,"context_line":"                    \u0027protected\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":241,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":242,"context_line":"                    \u0027image_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":243,"context_line":"                    \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_6fbe83ff","line":240,"range":{"start_line":239,"start_character":0,"end_line":240,"end_character":53},"in_reply_to":"ff570b3c_68b5e4ed","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":268,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027image_name\u0027, \u0027updated_at\u0027, \u0027image_id\u0027,"},{"line_number":269,"context_line":"                             \u0027display_description\u0027, \u0027id\u0027, \u0027size\u0027,"},{"line_number":270,"context_line":"                             \u0027volume_type\u0027]"},{"line_number":271,"context_line":"            }"},{"line_number":272,"context_line":"        },"},{"line_number":273,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_680e84e5","line":270,"range":{"start_line":270,"start_character":42,"end_line":270,"end_character":43},"updated":"2020-05-19 21:47:05.000000000","message":"disk_format and container_format are also mandatory\n\n- https://github.com/openstack/cinder/blob/f01bfeead9c716f066cea222cdf243bd95b5e432/cinder/volume/api.py#L1356","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":268,"context_line":"                \u0027required\u0027: [\u0027status\u0027, \u0027image_name\u0027, \u0027updated_at\u0027, \u0027image_id\u0027,"},{"line_number":269,"context_line":"                             \u0027display_description\u0027, \u0027id\u0027, \u0027size\u0027,"},{"line_number":270,"context_line":"                             \u0027volume_type\u0027]"},{"line_number":271,"context_line":"            }"},{"line_number":272,"context_line":"        },"},{"line_number":273,"context_line":"        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0f48a72a","line":270,"range":{"start_line":270,"start_character":42,"end_line":270,"end_character":43},"in_reply_to":"ff570b3c_680e84e5","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3beaa830aaa760326287639aa6f69267b1cfe5a0","unresolved":false,"context_lines":[{"line_number":324,"context_line":"update_volume_metadata_item \u003d copy.deepcopy(show_volume_metadata_item)"},{"line_number":325,"context_line":"delete_volume_metadata_item \u003d {\u0027status_code\u0027: [200]}"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"retype_volume \u003d {\u0027status_code\u0027: [202]}"},{"line_number":328,"context_line":"force_detach_volume \u003d {\u0027status_code\u0027: [202]}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"update_volume_image_metadata \u003d {"},{"line_number":331,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_289e4cb8","line":328,"range":{"start_line":327,"start_character":0,"end_line":328,"end_character":44},"updated":"2020-05-19 21:47:05.000000000","message":"can you move these actions also at L287","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0910701a8147cdb389260cbcae0130e9b153c914","unresolved":false,"context_lines":[{"line_number":324,"context_line":"update_volume_metadata_item \u003d copy.deepcopy(show_volume_metadata_item)"},{"line_number":325,"context_line":"delete_volume_metadata_item \u003d {\u0027status_code\u0027: [200]}"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"retype_volume \u003d {\u0027status_code\u0027: [202]}"},{"line_number":328,"context_line":"force_detach_volume \u003d {\u0027status_code\u0027: [202]}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"update_volume_image_metadata \u003d {"},{"line_number":331,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_2f764b71","line":328,"range":{"start_line":327,"start_character":0,"end_line":328,"end_character":44},"in_reply_to":"ff570b3c_289e4cb8","updated":"2020-05-20 07:00:29.000000000","message":"Done","commit_id":"5a2da412be7ea36bdcc5fdf97b22073e53b148e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b9024dfb211590cc2ea58ec4144c2dc6b92e975","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        # TODO(zhufl): group_id is added in 3.13, we should move it to the"},{"line_number":70,"context_line":"        # 3.13 schema file when microversion is supported in volume interfaces"},{"line_number":71,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":72,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":73,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":74,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_d7a9e8dd","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":49},"updated":"2020-05-22 19:40:25.000000000","message":"this is not commented out.","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1cc027fb36549f02e8ef61c6e5415a0508cb803","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        # TODO(zhufl): group_id is added in 3.13, we should move it to the"},{"line_number":70,"context_line":"        # 3.13 schema file when microversion is supported in volume interfaces"},{"line_number":71,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":72,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":73,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":74,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_e00c0f3d","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":49},"in_reply_to":"ff570b3c_9d3140a6","updated":"2020-05-25 15:05:13.000000000","message":"this is because we are using this schema for new microverion tests also. If you see the failed tests, those are with \u003e\u003d 3.13 microversion.\n\nWe need to add the versioning cap for microversion schema which is what you have in TODO. so let\u0027s proceed for now and later we can add the version cap to test it more strictly. \n\n- https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_227/616783/13/check/tempest-full-py3/2273338/testr_results.html\n\n- https://github.com/openstack/tempest/blob/ad25f2577b1118ab47db972bb11dd9ac29c34159/tempest/api/volume/admin/test_groups.py#L27","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01a820c9c638f8a50918e5be1596126f41643003","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        # TODO(zhufl): group_id is added in 3.13, we should move it to the"},{"line_number":70,"context_line":"        # 3.13 schema file when microversion is supported in volume interfaces"},{"line_number":71,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":72,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":73,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":74,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_9d3140a6","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":49},"in_reply_to":"ff570b3c_d62c404c","updated":"2020-05-25 14:24:23.000000000","message":"then this can be another bug? I will check the code in afternoon.","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e64e9dfaba2f9f3e51cb016b995916adfdda28cc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \u0027volume_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":69,"context_line":"        # TODO(zhufl): group_id is added in 3.13, we should move it to the"},{"line_number":70,"context_line":"        # 3.13 schema file when microversion is supported in volume interfaces"},{"line_number":71,"context_line":"        \u0027group_id\u0027: parameter_types.uuid_or_null,"},{"line_number":72,"context_line":"        # TODO(zhufl): service_uuid and shared_targets are added in 3.48,"},{"line_number":73,"context_line":"        # we should move them to the 3.48 schema file when microversion"},{"line_number":74,"context_line":"        # is supported in volume interfaces."}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_d62c404c","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":49},"in_reply_to":"ff570b3c_d7a9e8dd","updated":"2020-05-25 01:37:57.000000000","message":"I ever commented out this, and some testcases failed in ci(the responses contains group_id), so I added it back","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b9024dfb211590cc2ea58ec4144c2dc6b92e975","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                    # TODO(zhufl): group_id is added in 3.13, we should move"},{"line_number":179,"context_line":"                    # it to the 3.13 schema file when microversion is"},{"line_number":180,"context_line":"                    # supported in volume interfaces."},{"line_number":181,"context_line":"                    \u0027group_id\u0027: parameter_types.uuid_or_null"},{"line_number":182,"context_line":"                },"},{"line_number":183,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":184,"context_line":"                \u0027required\u0027: [\u0027attachments\u0027, \u0027links\u0027, \u0027encrypted\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_57879862","line":181,"range":{"start_line":181,"start_character":20,"end_line":181,"end_character":60},"updated":"2020-05-22 19:40:25.000000000","message":"ditto","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9f5438abd6b6ee85907795110be019d978c6cfa4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":238,"context_line":"                    \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":239,"context_line":"                    \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":240,"context_line":"                    # TODO(zhufl): visibility and protected are added in 3.1,"},{"line_number":241,"context_line":"                    # we should move it to the 3.1 schema file when"},{"line_number":242,"context_line":"                    # microversion is supported in volume interfaces"},{"line_number":243,"context_line":"                    # \u0027visibility\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":244,"context_line":"                    # \u0027protected\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":245,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":246,"context_line":"                    \u0027image_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":247,"context_line":"                    \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_7d039dbf","line":244,"range":{"start_line":240,"start_character":20,"end_line":244,"end_character":55},"updated":"2020-05-22 22:26:32.000000000","message":"they\u0027re returned in 2.0 as well but since 3.1 they can be sent in request to glance.\nthe MV is for request params and not response params.","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e2ff92b3624b47e58d8942be885ec935e1268e3","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":238,"context_line":"                    \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":239,"context_line":"                    \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":240,"context_line":"                    # TODO(zhufl): visibility and protected are added in 3.1,"},{"line_number":241,"context_line":"                    # we should move it to the 3.1 schema file when"},{"line_number":242,"context_line":"                    # microversion is supported in volume interfaces"},{"line_number":243,"context_line":"                    # \u0027visibility\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":244,"context_line":"                    # \u0027protected\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":245,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":246,"context_line":"                    \u0027image_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":247,"context_line":"                    \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_5dfe88ae","line":244,"range":{"start_line":240,"start_character":20,"end_line":244,"end_character":55},"in_reply_to":"ff570b3c_2be6ede9","updated":"2020-05-25 14:23:10.000000000","message":"added bug report, at least API not behaving what api-ref mentioned\n- https://bugs.launchpad.net/cinder/+bug/1880566\n\nlet\u0027s separate the upload volume schema in separate patch and continue the discussion there and merge all other schemas.","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2ef35b0b3d2025ba8bae8336899d49ee76d69c5a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":238,"context_line":"                    \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":239,"context_line":"                    \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":240,"context_line":"                    # TODO(zhufl): visibility and protected are added in 3.1,"},{"line_number":241,"context_line":"                    # we should move it to the 3.1 schema file when"},{"line_number":242,"context_line":"                    # microversion is supported in volume interfaces"},{"line_number":243,"context_line":"                    # \u0027visibility\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":244,"context_line":"                    # \u0027protected\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":245,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":246,"context_line":"                    \u0027image_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":247,"context_line":"                    \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_2be6ede9","line":244,"range":{"start_line":240,"start_character":20,"end_line":244,"end_character":55},"in_reply_to":"ff570b3c_7d039dbf","updated":"2020-05-25 13:49:52.000000000","message":"humm, I am confused. These field were added in API response also from 3.1 onwards only\n- https://review.opendev.org/#/c/230617/40/cinder/volume/api.py\n\nAlso API ref says the same that these two fields are new in 3.1\n- https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail#volume-actions-volumes-action","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e64e9dfaba2f9f3e51cb016b995916adfdda28cc","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    \u0027disk_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":238,"context_line":"                    \u0027container_format\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":239,"context_line":"                    \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":240,"context_line":"                    # TODO(zhufl): visibility and protected are added in 3.1,"},{"line_number":241,"context_line":"                    # we should move it to the 3.1 schema file when"},{"line_number":242,"context_line":"                    # microversion is supported in volume interfaces"},{"line_number":243,"context_line":"                    # \u0027visibility\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":244,"context_line":"                    # \u0027protected\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":245,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":246,"context_line":"                    \u0027image_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":247,"context_line":"                    \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_5620304a","line":244,"range":{"start_line":240,"start_character":20,"end_line":244,"end_character":55},"in_reply_to":"ff570b3c_7d039dbf","updated":"2020-05-25 01:37:57.000000000","message":"oh, got it, done","commit_id":"ce279a3806ae6754a0bddcf34831898ce673adc2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ede2e0686326ff84ac136a5cb0eccd00386f462a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"#                     }"},{"line_number":269,"context_line":"#                 },"},{"line_number":270,"context_line":"#                 \u0027additionalProperties\u0027: False,"},{"line_number":271,"context_line":"#                 \u0027required\u0027: [\u0027status\u0027, \u0027image_name\u0027, \u0027updated_at\u0027, \u0027image_id\u0027,"},{"line_number":272,"context_line":"#                              \u0027display_description\u0027, \u0027id\u0027, \u0027size\u0027,"},{"line_number":273,"context_line":"#                              \u0027volume_type\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]"},{"line_number":274,"context_line":"#             }"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff570b3c_271d790f","line":271,"updated":"2020-05-26 03:41:45.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"c88fe0e7bec952fa6556675396ace741c99eeb9c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ede2e0686326ff84ac136a5cb0eccd00386f462a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"#                 \u0027additionalProperties\u0027: False,"},{"line_number":271,"context_line":"#                 \u0027required\u0027: [\u0027status\u0027, \u0027image_name\u0027, \u0027updated_at\u0027, \u0027image_id\u0027,"},{"line_number":272,"context_line":"#                              \u0027display_description\u0027, \u0027id\u0027, \u0027size\u0027,"},{"line_number":273,"context_line":"#                              \u0027volume_type\u0027, \u0027disk_format\u0027, \u0027container_format\u0027]"},{"line_number":274,"context_line":"#             }"},{"line_number":275,"context_line":"#         },"},{"line_number":276,"context_line":"#         \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff570b3c_871a8514","line":273,"updated":"2020-05-26 03:41:45.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"c88fe0e7bec952fa6556675396ace741c99eeb9c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":42,"context_line":"        \u0027attachments\u0027: attachments,"},{"line_number":43,"context_line":"        \u0027links\u0027: parameter_types.links,"},{"line_number":44,"context_line":"        \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":45,"context_line":"        \u0027os-vol-host-attr:host\u0027: {"},{"line_number":46,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027pattern\u0027: \u0027.+@.+#.+\u0027},"},{"line_number":47,"context_line":"        \u0027encrypted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_b48bd21c","line":44,"range":{"start_line":44,"start_character":46,"end_line":44,"end_character":47},"updated":"2020-06-04 09:33:01.000000000","message":"it can be also null, right? at least according the documentation as the availability zone is marked as optional there:\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-a-volume-s-details-detail","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aac7fdbc0ea8838f539b4cb47e8aa39bd43ab7ef","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":42,"context_line":"        \u0027attachments\u0027: attachments,"},{"line_number":43,"context_line":"        \u0027links\u0027: parameter_types.links,"},{"line_number":44,"context_line":"        \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":45,"context_line":"        \u0027os-vol-host-attr:host\u0027: {"},{"line_number":46,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027pattern\u0027: \u0027.+@.+#.+\u0027},"},{"line_number":47,"context_line":"        \u0027encrypted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_28d11324","line":44,"range":{"start_line":44,"start_character":46,"end_line":44,"end_character":47},"in_reply_to":"ff570b3c_b48bd21c","updated":"2020-06-05 02:29:14.000000000","message":"Done","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027os-vol-mig-status-attr:migstat\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"        \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":58,"context_line":"        \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"        \u0027volume_image_metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":60,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":61,"context_line":"        \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":62,"context_line":"        \u0027source_volid\u0027: parameter_types.uuid_or_null,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_54707640","line":59,"range":{"start_line":59,"start_character":50,"end_line":59,"end_character":51},"updated":"2020-06-04 09:33:01.000000000","message":"this is optional as well, so should we add also null type?","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aac7fdbc0ea8838f539b4cb47e8aa39bd43ab7ef","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027os-vol-mig-status-attr:migstat\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":57,"context_line":"        \u0027metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":58,"context_line":"        \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":59,"context_line":"        \u0027volume_image_metadata\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":60,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":61,"context_line":"        \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":62,"context_line":"        \u0027source_volid\u0027: parameter_types.uuid_or_null,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_88993f20","line":59,"range":{"start_line":59,"start_character":50,"end_line":59,"end_character":51},"in_reply_to":"ff570b3c_54707640","updated":"2020-06-05 02:29:14.000000000","message":"Done","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":61,"context_line":"        \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":62,"context_line":"        \u0027source_volid\u0027: parameter_types.uuid_or_null,"},{"line_number":63,"context_line":"        \u0027consistencygroup_id\u0027: parameter_types.uuid_or_null,"},{"line_number":64,"context_line":"        \u0027os-vol-mig-status-attr:name_id\u0027: parameter_types.uuid_or_null,"},{"line_number":65,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_d4000669","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":8},"updated":"2020-06-04 09:33:01.000000000","message":"shouldn\u0027t be here also volume?\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dshow-a-volume-s-details-detail","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0a1bdf4538112abb3e0c106da6dfe178d0095e84","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":61,"context_line":"        \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":62,"context_line":"        \u0027source_volid\u0027: parameter_types.uuid_or_null,"},{"line_number":63,"context_line":"        \u0027consistencygroup_id\u0027: parameter_types.uuid_or_null,"},{"line_number":64,"context_line":"        \u0027os-vol-mig-status-attr:name_id\u0027: parameter_types.uuid_or_null,"},{"line_number":65,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_7fa0e3f4","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":8},"in_reply_to":"9f560f44_d16e48c7","updated":"2020-08-07 19:28:30.000000000","message":"oh, yeah, i missed that .. it\u0027s ok then","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aac7fdbc0ea8838f539b4cb47e8aa39bd43ab7ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":61,"context_line":"        \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":62,"context_line":"        \u0027source_volid\u0027: parameter_types.uuid_or_null,"},{"line_number":63,"context_line":"        \u0027consistencygroup_id\u0027: parameter_types.uuid_or_null,"},{"line_number":64,"context_line":"        \u0027os-vol-mig-status-attr:name_id\u0027: parameter_types.uuid_or_null,"},{"line_number":65,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_68d82b1d","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":8},"in_reply_to":"ff570b3c_d4000669","updated":"2020-06-05 02:29:14.000000000","message":"Sorry I don\u0027t catch it?","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5badf0c64fb8aeeadeed03b59407e36fe4c110e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":61,"context_line":"        \u0027multiattach\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":62,"context_line":"        \u0027source_volid\u0027: parameter_types.uuid_or_null,"},{"line_number":63,"context_line":"        \u0027consistencygroup_id\u0027: parameter_types.uuid_or_null,"},{"line_number":64,"context_line":"        \u0027os-vol-mig-status-attr:name_id\u0027: parameter_types.uuid_or_null,"},{"line_number":65,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":66,"context_line":"        \u0027bootable\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_d16e48c7","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":8},"in_reply_to":"ff570b3c_d4000669","updated":"2020-08-07 17:29:10.000000000","message":"that is volume object at the top level of response dict which is at L122","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"183a7b47d310e346ff73843f67def577ef8dcb72","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":158,"context_line":"                    \u0027attachments\u0027: attachments,"},{"line_number":159,"context_line":"                    \u0027links\u0027: parameter_types.links,"},{"line_number":160,"context_line":"                    \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":161,"context_line":"                    \u0027encrypted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":162,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":163,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_d40e468a","line":160,"range":{"start_line":160,"start_character":57,"end_line":160,"end_character":60},"updated":"2020-06-04 09:33:01.000000000","message":"shouldn\u0027t we add also null here as it\u0027s optional property?\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dcreate-a-volume-detail","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"aac7fdbc0ea8838f539b4cb47e8aa39bd43ab7ef","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    \u0027migration_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":158,"context_line":"                    \u0027attachments\u0027: attachments,"},{"line_number":159,"context_line":"                    \u0027links\u0027: parameter_types.links,"},{"line_number":160,"context_line":"                    \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":161,"context_line":"                    \u0027encrypted\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":162,"context_line":"                    \u0027updated_at\u0027: parameter_types.date_time_or_null,"},{"line_number":163,"context_line":"                    \u0027replication_status\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff570b3c_28d2b300","line":160,"range":{"start_line":160,"start_character":57,"end_line":160,"end_character":60},"in_reply_to":"ff570b3c_d40e468a","updated":"2020-06-05 02:29:14.000000000","message":"Done","commit_id":"97a432dbf5b88d130a1b1b856c0ea649dee643b8"}]}