)]}'
{"tempest/api/identity/admin/v3/test_trusts.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"cfa9d89cc6a4bae6c13010a1865f990d59a3f7c0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.delete_trust()"},{"line_number":48,"context_line":"        super(TrustsV3TestJSON, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_trustor_and_roles(self):"},{"line_number":51,"context_line":"        # create a project that trusts will be granted on"},{"line_number":52,"context_line":"        trustor_project_name \u003d data_utils.rand_name(name\u003d\u0027project\u0027)"},{"line_number":53,"context_line":"        project \u003d self.projects_client.create_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_aed8527c","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":32},"updated":"2018-11-12 18:37:02.000000000","message":"it may be worth changing this method to use resource_setup instead so we can use addClassResourceCleanup[1] instead of addCleanup.\n\nSee an example of resource_setup and addClassResourceCleanup here[2]\n\n[1] http://git.openstack.org/cgit/openstack/tempest/tree/HACKING.rst#n181\n[2] http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/admin/test_flavors_extra_specs.py#n37","commit_id":"26eda82c3b2f08225c399c288e2c62c30d8efe0a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"075df0ae2e6efc0a39aaadfaff8f1801e612815f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.delete_trust()"},{"line_number":48,"context_line":"        super(TrustsV3TestJSON, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def create_trustor_and_roles(self):"},{"line_number":51,"context_line":"        # create a project that trusts will be granted on"},{"line_number":52,"context_line":"        trustor_project_name \u003d data_utils.rand_name(name\u003d\u0027project\u0027)"},{"line_number":53,"context_line":"        project \u003d self.projects_client.create_project("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7448c888","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":32},"in_reply_to":"3f79a3b5_aed8527c","updated":"2018-11-12 21:49:56.000000000","message":"This is better the way it is because it\u0027s used in setUp(). Besides that resource_setup isn\u0027t ideal; it\u0027s used for creating expensive resources. It\u0027s better to use setUp() and tearDown() for test isolation reasons. resource_setup/resource_cleanup are useful too, but identity resources are efficient to create.\n\nBut yes, addClassResourceCleanup is the best way to clean up resources if using resource_setup -- but not necessarily the best way overall.","commit_id":"26eda82c3b2f08225c399c288e2c62c30d8efe0a"}]}