)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"7baf76feaa6547ed1c3e36fcf1c1a375c41ddec4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lianghao \u003clianghao@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-11-14 13:12:06 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check connectivity of ipv4 gateway in test_network_v6"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia3a4d33eb0fa21a9c2e52c92d28b4bc028854988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_082a1e2d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"updated":"2018-11-21 05:42:57.000000000","message":"Could you please add description/explanation for this PS.","commit_id":"53da3596e898be9b00c534ad6083d9af6236dbfe"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e0a2be18a5441f8eac64df41fdc0d3503c94743a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check connectivity of ipv4 gateway in test_network_v6"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If not check connectivity of ipv4 gateway, we can\u0027t assret that"},{"line_number":10,"context_line":"\"self.routers_client.add_router_interface(router[\u0027id\u0027],"},{"line_number":11,"context_line":"subnet_id\u003dsub4[\u0027id\u0027])\" is really successfully."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_369886c9","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":58},"updated":"2018-12-19 01:03:19.000000000","message":"nit: s/assret/assert/","commit_id":"48ebee54e4eac3fd9e967d95c28a2af26bbc14a3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e0a2be18a5441f8eac64df41fdc0d3503c94743a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If not check connectivity of ipv4 gateway, we can\u0027t assret that"},{"line_number":10,"context_line":"\"self.routers_client.add_router_interface(router[\u0027id\u0027],"},{"line_number":11,"context_line":"subnet_id\u003dsub4[\u0027id\u0027])\" is really successfully."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia3a4d33eb0fa21a9c2e52c92d28b4bc028854988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_765efee2","line":11,"updated":"2018-12-19 01:03:19.000000000","message":"I cannot follow the above message.\nThis test is for IPv6 as the test file name and I feel it is not mandatory to check IPv4 connectivity in the test.\n\nI guess it is enough to just add error handling for calling add_router_interface() instead of adding the connectivity check, is\u0027t it right?","commit_id":"48ebee54e4eac3fd9e967d95c28a2af26bbc14a3"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"c2fa99c2ba7e271009d8bcb1c14e2cdfe9b1bff1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If not check connectivity of ipv4 gateway, we can\u0027t assret that"},{"line_number":10,"context_line":"\"self.routers_client.add_router_interface(router[\u0027id\u0027],"},{"line_number":11,"context_line":"subnet_id\u003dsub4[\u0027id\u0027])\" is really successfully."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia3a4d33eb0fa21a9c2e52c92d28b4bc028854988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_f7eedd86","line":11,"in_reply_to":"3f79a3b5_765efee2","updated":"2019-01-02 08:49:22.000000000","message":"Hi Ken\u0027ichi Ohmichi，thanks for your advise,but I think \"check connectivity of ipv4 gateway\" is better.Although  add_router_interface() is success,it can\u0027t represent gateway have no problem.","commit_id":"48ebee54e4eac3fd9e967d95c28a2af26bbc14a3"}]}