)]}'
{"tempest/api/network/admin/test_agent_management.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"9a70d7cfa3fc21c063256a7ca97d98b13d358e79","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        non_existent_id \u003d data_utils.rand_uuid()"},{"line_number":91,"context_line":"        self.assertRaises("},{"line_number":92,"context_line":"            lib_exc.NotFound,"},{"line_number":93,"context_line":"            self.agents_client.delete_agent, non_existent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_48925657","line":93,"range":{"start_line":93,"start_character":12,"end_line":93,"end_character":30},"updated":"2018-11-21 05:52:04.000000000","message":"This is also not an admin client, so it can come in non-admin tests file.","commit_id":"57fccbab8033ce4932800c13a65d69dd5dd1c63a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"adc21c8a8515b18319b1cc7261a880e0107c5e49","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        non_existent_id \u003d data_utils.rand_uuid()"},{"line_number":91,"context_line":"        self.assertRaises("},{"line_number":92,"context_line":"            lib_exc.NotFound,"},{"line_number":93,"context_line":"            self.agents_client.delete_agent, non_existent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d054b9c7","line":93,"range":{"start_line":93,"start_character":12,"end_line":93,"end_character":30},"in_reply_to":"3f79a3b5_48925657","updated":"2018-11-21 22:59:35.000000000","message":"This should actually be admin_agents_client: https://github.com/openstack/neutron/blob/4b40a4c3231486898923cee70f9d70d6ad803769/etc/policy.json#L132\n\nThis is a nit that is somewhat related so I will fix it.","commit_id":"57fccbab8033ce4932800c13a65d69dd5dd1c63a"}],"tempest/api/network/test_agent_management.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bf6848152cca284ecc7cdb7f77910dd4e597ed50","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class AgentManagementTest(base.BaseNetworkTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":23,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":24,"context_line":"        body \u003d self.agents_client.list_agents()"},{"line_number":25,"context_line":"        self.assertEmpty(body[\"agents\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f6cbee18","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":34},"updated":"2018-11-22 02:31:59.000000000","message":"I\u0027m wondering whether this should be negative test","commit_id":"3c7f8505f72bddb5e929e813793a7da165d1cce7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"983142e119d65c5fec858ae179eff8998d2609a0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class AgentManagementTest(base.BaseNetworkTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":23,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":24,"context_line":"        body \u003d self.agents_client.list_agents()"},{"line_number":25,"context_line":"        self.assertEmpty(body[\"agents\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bd2a1594","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":34},"in_reply_to":"3f79a3b5_f6cbee18","updated":"2018-11-24 16:39:30.000000000","message":"Done","commit_id":"3c7f8505f72bddb5e929e813793a7da165d1cce7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6633b60418d4c268c85822c707375df04c305f4b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class AgentManagementTest(base.BaseNetworkTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":23,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":24,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":25,"context_line":"        \"\"\"Validate that non-admin user cannot list agents.\"\"\""},{"line_number":26,"context_line":"        # Listing agents requires admin_only permissions."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3435badc","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":39},"updated":"2018-11-26 01:18:45.000000000","message":"And should the filename end with \"_negative\"?","commit_id":"bdaba8a6d8f809ade677ac97ec585bfab08f0f61"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8310a37084007395e2c3e71d3efe9e5f42a2141c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class AgentManagementTest(base.BaseNetworkTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @decorators.idempotent_id(\u0027e335be47-b9a1-46fd-be30-0874c0b751e6\u0027)"},{"line_number":23,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":24,"context_line":"    def test_list_agents_non_admin(self):"},{"line_number":25,"context_line":"        \"\"\"Validate that non-admin user cannot list agents.\"\"\""},{"line_number":26,"context_line":"        # Listing agents requires admin_only permissions."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4cec2e26","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":39},"in_reply_to":"3f79a3b5_3435badc","updated":"2018-11-28 17:14:42.000000000","message":"Done","commit_id":"bdaba8a6d8f809ade677ac97ec585bfab08f0f61"}]}