)]}'
{".zuul.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"90f4dc3105fc85e8ca70f95ff8c580569b88fccf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"- job:"},{"line_number":71,"context_line":"    name: tempest-full"},{"line_number":72,"context_line":"    parent: devstack-tempest"},{"line_number":73,"context_line":"    nodeset: openstack-single-node"},{"line_number":74,"context_line":"    # This job runs on Xenial and this is for stable/pike \u0026 stable/queens"},{"line_number":75,"context_line":"    # \u0026 stable/rocky."},{"line_number":76,"context_line":"    # Before stable/pike, legacy version of tempest-full"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7028a2ec","line":73,"updated":"2018-11-15 14:21:44.000000000","message":"I\u0027d actually like to have us create a variant with xenial in its name, I can add that in the devstack patch.","commit_id":"ed456a348512a716cf21e7bd09b657eeb05b4cf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f4361a9d8db1f5ca60524ee7f33b0c530552ceb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"- job:"},{"line_number":71,"context_line":"    name: tempest-full"},{"line_number":72,"context_line":"    parent: devstack-tempest"},{"line_number":73,"context_line":"    nodeset: openstack-single-node"},{"line_number":74,"context_line":"    # This job runs on Xenial and this is for stable/pike \u0026 stable/queens"},{"line_number":75,"context_line":"    # \u0026 stable/rocky."},{"line_number":76,"context_line":"    # Before stable/pike, legacy version of tempest-full"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_f0cfd223","line":73,"in_reply_to":"3f79a3b5_7028a2ec","updated":"2018-11-15 14:28:16.000000000","message":"+1. that will be helpful to understand by name.","commit_id":"ed456a348512a716cf21e7bd09b657eeb05b4cf7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"90f4dc3105fc85e8ca70f95ff8c580569b88fccf","unresolved":false,"context_lines":[{"line_number":220,"context_line":"- job:"},{"line_number":221,"context_line":"    name: tempest-full-rocky"},{"line_number":222,"context_line":"    parent: tempest-full"},{"line_number":223,"context_line":"    override-checkout: stable/rocky"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"- job:"},{"line_number":226,"context_line":"    name: tempest-full-rocky-py3"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7003c276","line":223,"updated":"2018-11-15 14:21:44.000000000","message":"I think you need to explicitly override the nodeset back to the xenial ones here, too, because the \"override-checkout\" doesn\u0027t seem to trigger the correct branch selection in the parent job. Same for the other variants below.","commit_id":"ed456a348512a716cf21e7bd09b657eeb05b4cf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f4361a9d8db1f5ca60524ee7f33b0c530552ceb","unresolved":false,"context_lines":[{"line_number":220,"context_line":"- job:"},{"line_number":221,"context_line":"    name: tempest-full-rocky"},{"line_number":222,"context_line":"    parent: tempest-full"},{"line_number":223,"context_line":"    override-checkout: stable/rocky"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"- job:"},{"line_number":226,"context_line":"    name: tempest-full-rocky-py3"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_30e78aae","line":223,"in_reply_to":"3f79a3b5_7003c276","updated":"2018-11-15 14:28:16.000000000","message":"yeah, these jobs need to override the nodeset. once i find this is all working then i will make those in final version.","commit_id":"ed456a348512a716cf21e7bd09b657eeb05b4cf7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"99f8188de9efc86f58e31fcd644992c7cadb8f4b","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        ENABLE_FILE_INJECTION: true"},{"line_number":436,"context_line":"        DATABASE_TYPE: postgresql"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"- project:"},{"line_number":439,"context_line":"    templates:"},{"line_number":440,"context_line":"      - check-requirements"},{"line_number":441,"context_line":"      - integrated-gate"},{"line_number":442,"context_line":"      - integrated-gate-py35"},{"line_number":443,"context_line":"      - openstack-cover-jobs"},{"line_number":444,"context_line":"      - openstack-python-jobs"},{"line_number":445,"context_line":"      - openstack-python35-jobs"},{"line_number":446,"context_line":"      - openstack-python36-jobs"},{"line_number":447,"context_line":"      - publish-openstack-docs-pti"},{"line_number":448,"context_line":"      - release-notes-jobs-python3"},{"line_number":449,"context_line":"    check:"},{"line_number":450,"context_line":"      jobs:"},{"line_number":451,"context_line":"        - devstack-tempest:"},{"line_number":452,"context_line":"            files:"},{"line_number":453,"context_line":"              - ^playbooks/"},{"line_number":454,"context_line":"              - ^roles/"},{"line_number":455,"context_line":"              - ^.zuul.yaml$"},{"line_number":456,"context_line":"        - devstack-tempest-ipv6:"},{"line_number":457,"context_line":"            voting: false"},{"line_number":458,"context_line":"            files:"},{"line_number":459,"context_line":"              - ^playbooks/"},{"line_number":460,"context_line":"              - ^roles/"},{"line_number":461,"context_line":"              - ^.zuul.yaml$"},{"line_number":462,"context_line":"        - nova-multiattach:"},{"line_number":463,"context_line":"            # Define list of irrelevant files to use everywhere else"},{"line_number":464,"context_line":"            irrelevant-files: \u0026tempest-irrelevant-files"},{"line_number":465,"context_line":"              - ^(test-|)requirements.txt$"},{"line_number":466,"context_line":"              - ^.*\\.rst$"},{"line_number":467,"context_line":"              - ^doc/.*$"},{"line_number":468,"context_line":"              - ^etc/.*$"},{"line_number":469,"context_line":"              - ^releasenotes/.*$"},{"line_number":470,"context_line":"              - ^setup.cfg$"},{"line_number":471,"context_line":"              - ^tempest/hacking/.*$"},{"line_number":472,"context_line":"              - ^tempest/tests/.*$"},{"line_number":473,"context_line":"              - ^tools/.*$"},{"line_number":474,"context_line":"        - tempest-full-parallel:"},{"line_number":475,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":476,"context_line":"        - tempest-full-py3:"},{"line_number":477,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":478,"context_line":"        - tempest-full-py36:"},{"line_number":479,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":480,"context_line":"        - tempest-full-py3-ipv6:"},{"line_number":481,"context_line":"            voting: false"},{"line_number":482,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":483,"context_line":"        - tempest-full-rocky:"},{"line_number":484,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":485,"context_line":"        - tempest-full-rocky-py3:"},{"line_number":486,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":487,"context_line":"        - tempest-full-queens:"},{"line_number":488,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":489,"context_line":"        - tempest-full-queens-py3:"},{"line_number":490,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":491,"context_line":"        - tempest-full-pike:"},{"line_number":492,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":493,"context_line":"        - tempest-multinode-full:"},{"line_number":494,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":495,"context_line":"        - tempest-tox-plugin-sanity-check"},{"line_number":496,"context_line":"        - tempest-slow:"},{"line_number":497,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":498,"context_line":"        - nova-cells-v1:"},{"line_number":499,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":500,"context_line":"        - nova-live-migration:"},{"line_number":501,"context_line":"            voting: false"},{"line_number":502,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":503,"context_line":"        - neutron-grenade-multinode:"},{"line_number":504,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":505,"context_line":"        - neutron-grenade:"},{"line_number":506,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":507,"context_line":"        - devstack-plugin-ceph-tempest:"},{"line_number":508,"context_line":"            voting: false"},{"line_number":509,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":510,"context_line":"        - puppet-openstack-integration-4-scenario001-tempest-centos-7:"},{"line_number":511,"context_line":"            voting: false"},{"line_number":512,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":513,"context_line":"        - puppet-openstack-integration-4-scenario002-tempest-centos-7:"},{"line_number":514,"context_line":"            voting: false"},{"line_number":515,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":516,"context_line":"        - puppet-openstack-integration-4-scenario003-tempest-centos-7:"},{"line_number":517,"context_line":"            voting: false"},{"line_number":518,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":519,"context_line":"        - puppet-openstack-integration-4-scenario004-tempest-centos-7:"},{"line_number":520,"context_line":"            voting: false"},{"line_number":521,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":522,"context_line":"        - neutron-tempest-dvr:"},{"line_number":523,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":524,"context_line":"        - legacy-tempest-dsvm-neutron-full-ocata:"},{"line_number":525,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":526,"context_line":"        - tempest-full:"},{"line_number":527,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":528,"context_line":"        - interop-tempest-consistency:"},{"line_number":529,"context_line":"            voting: false"},{"line_number":530,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":531,"context_line":"        - tempest-full-test-account-py3:"},{"line_number":532,"context_line":"            voting: false"},{"line_number":533,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":534,"context_line":"        - tempest-full-test-account-no-admin-py3:"},{"line_number":535,"context_line":"            voting: false"},{"line_number":536,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":537,"context_line":"    gate:"},{"line_number":538,"context_line":"      jobs:"},{"line_number":539,"context_line":"        - nova-multiattach:"},{"line_number":540,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":541,"context_line":"        - tempest-slow:"},{"line_number":542,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":543,"context_line":"        - neutron-grenade-multinode:"},{"line_number":544,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":545,"context_line":"        - tempest-full:"},{"line_number":546,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":547,"context_line":"        - neutron-grenade:"},{"line_number":548,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":549,"context_line":"    experimental:"},{"line_number":550,"context_line":"      jobs:"},{"line_number":551,"context_line":"        - tempest-cinder-v2-api:"},{"line_number":552,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":553,"context_line":"        - tempest-all:"},{"line_number":554,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":555,"context_line":"        - legacy-tempest-dsvm-neutron-dvr-multinode-full:"},{"line_number":556,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":557,"context_line":"        - neutron-tempest-dvr-ha-multinode-full:"},{"line_number":558,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":559,"context_line":"        - legacy-tempest-dsvm-nova-v20-api:"},{"line_number":560,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":561,"context_line":"        - legacy-tempest-dsvm-lvm-multibackend:"},{"line_number":562,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":563,"context_line":"        - devstack-plugin-ceph-tempest-py3:"},{"line_number":564,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":565,"context_line":"        - tempest-pg-full:"},{"line_number":566,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":567,"context_line":"        - tempest-full-py3-opensuse150:"},{"line_number":568,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":569,"context_line":"    periodic-stable:"},{"line_number":570,"context_line":"      jobs:"},{"line_number":571,"context_line":"        - tempest-full-rocky"},{"line_number":572,"context_line":"        - tempest-full-rocky-py3"},{"line_number":573,"context_line":"        - tempest-full-queens"},{"line_number":574,"context_line":"        - tempest-full-queens-py3"},{"line_number":575,"context_line":"        - tempest-full-pike"},{"line_number":576,"context_line":"        - legacy-periodic-tempest-dsvm-neutron-full-ocata"},{"line_number":577,"context_line":"    periodic:"},{"line_number":578,"context_line":"      jobs:"},{"line_number":579,"context_line":"        - tempest-all"},{"line_number":580,"context_line":"        - tempest-full-oslo-master"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_88a5ce4b","line":580,"range":{"start_line":438,"start_character":2,"end_line":580,"end_character":0},"updated":"2018-11-21 06:39:13.000000000","message":"Job tempest-full-py36 not defined","commit_id":"df3e8a8a3d572502fdb9981ab70205f8ac8f0d8e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f28547b8a950a072abf6f8be6ef3343b634b998","unresolved":false,"context_lines":[{"line_number":235,"context_line":"          - controller"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"- job:"},{"line_number":238,"context_line":"    name: tempest-full-py36"},{"line_number":239,"context_line":"    parent: tempest-full-py3"},{"line_number":240,"context_line":"    nodeset: openstack-bionic-node"},{"line_number":241,"context_line":"    branches:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_ba1d5e13","side":"PARENT","line":238,"range":{"start_line":238,"start_character":1,"end_line":238,"end_character":27},"updated":"2018-11-21 22:06:46.000000000","message":"we are good to remove this as this job only run on Tempest master, does not run on any stable branch.","commit_id":"8cdc064f696ab793e2eaf9c56fcf201848e7c245"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8d10e7f801bf62cea8087eef48df1acdf7dbc79b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"          - controller"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"- job:"},{"line_number":238,"context_line":"    name: tempest-full-py36"},{"line_number":239,"context_line":"    parent: tempest-full-py3"},{"line_number":240,"context_line":"    nodeset: openstack-bionic-node"},{"line_number":241,"context_line":"    branches:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_69578d5e","side":"PARENT","line":238,"range":{"start_line":238,"start_character":1,"end_line":238,"end_character":27},"in_reply_to":"3f79a3b5_ba1d5e13","updated":"2018-12-12 02:42:07.000000000","message":"Thanks for clarifying why this is getting dropped in commit message.","commit_id":"8cdc064f696ab793e2eaf9c56fcf201848e7c245"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f28547b8a950a072abf6f8be6ef3343b634b998","unresolved":false,"context_lines":[{"line_number":145,"context_line":"      tox_envlist: full-parallel"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"- job:"},{"line_number":148,"context_line":"    name: tempest-full-py3"},{"line_number":149,"context_line":"    parent: devstack-tempest"},{"line_number":150,"context_line":"    # This currently works from stable/pike on."},{"line_number":151,"context_line":"    # Before stable/pike, legacy version of tempest-full"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_fab516f1","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":26},"updated":"2018-11-21 22:06:46.000000000","message":"this seems running on bionic on Rocky [1]\n\nnot sure why it is picking bionic  - http://logs.openstack.org/76/618176/1/check/tempest-full-py3/96b7329/zuul-info/inventory.yaml\n\n - http://logs.openstack.org/76/618176/1/check/tempest-full-py3/96b7329/job-output.txt.gz#_2018-11-15_14_11_43_321321","commit_id":"f9a4c77b8f5b38c99b698ac79d123349c09c267f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f7053fa96285880a831c1442ff5fe5e1dd4d33ca","unresolved":false,"context_lines":[{"line_number":145,"context_line":"      tox_envlist: full-parallel"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"- job:"},{"line_number":148,"context_line":"    name: tempest-full-py3"},{"line_number":149,"context_line":"    parent: devstack-tempest"},{"line_number":150,"context_line":"    # This currently works from stable/pike on."},{"line_number":151,"context_line":"    # Before stable/pike, legacy version of tempest-full"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_5047491c","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":26},"in_reply_to":"3f79a3b5_fab516f1","updated":"2018-11-21 22:58:56.000000000","message":"I picked up the wrong run seems. it is working fine on latest run. no issue here. Thanks clark for pointing that,","commit_id":"f9a4c77b8f5b38c99b698ac79d123349c09c267f"}],"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"39b0f4082ccab12217dc3465364719498dfafcdf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_38bad36f","line":23,"updated":"2018-11-20 16:51:31.000000000","message":"I think there may be a subtle misconception here, and clearing it up may make things simpler.\n\nA \"job\" in Zuul is a bit of an abstract concept, in that the \"job\" that Zuul ends up running for a change is actually dynamically constructed from any number of \"job variants\".  Zuul will combine *all* of the matching job variants when it constructs the actual job which is run.  That impacts how I would suggest this change be written, as well as the question of what happens to jobs which inherit from here.\n\nSince the only thing you want to change is the nodeset, I would suggest that rather than \"forking\" this job (as this change does by establishing mutually-exclusive branch matchers), you simply add a \"branch variant\" job definition after the main job definition.  So it would look like\n\n# This is variant A -- it should basically be the current job definition\n- job:\n  name: devstack-tempest\n  nodeset: bionic\n  \u003ca whole bunch of other stuff here which actually defines the job\u003e\n\n# This is variant B -- it changes one thing about the job based on the branch\n- job:\n  name: devstack-tempest\n  branches: stable/rocky\n  nodeset: xenial\n\nNote that variant A does not have a branch selector, and variant B doesn\u0027t have any job definition other than the nodeset attribute.\n\nIf Zuul runs the devstack-tempest job on master or stein, it is only going to use variant A.  If it runs the job on rocky, it\u0027s going to start with variant A and then merge variant B on top of that.  Since the only thing in variant B is the nodeset, the process just ends up being that on rocky changes, the nodeset is overridden to be xenial instead of bionic.\n\nIf a job inherits from devstack-tempest, the exact same mechanism will still apply.  For example, when the tempest-full job runs, it will apply devstack-tempest variant A, and then (if and only if it is running on the rocky branch) devstack-tempest variant B, and then any tempest-full job variants after that.  The same is true for a job in the nova repo that inherits from tempest full -- apply any devstack-tempest variants first, then tempest-full variants, then any variants for the job in the nova repo.\n\nSo if you make the nodeset change sufficiently early in the inheritance hierarchy, there\u0027s less to change -- this means that if you do it in the tempest repository, there should be nothing to change in the nova repository.  And further -- if you do it early in the inheritence hierarchy in the tempest repo, there should be even less to change in the tempest repo.  For that reason, I recommend doing it as early as possible.  For example, making the change in devstack-tempest should catch nearly all the jobs, except that since the multinode jobs override the nodeset, you\u0027ll need to do the same for those.\n\nI\u0027m not certain about this, but we should look into whether the *devstack* repo might be a good place for part or all of this change.","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"77456d3cba2614148f044af9a4c8f7d24cbfad7d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_2124deb0","line":23,"updated":"2018-11-20 18:35:48.000000000","message":"In fact, Jens has a patch for devstack here: https://review.openstack.org/610977 I think we should have this patch Depends-On that one and just take care of any remaining nodeset overrides in tempest.","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9c4dbcdabff261b15f10432122a77596e4d3a0d8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"use bionic and second for all stable branches before stein which will"},{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_d2205e4e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":69},"updated":"2018-11-20 15:04:45.000000000","message":"not sure this needs to be taken care? \n\nFor example, \n- if nova has job1 devired from tempest-full and not overridden the \u0027branches\u0027 then, job1 running on stein onwards will use tempest-full version of stein onwards(which is on bionic) and job1 running on \u003c stein (till stable/rocky) will use tempest-full version of \u003c stein (which is on xenial). So all ok here.\n\n- if job1 has overriden the \u0027branches\u0027 then parent job will be selected as per the job1 branches match?","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa6ef24e2e224563a70fd1ba9ad32f70c7d0f692","unresolved":false,"context_lines":[{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_282efa8c","line":23,"in_reply_to":"3f79a3b5_2124deb0","updated":"2018-11-21 07:17:03.000000000","message":"yeah this patch is Depends-On the devstack changes for nodeset.","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa6ef24e2e224563a70fd1ba9ad32f70c7d0f692","unresolved":false,"context_lines":[{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_43da3776","line":23,"in_reply_to":"3f79a3b5_38bad36f","updated":"2018-11-21 07:17:03.000000000","message":"Thanks for nice explanation. \n\nwith that we do not need to worry about derived job on project side. specially in case of nodeset handling here.","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e23372ffb95324d77e00179c9cb84b1c533245d1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_e35823fd","line":23,"in_reply_to":"3f79a3b5_38bad36f","updated":"2018-11-21 07:22:31.000000000","message":"i will say we do in tempest repo only as tempest base jobs override the branches so we can handle the nodeset setting also other wise by doing it in devstack also needs to remove the branches overridden from tempest base jobs.","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"407ea879ca4e0c12206ab4de7927bc9821adf4ad","unresolved":false,"context_lines":[{"line_number":19,"context_line":"use bionic and second for all stable branches before stein which will"},{"line_number":20,"context_line":"use the xenial."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Any specific job on other repo using any of the Tempest base jobs needs"},{"line_number":23,"context_line":"to take care the same if they are overriding the \u0027branches\u0027 variable."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: https://review.openstack.org/#/c/610977/"},{"line_number":26,"context_line":"Change-Id: I5a24c697103090f6712d6e9168abe6c86f7c380c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_78accbea","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":69},"in_reply_to":"3f79a3b5_d2205e4e","updated":"2018-11-20 16:22:40.000000000","message":"I believe this is correct. In an implicit branch scenario it will end up parenting to the job that matches the branch explicitly. In the explicit case it should do that even more explicitly.\n\nBasically zuul should ensure that both explicit and implicit branches for a job determine the inheritance path.","commit_id":"45b669d1d07a77e6573aa932e391ff8e492caaaf"}]}