)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"2a5f293e828dda51b62aabbda29f2ce3a19a20ef","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                          region_name\u003dregion,"},{"line_number":127,"context_line":"                                          http_log_debug\u003dTrue)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_object_client(self, username, password, tenant_name):"},{"line_number":130,"context_line":"        auth_url \u003d self.config.identity.uri"},{"line_number":131,"context_line":"        # add current tenant to Member group."},{"line_number":132,"context_line":"        keystone_admin \u003d self._get_identity_client("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9RTg%3D","line":129,"updated":"2013-12-13 09:19:37.000000000","message":"I think this the name is misleading; I was assuming this is only for object actions, but it returns a swiftclient connection.\nMaybe name it _get_swift_connection?","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"494e36549135de77e1e417812a5019eb5362795e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                          region_name\u003dregion,"},{"line_number":127,"context_line":"                                          http_log_debug\u003dTrue)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_object_client(self, username, password, tenant_name):"},{"line_number":130,"context_line":"        auth_url \u003d self.config.identity.uri"},{"line_number":131,"context_line":"        # add current tenant to Member group."},{"line_number":132,"context_line":"        keystone_admin \u003d self._get_identity_client("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Csg%3D","line":129,"in_reply_to":"AAAATn%2F9RTg%3D","updated":"2013-12-17 11:55:24.000000000","message":"I\u0027ll change it to get_object_storage_client ok?","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"1ab60bd7a9b2531621dad07621ab3f3545fd152b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # enable test user to operate swift by adding Member role to him."},{"line_number":138,"context_line":"        member_role \u003d [ member for member in"},{"line_number":139,"context_line":"                keystone_admin.roles.list() if member.name \u003d\u003d \u0027Member\u0027][0]"},{"line_number":140,"context_line":"        keystone_admin.roles.add_user_role(self.identity_client.user_id,"},{"line_number":141,"context_line":"                                            member_role.id,"},{"line_number":142,"context_line":"                                            self.identity_client.tenant_id)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9RQ4%3D","line":140,"updated":"2013-12-13 09:21:50.000000000","message":"This user won\u0027t be deleted after the test?","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"494e36549135de77e1e417812a5019eb5362795e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # enable test user to operate swift by adding Member role to him."},{"line_number":138,"context_line":"        member_role \u003d [ member for member in"},{"line_number":139,"context_line":"                keystone_admin.roles.list() if member.name \u003d\u003d \u0027Member\u0027][0]"},{"line_number":140,"context_line":"        keystone_admin.roles.add_user_role(self.identity_client.user_id,"},{"line_number":141,"context_line":"                                            member_role.id,"},{"line_number":142,"context_line":"                                            self.identity_client.tenant_id)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9CsQ%3D","line":140,"in_reply_to":"AAAATn%2F9RQ4%3D","updated":"2013-12-17 11:55:24.000000000","message":"sorry, I\u0027m not sure which user you meant... if you\u0027re talking about keystone_admin, it doesn\u0027t need to be deleted here, I didn\u0027t created it, I just accessed it to give swift member powers to my current user.","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"}],"tempest/scenario/test_swift_basic_ops.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"2a5f293e828dda51b62aabbda29f2ce3a19a20ef","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _get_swift_stat(self):"},{"line_number":49,"context_line":"        \"\"\"get swift status for our user account.\"\"\""},{"line_number":50,"context_line":"        self.object_client.get_account()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _create_container(self, container_name\u003dNone):"},{"line_number":53,"context_line":"        name \u003d container_name or rand_name(\u0027swift-scenario-container\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9RSg%3D","line":50,"updated":"2013-12-13 09:19:37.000000000","message":"I think you don\u0027t need this method, just call         self.object_client.get_account() in test_swift_basic_ops directly","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"494e36549135de77e1e417812a5019eb5362795e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _get_swift_stat(self):"},{"line_number":49,"context_line":"        \"\"\"get swift status for our user account.\"\"\""},{"line_number":50,"context_line":"        self.object_client.get_account()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _create_container(self, container_name\u003dNone):"},{"line_number":53,"context_line":"        name \u003d container_name or rand_name(\u0027swift-scenario-container\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Ito%3D","line":50,"in_reply_to":"AAAATn%2F9RSg%3D","updated":"2013-12-17 11:55:24.000000000","message":"so it will be useful to organize the things if a new tests is added and I\u0027m adding a log too.","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"2a5f293e828dda51b62aabbda29f2ce3a19a20ef","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return name"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _delete_container(self, container_name):"},{"line_number":59,"context_line":"        self.object_client.delete_container(container_name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _upload_object_to_container(self, container_name, filename\u003dNone):"},{"line_number":62,"context_line":"        obj_path \u003d self._create_temp_file(filename)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9RSY%3D","line":59,"updated":"2013-12-13 09:19:37.000000000","message":"Same as above, why add a method if you can use the direct call?","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"2a5f293e828dda51b62aabbda29f2ce3a19a20ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _upload_object_to_container(self, container_name, filename\u003dNone):"},{"line_number":62,"context_line":"        obj_path \u003d self._create_temp_file(filename)"},{"line_number":63,"context_line":"        self.object_client.put_object(container_name, obj_path, \u0027text/plain\u0027)"},{"line_number":64,"context_line":"        # delete created file"},{"line_number":65,"context_line":"        os.remove(obj_path)"},{"line_number":66,"context_line":"        return obj_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9RSw%3D","line":63,"updated":"2013-12-13 09:19:37.000000000","message":"I would prefer that you don\u0027t create a temporary file here.\n\nLook at the code here: https://github.com/openstack/tempest/blob/master/tempest/api/object_storage/test_object_services.py\nYou can directly add the content there. Additionally, the \u0027text/plain\u0027 is wrong here - this is the content field. You need to use \"content_type \u003d \u0027text/plain\u0027","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"494e36549135de77e1e417812a5019eb5362795e","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _upload_object_to_container(self, container_name, filename\u003dNone):"},{"line_number":62,"context_line":"        obj_path \u003d self._create_temp_file(filename)"},{"line_number":63,"context_line":"        self.object_client.put_object(container_name, obj_path, \u0027text/plain\u0027)"},{"line_number":64,"context_line":"        # delete created file"},{"line_number":65,"context_line":"        os.remove(obj_path)"},{"line_number":66,"context_line":"        return obj_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Iss%3D","line":63,"in_reply_to":"AAAATn%2F9RSw%3D","updated":"2013-12-17 11:55:24.000000000","message":"thanks for this, much better \u003d)","commit_id":"ebc51f58cade4ae3e65333b77f986a4ae05ef387"}]}