)]}'
{"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df1e5fa5db86ddbe7b458b83f44baa31119b7bd0","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            self.ssh_to_server()"},{"line_number":169,"context_line":"        except SSHTimeout as ex:"},{"line_number":170,"context_line":"            self.nova_volume_detach()"},{"line_number":171,"context_line":"            raise ex"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9PfI%3D","line":169,"updated":"2013-12-13 15:55:13.000000000","message":"Instead of doing this why not add an addCleanup after we attach the volume. Even if an exception is raised that should detach it.\n\nYou\u0027ll still have the same issue if an exception or error is raised in any of the other steps between self.nova_volume_attach() and here right?","commit_id":"2b1009e816853875906a812d94d94859e3dc5914"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d52e36a63438b47f09900664f0ec4e6275416176","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            self.ssh_to_server()"},{"line_number":169,"context_line":"        except SSHTimeout as ex:"},{"line_number":170,"context_line":"            self.nova_volume_detach()"},{"line_number":171,"context_line":"            raise ex"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F82Gg%3D","line":169,"in_reply_to":"AAAATn%2F9N7A%3D","updated":"2013-12-19 16:22:48.000000000","message":"John the issue here I think is that with testtools addCleanup is called before tearDown and not after\n\nSo adding _detach in addCleanup, as Matthew suggested, should do the trick and allow for a relatively simple tearDown where we just \"delete\" instances and volumes.","commit_id":"2b1009e816853875906a812d94d94859e3dc5914"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad00042de5c1f818f6fce2b3aafcf114cc6ddec1","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            self.ssh_to_server()"},{"line_number":169,"context_line":"        except SSHTimeout as ex:"},{"line_number":170,"context_line":"            self.nova_volume_detach()"},{"line_number":171,"context_line":"            raise ex"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9N7A%3D","line":169,"in_reply_to":"AAAATn%2F9PfI%3D","updated":"2013-12-13 21:53:39.000000000","message":"Oh cool.. thanks for pointing that out.  I wasn\u0027t actually familiar with addCleanup.\n\nI\u0027m a bit confused though, the way I read it was that the addCleanup is executed if the teardown fails right?\n\nPart of what I\u0027d like to fix here is trying to issue an invalid operation in the cleanup, and keep this from getting logged as a \"gate issue against Cinder\" again.  :)\n\nI thought about try/except/else/finally etc but didn\u0027t come up with something better than just ugly hacking on it.  I\u0027m open though if you have ideas or I\u0027m wrong about addCleanup.","commit_id":"2b1009e816853875906a812d94d94859e3dc5914"}]}