)]}'
{"tempest/api/volume/test_volume_metadata.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.volume.base import BaseVolumeAdminTest"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x2s%3D","line":18,"updated":"2013-12-20 12:30:22.000000000","message":"not sure why do we need Admin credentials for this?","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.volume.base import BaseVolumeAdminTest"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nys%3D","line":18,"in_reply_to":"AAAATn%2F8x2s%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def tearDown(self):"},{"line_number":46,"context_line":"        # Update the metadata to {}"},{"line_number":47,"context_line":"        self.volumes_client.update_all_volume_metadata(self.volume_id, {})"},{"line_number":48,"context_line":"        super(VolumeMetadataActionsTest, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x2A%3D","line":47,"updated":"2013-12-20 12:30:22.000000000","message":"just for my own curiosity, is there a reason to prefer update here to delete?","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def tearDown(self):"},{"line_number":46,"context_line":"        # Update the metadata to {}"},{"line_number":47,"context_line":"        self.volumes_client.update_all_volume_metadata(self.volume_id, {})"},{"line_number":48,"context_line":"        super(VolumeMetadataActionsTest, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nxQ%3D","line":47,"in_reply_to":"AAAATn%2F8x2A%3D","updated":"2013-12-24 08:27:52.000000000","message":"Thanks.\nupdate the metadata to {} for non interacting for each test.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(VolumeMetadataActionsTest, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":51,"context_line":"    def test_create_delete_volume_metadata(self):"},{"line_number":52,"context_line":"        # Create metadata for the volume"},{"line_number":53,"context_line":"        metadata \u003d {\"key1\": \"value1\","},{"line_number":54,"context_line":"                    \"key2\": \"value2\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x14%3D","line":51,"updated":"2013-12-20 12:30:22.000000000","message":"create_get_delete as per the test steps","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super(VolumeMetadataActionsTest, self).tearDown()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":51,"context_line":"    def test_create_delete_volume_metadata(self):"},{"line_number":52,"context_line":"        # Create metadata for the volume"},{"line_number":53,"context_line":"        metadata \u003d {\"key1\": \"value1\","},{"line_number":54,"context_line":"                    \"key2\": \"value2\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nxA%3D","line":51,"in_reply_to":"AAAATn%2F8x14%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        resp, body \u003d self.volumes_client.get_volume_metadata(self.volume_id)"},{"line_number":69,"context_line":"        self.assertNotIn(\"key1\", body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_create_volume_metadata_case_sensitive_or_not(self):"},{"line_number":72,"context_line":"        # Create metadata for the volume"},{"line_number":73,"context_line":"        metadata \u003d {\"key1\": \"value1\","},{"line_number":74,"context_line":"                    \"KEY1\": \"value1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x1w%3D","line":71,"updated":"2013-12-20 12:30:22.000000000","message":"I think it\u0027s okay to either delete this or add an assertion in previous test","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"f0bb2cdf7ad49fd74706c4846c3263f0f9a0ea31","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        resp, body \u003d self.volumes_client.get_volume_metadata(self.volume_id)"},{"line_number":69,"context_line":"        self.assertNotIn(\"key1\", body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_create_volume_metadata_case_sensitive_or_not(self):"},{"line_number":72,"context_line":"        # Create metadata for the volume"},{"line_number":73,"context_line":"        metadata \u003d {\"key1\": \"value1\","},{"line_number":74,"context_line":"                    \"KEY1\": \"value1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nos%3D","line":71,"in_reply_to":"AAAATn%2F8nq0%3D","updated":"2013-12-24 08:40:50.000000000","message":"I\u0027m sorry.\nThe test is to test case sensitive or not, may be i leave this?","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        resp, body \u003d self.volumes_client.get_volume_metadata(self.volume_id)"},{"line_number":69,"context_line":"        self.assertNotIn(\"key1\", body)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_create_volume_metadata_case_sensitive_or_not(self):"},{"line_number":72,"context_line":"        # Create metadata for the volume"},{"line_number":73,"context_line":"        metadata \u003d {\"key1\": \"value1\","},{"line_number":74,"context_line":"                    \"KEY1\": \"value1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nq0%3D","line":71,"in_reply_to":"AAAATn%2F8x1w%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.volume.base import BaseVolumeTest"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9nk%3D","line":18,"updated":"2013-12-26 08:26:28.000000000","message":"better to import modules instead of class.\nfrom tempest.api.volume import base","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.volume.base import BaseVolumeTest"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.test import attr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class VolumeMetadataActionsTest(BaseVolumeTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9ng%3D","line":20,"updated":"2013-12-26 08:26:28.000000000","message":"ditto","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def tearDownClass(cls):"},{"line_number":35,"context_line":"        super(VolumeMetadataActionsTest, cls).tearDownClass()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def tearDown(self):"},{"line_number":38,"context_line":"        # Update the metadata to {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9nU%3D","line":35,"updated":"2013-12-26 08:26:28.000000000","message":"tearDownClass is not required if it only invokes super tearDownClass.","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def tearDown(self):"},{"line_number":38,"context_line":"        # Update the metadata to {}"},{"line_number":39,"context_line":"        self.volumes_client.update_all_volume_metadata(self.volume_id, {})"},{"line_number":40,"context_line":"        super(VolumeMetadataActionsTest, self).tearDown()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":43,"context_line":"    def test_create_get_delete_volume_metadata(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9mo%3D","line":40,"updated":"2013-12-26 08:26:28.000000000","message":"IMO, super tearDown could be removed as it does nothing, right?","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    \"key3\": \"value3\"}"},{"line_number":68,"context_line":"        create_expect \u003d {\"key1\": \"value1\","},{"line_number":69,"context_line":"                         \"key2\": \"value2\","},{"line_number":70,"context_line":"                         \"key3\": \"value3\"}"},{"line_number":71,"context_line":"        update_item \u003d {\"key3\": \"value3_update\"}"},{"line_number":72,"context_line":"        expect \u003d {\"key1\": \"value1\","},{"line_number":73,"context_line":"                  \"key2\": \"value2\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9l4%3D","line":70,"updated":"2013-12-26 08:26:28.000000000","message":"metadata and create_expect are same. Could they use one variable?","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        expect \u003d {\"key1\": \"value1\","},{"line_number":73,"context_line":"                  \"key2\": \"value2\","},{"line_number":74,"context_line":"                  \"key3\": \"value3_update\"}"},{"line_number":75,"context_line":"        # Create volume for the volume"},{"line_number":76,"context_line":"        resp, body \u003d self.volumes_client.create_volume_metadata("},{"line_number":77,"context_line":"            self.volume_id,"},{"line_number":78,"context_line":"            metadata)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9lU%3D","line":75,"updated":"2013-12-26 08:26:28.000000000","message":"typo: Create metadata...","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"e2abf3cdaa3e92f66a99ab2827745957ab64a3ef","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self.volume_id,"},{"line_number":78,"context_line":"            metadata)"},{"line_number":79,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":80,"context_line":"        self.assertEqual(create_expect, body)"},{"line_number":81,"context_line":"        # Update item metadata"},{"line_number":82,"context_line":"        resp, body \u003d self.volumes_client.update_item_volume_metadata("},{"line_number":83,"context_line":"            self.volume_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F9lY%3D","line":80,"updated":"2013-12-26 08:26:28.000000000","message":"Is this check point same with line 54,55? If so, you could get rid of it.","commit_id":"14eb08d60f2f4ca8dbd99f720de1b82f73e99c9f"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"c1e4c731aadc67fceec7a63438fac05a7a875362","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(200, rsp.status)"},{"line_number":60,"context_line":"        resp, body \u003d self.volumes_client.get_volume_metadata(self.volume_id)"},{"line_number":61,"context_line":"        self.assertNotIn(\"key1\", body)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_update_volume_metadata_item(self):"},{"line_number":64,"context_line":"        # Update metadata item for the volume"},{"line_number":65,"context_line":"        metadata \u003d {\"key1\": \"value1\","}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAT3%2F%2F7DM%3D","line":62,"updated":"2013-12-27 03:07:51.000000000","message":"Please mention the type of the test.","commit_id":"72a16cf9cbd9ae5f95456facbf1a987713a3d862"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"c1e4c731aadc67fceec7a63438fac05a7a875362","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        expect \u003d {\"key1\": \"value1\","},{"line_number":73,"context_line":"                  \"key2\": \"value2\","},{"line_number":74,"context_line":"                  \"key3\": \"value3_update\"}"},{"line_number":75,"context_line":"        # Create volume for the volume"},{"line_number":76,"context_line":"        resp, body \u003d self.volumes_client.create_volume_metadata("},{"line_number":77,"context_line":"            self.volume_id,"},{"line_number":78,"context_line":"            metadata)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAT3%2F%2F7DE%3D","line":75,"updated":"2013-12-27 03:07:51.000000000","message":"I think you need to improve the comment. \n\nyou are creating volume metadata here.","commit_id":"72a16cf9cbd9ae5f95456facbf1a987713a3d862"}],"tempest/api/volume/test_volume_metadata_negative.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.volume.base import BaseVolumeAdminTest"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest import exceptions"},{"line_number":21,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x1A%3D","line":18,"updated":"2013-12-20 12:30:22.000000000","message":"inherit from BaseVolumeTest if don\u0027t need admin","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.volume.base import BaseVolumeAdminTest"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest import exceptions"},{"line_number":21,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nug%3D","line":18,"in_reply_to":"AAAATn%2F8x1A%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                          delete_item_key)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":98,"context_line":"    def test_update_all_volume_metadata_with_nonexistent_volume(self):"},{"line_number":99,"context_line":"        # Update metadata for nonexistent volume should fail"},{"line_number":100,"context_line":"        metadata \u003d {\"key1\": \"value1\"}"},{"line_number":101,"context_line":"        nonexistent_volume_id \u003d data_utils.rand_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x0c%3D","line":98,"updated":"2013-12-20 12:30:22.000000000","message":"for consistency with previous comments, update_volume_metadata_with_nonexistent_volume","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                          delete_item_key)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":98,"context_line":"    def test_update_all_volume_metadata_with_nonexistent_volume(self):"},{"line_number":99,"context_line":"        # Update metadata for nonexistent volume should fail"},{"line_number":100,"context_line":"        metadata \u003d {\"key1\": \"value1\"}"},{"line_number":101,"context_line":"        nonexistent_volume_id \u003d data_utils.rand_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nrw%3D","line":98,"in_reply_to":"AAAATn%2F8x0c%3D","updated":"2013-12-24 08:27:52.000000000","message":"There are two api about update:\nupdate_all : replace the metadata\nupdate_item: just update one key in metadata\n\nSo i write two test, may be rename the test?","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                          metadata)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":110,"context_line":"    def test_update_item_volume_metadata_with_nonexistent_volume(self):"},{"line_number":111,"context_line":"        # Update metadata for nonexistent volume should fail"},{"line_number":112,"context_line":"        metadata \u003d {\"key1\": \"value1\"}"},{"line_number":113,"context_line":"        nonexistent_volume_id \u003d data_utils.rand_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x0I%3D","line":110,"updated":"2013-12-20 12:30:22.000000000","message":"I\u0027d actually replace this with something that tries to update an existing volume metadata using an empty key ... update with nonexistent volume is in previous test","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                          metadata)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":110,"context_line":"    def test_update_item_volume_metadata_with_nonexistent_volume(self):"},{"line_number":111,"context_line":"        # Update metadata for nonexistent volume should fail"},{"line_number":112,"context_line":"        metadata \u003d {\"key1\": \"value1\"}"},{"line_number":113,"context_line":"        nonexistent_volume_id \u003d data_utils.rand_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nrs%3D","line":110,"in_reply_to":"AAAATn%2F8x0I%3D","updated":"2013-12-24 08:27:52.000000000","message":"ditto.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"}],"tempest/services/volume/json/volumes_client.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        body \u003d json.loads(body)"},{"line_number":280,"context_line":"        return resp, body[\u0027metadata\u0027]"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def update_all_volume_metadata(self, volume_id, metadata):"},{"line_number":283,"context_line":"        \"\"\"Update all metadata for the volume.\"\"\""},{"line_number":284,"context_line":"        put_body \u003d json.dumps({\u0027metadata\u0027: metadata})"},{"line_number":285,"context_line":"        url \u003d \"volumes/%s/metadata\" % str(volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x4I%3D","line":282,"updated":"2013-12-20 12:30:22.000000000","message":"I\u0027d strip \"all\" from the name and description here","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        body \u003d json.loads(body)"},{"line_number":280,"context_line":"        return resp, body[\u0027metadata\u0027]"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def update_all_volume_metadata(self, volume_id, metadata):"},{"line_number":283,"context_line":"        \"\"\"Update all metadata for the volume.\"\"\""},{"line_number":284,"context_line":"        put_body \u003d json.dumps({\u0027metadata\u0027: metadata})"},{"line_number":285,"context_line":"        url \u003d \"volumes/%s/metadata\" % str(volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nrc%3D","line":282,"in_reply_to":"AAAATn%2F8x4I%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        body \u003d json.loads(body)"},{"line_number":288,"context_line":"        return resp, body[\u0027metadata\u0027]"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def update_item_volume_metadata(self, volume_id, id, meta_item):"},{"line_number":291,"context_line":"        \"\"\"Update metadata item for the volume.\"\"\""},{"line_number":292,"context_line":"        put_body \u003d json.dumps({\u0027meta\u0027: meta_item})"},{"line_number":293,"context_line":"        url \u003d \"volumes/%s/metadata/%s\" % (str(volume_id), str(id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x34%3D","line":290,"updated":"2013-12-20 12:30:22.000000000","message":"maybe \"update_volume_metadata_item\" would be more consistent then?","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        body \u003d json.loads(body)"},{"line_number":288,"context_line":"        return resp, body[\u0027metadata\u0027]"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def update_item_volume_metadata(self, volume_id, id, meta_item):"},{"line_number":291,"context_line":"        \"\"\"Update metadata item for the volume.\"\"\""},{"line_number":292,"context_line":"        put_body \u003d json.dumps({\u0027meta\u0027: meta_item})"},{"line_number":293,"context_line":"        url \u003d \"volumes/%s/metadata/%s\" % (str(volume_id), str(id))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nrg%3D","line":290,"in_reply_to":"AAAATn%2F8x34%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"}],"tempest/services/volume/xml/volumes_client.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param display_name: Optional Volume Name."},{"line_number":128,"context_line":"        :param metadata: An optional dictionary of values for metadata."},{"line_number":129,"context_line":"        :param volume_type: Optional Name of volume_type for the volume"},{"line_number":130,"context_line":"        :param volume_id: When specified the volume is created from"},{"line_number":131,"context_line":"                            this volume"},{"line_number":132,"context_line":"        :param imageRef: When specified the volume is created from this"},{"line_number":133,"context_line":"                         image"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x3Q%3D","line":130,"updated":"2013-12-20 12:30:22.000000000","message":"don\u0027t change this, snapshot_id is correct here as well as in the description","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param display_name: Optional Volume Name."},{"line_number":128,"context_line":"        :param metadata: An optional dictionary of values for metadata."},{"line_number":129,"context_line":"        :param volume_type: Optional Name of volume_type for the volume"},{"line_number":130,"context_line":"        :param volume_id: When specified the volume is created from"},{"line_number":131,"context_line":"                            this volume"},{"line_number":132,"context_line":"        :param imageRef: When specified the volume is created from this"},{"line_number":133,"context_line":"                         image"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nrM%3D","line":130,"in_reply_to":"AAAATn%2F8x3Q%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.\nI made a mistake, sorry.\nThanks very much.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        body \u003d self._parse_key_value(etree.fromstring(body))"},{"line_number":389,"context_line":"        return resp, body"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def update_all_volume_metadata(self, volume_id, metadata):"},{"line_number":392,"context_line":"        \"\"\"Update all metadata for the volume.\"\"\""},{"line_number":393,"context_line":"        put_body \u003d self._metadata_body(metadata)"},{"line_number":394,"context_line":"        url \u003d \"volumes/%s/metadata\" % str(volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x3M%3D","line":391,"updated":"2013-12-20 12:30:22.000000000","message":"same as per json client","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        body \u003d self._parse_key_value(etree.fromstring(body))"},{"line_number":389,"context_line":"        return resp, body"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def update_all_volume_metadata(self, volume_id, metadata):"},{"line_number":392,"context_line":"        \"\"\"Update all metadata for the volume.\"\"\""},{"line_number":393,"context_line":"        put_body \u003d self._metadata_body(metadata)"},{"line_number":394,"context_line":"        url \u003d \"volumes/%s/metadata\" % str(volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nrE%3D","line":391,"in_reply_to":"AAAATn%2F8x3M%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"648983fe4881f0488eeb9f6946d4a01f55389823","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        body \u003d self._parse_key_value(etree.fromstring(body))"},{"line_number":397,"context_line":"        return resp, body"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def update_item_volume_metadata(self, volume_id, id, meta_item):"},{"line_number":400,"context_line":"        \"\"\"Update metadata item for the volume.\"\"\""},{"line_number":401,"context_line":"        for k, v in meta_item.items():"},{"line_number":402,"context_line":"            put_body \u003d Element(\u0027meta\u0027, key\u003dk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8x3I%3D","line":399,"updated":"2013-12-20 12:30:22.000000000","message":"same as per json client","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8deed411d6346ee876a3b7b24e0ae972df0d1132","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        body \u003d self._parse_key_value(etree.fromstring(body))"},{"line_number":397,"context_line":"        return resp, body"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def update_item_volume_metadata(self, volume_id, id, meta_item):"},{"line_number":400,"context_line":"        \"\"\"Update metadata item for the volume.\"\"\""},{"line_number":401,"context_line":"        for k, v in meta_item.items():"},{"line_number":402,"context_line":"            put_body \u003d Element(\u0027meta\u0027, key\u003dk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8nq8%3D","line":399,"in_reply_to":"AAAATn%2F8x3I%3D","updated":"2013-12-24 08:27:52.000000000","message":"Done.","commit_id":"6781e543ac3af9a22f4f0a81b15acf05fb8f4613"}]}