)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1740a654d1a3cfefc532e79ce7d366b10501f6bb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The change addresses a case when networking-opencontrail"},{"line_number":14,"context_line":"needs more ports with the same device_id and network_id"},{"line_number":15,"context_line":"for any created router. This is needed for compatibility"},{"line_number":16,"context_line":"with TungstenFabric."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If1c711547542460ebb3f3f9371a09669edb6ce5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f011b560","line":16,"updated":"2018-12-19 00:44:40.000000000","message":"I felt a little concern from this message because this is only for opencontrail. Then I am asking a question to verify this change for common Neutron thing.","commit_id":"e973da9c8986c222d50c7598fbc985b7c1073314"}],"tempest/api/network/admin/test_routers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1740a654d1a3cfefc532e79ce7d366b10501f6bb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        list_body \u003d self.admin_ports_client.list_ports("},{"line_number":113,"context_line":"            network_id\u003dCONF.network.public_network_id,"},{"line_number":114,"context_line":"            device_id\u003drouter_id,"},{"line_number":115,"context_line":"            device_owner\u003d\"network:router_gateway\")"},{"line_number":116,"context_line":"        self.assertEqual(len(list_body[\u0027ports\u0027]), 1)"},{"line_number":117,"context_line":"        gw_port \u003d list_body[\u0027ports\u0027][0]"},{"line_number":118,"context_line":"        fixed_ips \u003d gw_port[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_501f496d","line":115,"updated":"2018-12-19 00:44:40.000000000","message":"https://developer.openstack.org/api-ref/network/v2/?expanded\u003dlist-ports-detail#list-ports doesn\u0027t contain \"network:router_gateway\" on device_owner description.\n\nThe API samples contain it, maybe this is valid.\nBut I wanted to make sure that.\nCould you point the code on Neutron if possible.","commit_id":"e973da9c8986c222d50c7598fbc985b7c1073314"},{"author":{"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},"change_message_id":"610d9a6a1991560879e11343aca160c7c67e3498","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        list_body \u003d self.admin_ports_client.list_ports("},{"line_number":113,"context_line":"            network_id\u003dCONF.network.public_network_id,"},{"line_number":114,"context_line":"            device_id\u003drouter_id,"},{"line_number":115,"context_line":"            device_owner\u003d\"network:router_gateway\")"},{"line_number":116,"context_line":"        self.assertEqual(len(list_body[\u0027ports\u0027]), 1)"},{"line_number":117,"context_line":"        gw_port \u003d list_body[\u0027ports\u0027][0]"},{"line_number":118,"context_line":"        fixed_ips \u003d gw_port[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_90363a50","line":115,"in_reply_to":"3f79a3b5_501f496d","updated":"2018-12-19 09:21:36.000000000","message":"It\u0027s defined here: https://github.com/openstack/neutron-lib/blob/152342413beb0cf940708069f21e74c2069699e1/neutron_lib/constants.py#L53\n\nYou can see, that neutron use this for create GW port (https://github.com/openstack/neutron/blob/70e0aa7d6ce9ac70423cf4536504e6db440dccc2/neutron/db/l3_db.py#L370-L380) and also when need to find GW, e.g. https://github.com/openstack/neutron/blob/094095b3d7c6afe8b6521473d12f9ee03f54fd59/neutron/db/db_base_plugin_common.py#L264-L267\n\nDo you think it\u0027s clear enough?","commit_id":"e973da9c8986c222d50c7598fbc985b7c1073314"}]}
