)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"22272c1f61591392adff8290513c45a282e89478","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add judgment when getting resource_name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If glance does not have any resource type association，we will get"},{"line_number":10,"context_line":"IndexError when getting resource_name from list_resource_types\u0027s"},{"line_number":11,"context_line":"response body because the response body does not have any resource_types."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f8307e07","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":53},"updated":"2018-12-10 01:46:14.000000000","message":"Thanks for your contribution.\nThe main question is: is it a bug if glance doesn\u0027t have any resource type association?\n\nUsually it will look like:\n[tecs@host-192-168-32-3 ~(keystone_admin)]$ glance md-resource-type-list\n+---------------------+\n| name                |\n+---------------------+\n| OS::Glance::Image   |\n| OS::Cinder::Volume  |\n| OS::Nova::Flavor    |\n| OS::Nova::Aggregate |\n| OS::Nova::Server    |\n| OS::Trove::Instance |\n+---------------------+","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ab492914e16e1846d0adea921c4a9fef37166b5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add judgment when getting resource_name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If glance does not have any resource type association，we will get"},{"line_number":10,"context_line":"IndexError when getting resource_name from list_resource_types\u0027s"},{"line_number":11,"context_line":"response body because the response body does not have any resource_types."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_3ea9ffd9","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":53},"in_reply_to":"3f79a3b5_f8307e07","updated":"2018-12-10 01:56:52.000000000","message":"Devstack uses following command to import resource types:\n+ lib/glance:init_glance:312 : /usr/local/bin/glance-manage --config-file /etc/glance/glance-api.conf db_load_metadefs\n\nSo I guess other openstack installation solution should do the similar thing.","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"}],"tempest/api/image/v2/test_images_metadefs_namespace_properties.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5a3562b566c0a312cd114009576f8912b30bc213","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_basic_meta_def_namespace_property(self):"},{"line_number":23,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":24,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":25,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":26,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":27,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":28,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_273ed226","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":47},"updated":"2018-12-10 06:27:46.000000000","message":"Maybe you can add\n\"self.assertNotEmpty(resource_types)\"\nto avoid IndexError, and, just ignore these failures from the tempest result.","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":29642,"name":"Liu Xiaolei","email":"liuxiaolei_yewu@cmss.chinamobile.com","username":"LiuXiaolei"},"change_message_id":"aca64651798879eccac3392a3661ae41284ae443","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_basic_meta_def_namespace_property(self):"},{"line_number":23,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":24,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":25,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":26,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":27,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":28,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_52d62a56","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":47},"in_reply_to":"3f79a3b5_273ed226","updated":"2018-12-11 06:14:10.000000000","message":"The \u0027resource_types\u0027 is defined by me in this patch.\nThe actuall IndexError is from  \u0027body[\u0027resource_types\u0027][0]\u0027 because \u0027body[\u0027resource_types\u0027]\u0027 is empty.\nWe must get a resource_name to get the test going on.","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bdcdfcf2b520b0fd9f24e87e1b7c5c47a7bd407d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_basic_meta_def_namespace_property(self):"},{"line_number":23,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":24,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":25,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":26,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":27,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":28,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5cf5c684","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":47},"in_reply_to":"3f79a3b5_52d62a56","updated":"2018-12-11 06:45:01.000000000","message":"So we will be back to the original question: is it a bug if glance doesn\u0027t have any resource type association?","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":29642,"name":"Liu Xiaolei","email":"liuxiaolei_yewu@cmss.chinamobile.com","username":"LiuXiaolei"},"change_message_id":"42245bcd0de0e0713f34a73aff7696056cded070","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_basic_meta_def_namespace_property(self):"},{"line_number":23,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":24,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":25,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":26,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":27,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":28,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bcbada6c","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":47},"in_reply_to":"3f79a3b5_5cf5c684","updated":"2018-12-11 06:58:50.000000000","message":"Or we can say that these three test cases is not comprehensive and we need to make it more comprehensive.","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5df9fe760c3c079ccd6446e4a1086b7419c0cfba","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_basic_meta_def_namespace_property(self):"},{"line_number":23,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":24,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":25,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":26,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":27,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":28,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_027048da","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":47},"in_reply_to":"3f79a3b5_bcbada6c","updated":"2018-12-11 07:42:28.000000000","message":"Then we should clarify two things:\n1. Is it a bug if glance doesn\u0027t have any resource type association?\n2. Does it make sense to test create_resource_type_association if no resource type is available?","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"261408a60a0ae7903a8dbbe1b2f561cb406529d1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":24,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":25,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":26,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":27,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":28,"context_line":"        else:"},{"line_number":29,"context_line":"            resource_name \u003d body[\u0027resource_types\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_940d1293","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":31},"updated":"2018-12-15 00:06:01.000000000","message":"nit: not resources_types","commit_id":"bf1d3df1a4e4c775959472603feec2d08b4dd025"}],"tempest/api/image/v2/test_images_metadefs_namespaces.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"261408a60a0ae7903a8dbbe1b2f561cb406529d1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # get the available resource types and use one resource_type"},{"line_number":29,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":30,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":31,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":32,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":33,"context_line":"        else:"},{"line_number":34,"context_line":"            resource_name \u003d body[\u0027resource_types\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_34043e6c","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":31},"updated":"2018-12-15 00:06:01.000000000","message":"Ditto","commit_id":"bf1d3df1a4e4c775959472603feec2d08b4dd025"}],"tempest/api/image/v2/test_images_metadefs_resource_types.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"be3734ad14da48fca4e8185b73039cd332bc3fb2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":27,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":28,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":29,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            resource_name \u003d body[\u0027resource_types\u0027][0][\u0027name\u0027]"},{"line_number":32,"context_line":"        # Create a namespace"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_058a751e","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":38},"updated":"2018-12-12 10:14:48.000000000","message":"data_utils is not defined or not imported!","commit_id":"529b4bd513f08b4116b27ad61583b4040c82b084"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"261408a60a0ae7903a8dbbe1b2f561cb406529d1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # Get the available resource types and use one resource_type"},{"line_number":27,"context_line":"        body \u003d self.resource_types_client.list_resource_types()"},{"line_number":28,"context_line":"        resource_types \u003d body[\u0027resource_types\u0027]"},{"line_number":29,"context_line":"        if resource_types \u003d\u003d []:"},{"line_number":30,"context_line":"            resource_name \u003d data_utils.rand_name(name\u003d\u0027resource_type\u0027)"},{"line_number":31,"context_line":"        else:"},{"line_number":32,"context_line":"            resource_name \u003d body[\u0027resource_types\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_54077a70","line":29,"range":{"start_line":29,"start_character":11,"end_line":29,"end_character":31},"updated":"2018-12-15 00:06:01.000000000","message":"Ditto","commit_id":"bf1d3df1a4e4c775959472603feec2d08b4dd025"}]}