)]}'
{"releasenotes/notes/bug-1808473-54ada26ab78e7b02.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed bug #1808473. ``tempest run`` CLI will error if a non-exist config file is"},{"line_number":5,"context_line":"    input to parameter --config-file. Earlier non-exist config value was silently getting ignored, and"},{"line_number":6,"context_line":"    the default config file was used instead which used to give false behavior to the user on using"},{"line_number":7,"context_line":"    the passed config file."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_f434864a","line":5,"range":{"start_line":5,"start_character":99,"end_line":5,"end_character":102},"updated":"2018-12-15 00:04:35.000000000","message":"Line length.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"276b34eece0a2dae232a3ec21751860ff2040f54","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed bug #1808473. ``tempest run`` CLI will error if a non-exist config file is"},{"line_number":5,"context_line":"    input to parameter --config-file. Earlier non-exist config value was silently getting ignored, and"},{"line_number":6,"context_line":"    the default config file was used instead which used to give false behavior to the user on using"},{"line_number":7,"context_line":"    the passed config file."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_7f85a601","line":5,"range":{"start_line":5,"start_character":99,"end_line":5,"end_character":102},"in_reply_to":"3f79a3b5_f434864a","updated":"2018-12-17 06:41:47.000000000","message":"Will fix it in next PS.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"}],"tempest/api/compute/servers/test_attach_interfaces.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ac10515b33cd082277ca8636e8996a9964de890","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        if not (CONF.auth.use_dynamic_credentials and"},{"line_number":257,"context_line":"                CONF.auth.create_isolated_networks and"},{"line_number":258,"context_line":"                not CONF.network.shared_physical_network):"},{"line_number":259,"context_line":"            raise self.skipException(\"Only owner network supports \""},{"line_number":260,"context_line":"                                     \"creating interface by fixed ip.\")"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        server, ifs \u003d self._create_server_get_interfaces()"},{"line_number":263,"context_line":"        interface_count \u003d len(ifs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_5b017805","line":260,"range":{"start_line":259,"start_character":0,"end_line":260,"end_character":71},"updated":"2019-03-16 02:29:58.000000000","message":"these are unrelated change.","commit_id":"81ce1eff97340a4952047c2c530cec745f746426"}],"tempest/cmd/run.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff65e6f751d3b330103cbda37a1821a4ba614794","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _set_env(self, config_file\u003dNone):"},{"line_number":114,"context_line":"        if config_file:"},{"line_number":115,"context_line":"            if os.path.exists(config_file):"},{"line_number":116,"context_line":"                CONF.set_config_path(config_file)"},{"line_number":117,"context_line":"            else:"},{"line_number":118,"context_line":"                raise ValueError("},{"line_number":119,"context_line":"                    \"Config file: %s doesn\u0027t exist\" % config_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_eb86f6db","line":116,"range":{"start_line":116,"start_character":37,"end_line":116,"end_character":48},"updated":"2019-02-07 07:44:17.000000000","message":"we do not need to set as abspath ?","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if os.path.exists(config_file):"},{"line_number":116,"context_line":"                CONF.set_config_path(config_file)"},{"line_number":117,"context_line":"            else:"},{"line_number":118,"context_line":"                raise ValueError("},{"line_number":119,"context_line":"                    \"Config file: %s doesn\u0027t exist\" % config_file)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # NOTE(mtreinish): This is needed so that stestr doesn\u0027t gobble up any"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b4d04ef7","line":118,"range":{"start_line":118,"start_character":22,"end_line":118,"end_character":32},"updated":"2018-12-15 00:04:35.000000000","message":"FileNotFoundError is a bit more appropriate:\n\nhttps://docs.python.org/3/library/exceptions.html#FileNotFoundError","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"276b34eece0a2dae232a3ec21751860ff2040f54","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if os.path.exists(config_file):"},{"line_number":116,"context_line":"                CONF.set_config_path(config_file)"},{"line_number":117,"context_line":"            else:"},{"line_number":118,"context_line":"                raise ValueError("},{"line_number":119,"context_line":"                    \"Config file: %s doesn\u0027t exist\" % config_file)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # NOTE(mtreinish): This is needed so that stestr doesn\u0027t gobble up any"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bf6d7e69","line":118,"range":{"start_line":118,"start_character":22,"end_line":118,"end_character":32},"in_reply_to":"3f79a3b5_b4d04ef7","updated":"2018-12-17 06:41:47.000000000","message":"Ok, will fix it in next PS.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff65e6f751d3b330103cbda37a1821a4ba614794","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            if os.path.exists(config_file):"},{"line_number":116,"context_line":"                CONF.set_config_path(config_file)"},{"line_number":117,"context_line":"            else:"},{"line_number":118,"context_line":"                raise ValueError("},{"line_number":119,"context_line":"                    \"Config file: %s doesn\u0027t exist\" % config_file)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # NOTE(mtreinish): This is needed so that stestr doesn\u0027t gobble up any"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8b6baa1d","line":118,"range":{"start_line":118,"start_character":22,"end_line":118,"end_character":32},"in_reply_to":"3f79a3b5_bf6d7e69","updated":"2019-02-07 07:44:17.000000000","message":"+1","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ac10515b33cd082277ca8636e8996a9964de890","unresolved":false,"context_lines":[{"line_number":111,"context_line":"class TempestRun(command.Command):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def _set_env(self, config_file\u003dNone):"},{"line_number":114,"context_line":"        if config_file:"},{"line_number":115,"context_line":"            if os.path.exists(config_file):"},{"line_number":116,"context_line":"                CONF.set_config_path(config_file)"},{"line_number":117,"context_line":"            else:"},{"line_number":118,"context_line":"                raise ValueError("},{"line_number":119,"context_line":"                    \"Config file: %s doesn\u0027t exist\" % config_file)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # NOTE(mtreinish): This is needed so that stestr doesn\u0027t gobble up any"},{"line_number":122,"context_line":"        # stacktraces on failure."}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_56162f4b","line":119,"range":{"start_line":114,"start_character":0,"end_line":119,"end_character":66},"updated":"2019-03-16 02:29:58.000000000","message":"PS1 comments are not fixed here.","commit_id":"81ce1eff97340a4952047c2c530cec745f746426"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2ea030920425693babaae46410991bc0f36a2c97","unresolved":false,"context_lines":[{"line_number":103,"context_line":"from tempest.common import credentials_factory as credentials"},{"line_number":104,"context_line":"from tempest import config"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"if six.PY2:"},{"line_number":107,"context_line":"    # Python 2 has not FileNotFoundError exception"},{"line_number":108,"context_line":"    FileNotFoundError \u003d IOError"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"CONF \u003d config.CONF"},{"line_number":111,"context_line":"SAVED_STATE_JSON \u003d \"saved_state.json\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c83a2033","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":31},"updated":"2019-03-21 02:03:44.000000000","message":"Yeah this works as per a suggestion here: https://stackoverflow.com/questions/21367320/searching-for-equivalent-of-filenotfounderror-in-python-2","commit_id":"21491dff81aa5a2448406b55ec58fff19dcf4c5f"}],"tempest/lib/cmd/check_uuid.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ac10515b33cd082277ca8636e8996a9964de890","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                          if self._is_test_case(module, node))"},{"line_number":234,"context_line":"            for node in test_cases:"},{"line_number":235,"context_line":"                for subnode in filter(self._is_test_method, node.body):"},{"line_number":236,"context_line":"                    test_name \u003d \u0027%s.%s\u0027 % (node.name, subnode.name)"},{"line_number":237,"context_line":"                    tests[module_name][\u0027tests\u0027][test_name] \u003d subnode"},{"line_number":238,"context_line":"        return tests"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_b6075318","line":237,"range":{"start_line":236,"start_character":19,"end_line":237,"end_character":68},"updated":"2019-03-16 02:29:58.000000000","message":"ditto","commit_id":"81ce1eff97340a4952047c2c530cec745f746426"}],"tempest/lib/common/rest_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4ac10515b33cd082277ca8636e8996a9964de890","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        if (resp.status \u003d\u003d 205 and"},{"line_number":527,"context_line":"            0 !\u003d len(set(resp.keys()) - set((\u0027status\u0027,)) -"},{"line_number":528,"context_line":"                     self.response_header_lc - self.general_header_lc)):"},{"line_number":529,"context_line":"            raise exceptions.ResponseWithEntity()"},{"line_number":530,"context_line":"        # NOTE(afazekas)"},{"line_number":531,"context_line":"        # Now the swift sometimes (delete not empty container)"},{"line_number":532,"context_line":"        # returns with non json error response, we can create new rest class"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_96101750","line":529,"range":{"start_line":529,"start_character":47,"end_line":529,"end_character":49},"updated":"2019-03-16 02:29:58.000000000","message":"ditto","commit_id":"81ce1eff97340a4952047c2c530cec745f746426"}],"tempest/tests/cmd/test_run.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.run_cmd \u003d run.TempestRun(None, None)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":160,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"},{"line_number":161,"context_line":"        # Checking TEMPEST_CONFIG_DIR and TEMPEST_CONFIG is actually"},{"line_number":162,"context_line":"        # getting set in os environment when some data has passed to"},{"line_number":163,"context_line":"        # set the environment."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":167,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":168,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":169,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"},{"line_number":170,"context_line":"                                      os.environ[\u0027TEMPEST_CONFIG\u0027]))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":173,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d4e4ead5","side":"PARENT","line":170,"range":{"start_line":160,"start_character":0,"end_line":170,"end_character":68},"updated":"2018-12-15 00:04:35.000000000","message":"This is for checking bug https://github.com/openstack/tempest/blob/9bb03a9782cf3a882ef4efb6545109d437b6e569/tempest/config.py#L1270\n\nBut this doesn\u0027t fix that bug, so we should create new tests instead, no?","commit_id":"9bb03a9782cf3a882ef4efb6545109d437b6e569"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"276b34eece0a2dae232a3ec21751860ff2040f54","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.run_cmd \u003d run.TempestRun(None, None)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":160,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"},{"line_number":161,"context_line":"        # Checking TEMPEST_CONFIG_DIR and TEMPEST_CONFIG is actually"},{"line_number":162,"context_line":"        # getting set in os environment when some data has passed to"},{"line_number":163,"context_line":"        # set the environment."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":167,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":168,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":169,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"},{"line_number":170,"context_line":"                                      os.environ[\u0027TEMPEST_CONFIG\u0027]))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":173,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ff73f64e","side":"PARENT","line":170,"range":{"start_line":160,"start_character":0,"end_line":170,"end_character":68},"in_reply_to":"3f79a3b5_d4e4ead5","updated":"2018-12-17 06:41:47.000000000","message":"Do you mean, need to keep this old code as it is and instead add another test cases?","commit_id":"9bb03a9782cf3a882ef4efb6545109d437b6e569"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff65e6f751d3b330103cbda37a1821a4ba614794","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.run_cmd \u003d run.TempestRun(None, None)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":160,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"},{"line_number":161,"context_line":"        # Checking TEMPEST_CONFIG_DIR and TEMPEST_CONFIG is actually"},{"line_number":162,"context_line":"        # getting set in os environment when some data has passed to"},{"line_number":163,"context_line":"        # set the environment."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.run_cmd._set_env(\"/fakedir/fakefile\")"},{"line_number":166,"context_line":"        self.assertEqual(\"/fakedir/fakefile\", CONF._path)"},{"line_number":167,"context_line":"        self.assertIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":168,"context_line":"        self.assertEqual(\"/fakedir/fakefile\","},{"line_number":169,"context_line":"                         os.path.join(os.environ[\u0027TEMPEST_CONFIG_DIR\u0027],"},{"line_number":170,"context_line":"                                      os.environ[\u0027TEMPEST_CONFIG\u0027]))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":173,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cb6bf2ee","side":"PARENT","line":170,"range":{"start_line":160,"start_character":0,"end_line":170,"end_character":68},"in_reply_to":"3f79a3b5_ff73f64e","updated":"2019-02-07 07:44:17.000000000","message":"I agree with Felipe to keep this code as bug#1783751 still exit and workaround of setting TEMPEST_CONFIG_DIR and TEMPEST_CONFIG are still there.","commit_id":"9bb03a9782cf3a882ef4efb6545109d437b6e569"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff65e6f751d3b330103cbda37a1821a4ba614794","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self.run_cmd._set_env(\"\")"},{"line_number":178,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":179,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":180,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG\u0027, os.environ)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class TestTakeAction(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6ba76651","side":"PARENT","line":180,"range":{"start_line":179,"start_character":0,"end_line":180,"end_character":54},"updated":"2019-02-07 07:44:17.000000000","message":"+1 on keeping this test. does this run successfully always? hope none of the tests is setting the TEMPEST_CONFIG_DIR which can run in parallel and can cause failure in this test.","commit_id":"9bb03a9782cf3a882ef4efb6545109d437b6e569"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                      os.environ[\u0027TEMPEST_CONFIG\u0027]))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def test_tempest_run_set_config_no_path(self):"},{"line_number":173,"context_line":"        # Note: (mbindlish) This test is created for the bug id: 1783751"},{"line_number":174,"context_line":"        # Checking TEMPEST_CONFIG_DIR and TEMPEST_CONFIG should have no value"},{"line_number":175,"context_line":"        # in os environment when no data has passed to set the environment."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self.run_cmd._set_env(\"\")"},{"line_number":178,"context_line":"        self.assertFalse(CONF._path)"},{"line_number":179,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG_DIR\u0027, os.environ)"},{"line_number":180,"context_line":"        self.assertNotIn(\u0027TEMPEST_CONFIG\u0027, os.environ)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class TestTakeAction(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9424321b","side":"PARENT","line":180,"range":{"start_line":173,"start_character":0,"end_line":180,"end_character":54},"updated":"2018-12-15 00:04:35.000000000","message":"Ditto.","commit_id":"9bb03a9782cf3a882ef4efb6545109d437b6e569"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        super(TestConfigPathCheck, self).setUp()"},{"line_number":157,"context_line":"        self.run_cmd \u003d run.TempestRun(None, None)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":160,"context_line":"        _, path \u003d tempfile.mkstemp()"},{"line_number":161,"context_line":"        self.addCleanup(os.remove, path)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_542e9af8","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":40},"updated":"2018-12-15 00:04:35.000000000","message":"We can make os.path.exists to return True here instead. No other changes needed.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ff65e6f751d3b330103cbda37a1821a4ba614794","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        super(TestConfigPathCheck, self).setUp()"},{"line_number":157,"context_line":"        self.run_cmd \u003d run.TempestRun(None, None)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":160,"context_line":"        _, path \u003d tempfile.mkstemp()"},{"line_number":161,"context_line":"        self.addCleanup(os.remove, path)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_87d15e5a","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":40},"in_reply_to":"3f79a3b5_1fc11251","updated":"2019-02-07 07:44:17.000000000","message":"or just creating an actual path file (L160) will be enough and better. \n\n_, path \u003d tempfile.mkstemp()","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"276b34eece0a2dae232a3ec21751860ff2040f54","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        super(TestConfigPathCheck, self).setUp()"},{"line_number":157,"context_line":"        self.run_cmd \u003d run.TempestRun(None, None)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_tempest_run_set_config_path(self):"},{"line_number":160,"context_line":"        _, path \u003d tempfile.mkstemp()"},{"line_number":161,"context_line":"        self.addCleanup(os.remove, path)"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1fc11251","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":40},"in_reply_to":"3f79a3b5_542e9af8","updated":"2018-12-17 06:41:47.000000000","message":"@Felipe: On community it was discussed, not to use environment variable because tests running in parallel can lead to race condition.\nSo is it ok to set env variable and then verify in env variable, whether the path exist or not? I am fearing that path may be overwrite by some another test\nor\nDo you mean something else?","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            self.run_cmd._set_env(path)"},{"line_number":166,"context_line":"        print_mock.assert_called_once_with(path)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_tempest_run_set_config_no_exist_path(self):"},{"line_number":169,"context_line":"        path \u003d \"fake/path\""},{"line_number":170,"context_line":"        ex \u003d self.assertRaises(ValueError,"},{"line_number":171,"context_line":"                               self.run_cmd._set_env, path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_342bdee9","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":49},"updated":"2018-12-15 00:04:35.000000000","message":"All we need is this new test.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"276b34eece0a2dae232a3ec21751860ff2040f54","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            self.run_cmd._set_env(path)"},{"line_number":166,"context_line":"        print_mock.assert_called_once_with(path)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_tempest_run_set_config_no_exist_path(self):"},{"line_number":169,"context_line":"        path \u003d \"fake/path\""},{"line_number":170,"context_line":"        ex \u003d self.assertRaises(ValueError,"},{"line_number":171,"context_line":"                               self.run_cmd._set_env, path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7f8046fa","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":49},"in_reply_to":"3f79a3b5_342bdee9","updated":"2018-12-17 06:41:47.000000000","message":"Do you mean to modify this test or asking to add same test in another patch?","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7ecfc75fe9279a2045c0b0ee7d577858427ea1c5","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_tempest_run_set_config_no_exist_path(self):"},{"line_number":169,"context_line":"        path \u003d \"fake/path\""},{"line_number":170,"context_line":"        ex \u003d self.assertRaises(ValueError,"},{"line_number":171,"context_line":"                               self.run_cmd._set_env, path)"},{"line_number":172,"context_line":"        self.assertIn(\"Config file: \" +"},{"line_number":173,"context_line":"                      path + \" doesn\\\u0027t exist\", str(ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f4efa6b0","line":170,"range":{"start_line":170,"start_character":18,"end_line":170,"end_character":30},"updated":"2018-12-15 00:04:35.000000000","message":"Can also use:\n\n    self.assertRaisesRegexp(\u0027Config file .* doesn\\\u0027t exist\u0027, ...)\n\nwhich is neater.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"},{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"276b34eece0a2dae232a3ec21751860ff2040f54","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_tempest_run_set_config_no_exist_path(self):"},{"line_number":169,"context_line":"        path \u003d \"fake/path\""},{"line_number":170,"context_line":"        ex \u003d self.assertRaises(ValueError,"},{"line_number":171,"context_line":"                               self.run_cmd._set_env, path)"},{"line_number":172,"context_line":"        self.assertIn(\"Config file: \" +"},{"line_number":173,"context_line":"                      path + \" doesn\\\u0027t exist\", str(ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3fa16ea8","line":170,"range":{"start_line":170,"start_character":18,"end_line":170,"end_character":30},"in_reply_to":"3f79a3b5_f4efa6b0","updated":"2018-12-17 06:41:47.000000000","message":"ok, will fix in next PS.","commit_id":"297fa425313fbbcb517b0be1b5cafca8162a9c8e"}]}