)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f9337fc736ea175eac869b7eb8724fe1eb4acc98","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        return member"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def _create_vip(self, name, protocol, protocol_port, subnet_id, pool_id,"},{"line_number":747,"context_line":"                    persistence_type\u003dNone):"},{"line_number":748,"context_line":"        \"\"\"Wrapper utility that returns a test vip.\"\"\""},{"line_number":749,"context_line":"        body \u003d {"},{"line_number":750,"context_line":"            \"vip\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F%2FP8%3D","line":747,"updated":"2013-12-25 11:36:05.000000000","message":"suggest to handle app cookie here (accept cookie_name parameter)","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"929625a51c660a845124d43e026038cfeb9d6616","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        return member"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def _create_vip(self, name, protocol, protocol_port, subnet_id, pool_id,"},{"line_number":747,"context_line":"                    persistence_type\u003dNone):"},{"line_number":748,"context_line":"        \"\"\"Wrapper utility that returns a test vip.\"\"\""},{"line_number":749,"context_line":"        body \u003d {"},{"line_number":750,"context_line":"            \"vip\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F9Ns%3D","line":747,"in_reply_to":"AAAAT3%2F%2F%2FP8%3D","updated":"2013-12-26 10:37:25.000000000","message":"Done","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a61103b8764efa0a788e8c1fefaec0096be6036f","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                \"pool_id\": pool_id,"},{"line_number":670,"context_line":"                \"protocol_port\": protocol_port"},{"line_number":671,"context_line":"            }"},{"line_number":672,"context_line":"        }"},{"line_number":673,"context_line":"        if persistence_type:"},{"line_number":674,"context_line":"            body[\"vip\"].update({\u0027session_persistence\u0027:"},{"line_number":675,"context_line":"                                {\u0027type\u0027: persistence_type}})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BhKY%3D","line":672,"updated":"2014-03-26 08:42:26.000000000","message":"maybe only:\n body[\"vip\"].update(kwargs)\n\nas used above in several places (line 549)\nlet the neutron-client worry about the rest","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"92bddc1f273003e088ec73a3c53e0c933ed6f3dd","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                \"pool_id\": pool_id,"},{"line_number":670,"context_line":"                \"protocol_port\": protocol_port"},{"line_number":671,"context_line":"            }"},{"line_number":672,"context_line":"        }"},{"line_number":673,"context_line":"        if persistence_type:"},{"line_number":674,"context_line":"            body[\"vip\"].update({\u0027session_persistence\u0027:"},{"line_number":675,"context_line":"                                {\u0027type\u0027: persistence_type}})"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bg%2Bo%3D","line":672,"in_reply_to":"AAAAWH%2F%2BhKY%3D","updated":"2014-03-26 09:04:50.000000000","message":"Fair enough, thanks. I\u0027ll amend it.","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"}],"tempest/scenario/neutron_lbaas/lbaas_manager.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f9337fc736ea175eac869b7eb8724fe1eb4acc98","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.pools[0] \u003d self.network_client.show_pool("},{"line_number":118,"context_line":"            self.pools[0][\u0027id\u0027])[\u0027pool\u0027]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _create_vip(self, persistence_type):"},{"line_number":121,"context_line":"        \"\"\"Create a VIP.\"\"\""},{"line_number":122,"context_line":"        name \u003d data_utils.rand_name(\u0027vip-\u0027)"},{"line_number":123,"context_line":"        subnet_id \u003d self.subnets[0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F%2FP4%3D","line":120,"updated":"2013-12-25 11:36:05.000000000","message":"ditto","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"929625a51c660a845124d43e026038cfeb9d6616","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.pools[0] \u003d self.network_client.show_pool("},{"line_number":118,"context_line":"            self.pools[0][\u0027id\u0027])[\u0027pool\u0027]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _create_vip(self, persistence_type):"},{"line_number":121,"context_line":"        \"\"\"Create a VIP.\"\"\""},{"line_number":122,"context_line":"        name \u003d data_utils.rand_name(\u0027vip-\u0027)"},{"line_number":123,"context_line":"        subnet_id \u003d self.subnets[0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F9No%3D","line":120,"in_reply_to":"AAAAT3%2F%2F%2FP4%3D","updated":"2013-12-26 10:37:25.000000000","message":"Done","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"}],"tempest/scenario/neutron_lbaas/test_lb_session_persistence.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f9337fc736ea175eac869b7eb8724fe1eb4acc98","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        super(TestSessionPersistence, cls).check_preconditions()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _create_servers(self):"},{"line_number":53,"context_line":"        for count in range(2):"},{"line_number":54,"context_line":"            self._create_server()"},{"line_number":55,"context_line":"        self.assertEqual(len(self.servers), 2)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F%2FMw%3D","line":53,"updated":"2013-12-25 11:36:05.000000000","message":"I think one instance is enough, just start http server on different ports","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"929625a51c660a845124d43e026038cfeb9d6616","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        super(TestSessionPersistence, cls).check_preconditions()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _create_servers(self):"},{"line_number":53,"context_line":"        for count in range(2):"},{"line_number":54,"context_line":"            self._create_server()"},{"line_number":55,"context_line":"        self.assertEqual(len(self.servers), 2)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F9NY%3D","line":53,"in_reply_to":"AAAAT3%2F%2F%2FMw%3D","updated":"2013-12-26 10:37:25.000000000","message":"Thanks for the advice. Done","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f9337fc736ea175eac869b7eb8724fe1eb4acc98","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                             self.network_client.vip_path % ("},{"line_number":104,"context_line":"                                 self.vips[0][\u0027id\u0027]),"},{"line_number":105,"context_line":"                             expected_status\u003d\u0027ACTIVE\u0027)"},{"line_number":106,"context_line":"        self.vips[0] \u003d self.network_client.show_vip(self.vips[0][\u0027id\u0027])[\u0027vip\u0027]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _check_cookie_session_persistence(self):"},{"line_number":109,"context_line":"        vip \u003d self.vips[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F%2FLo%3D","line":106,"updated":"2013-12-25 11:36:05.000000000","message":"would be useful to check here if persistence was configured correctly","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"929625a51c660a845124d43e026038cfeb9d6616","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                             self.network_client.vip_path % ("},{"line_number":104,"context_line":"                                 self.vips[0][\u0027id\u0027]),"},{"line_number":105,"context_line":"                             expected_status\u003d\u0027ACTIVE\u0027)"},{"line_number":106,"context_line":"        self.vips[0] \u003d self.network_client.show_vip(self.vips[0][\u0027id\u0027])[\u0027vip\u0027]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _check_cookie_session_persistence(self):"},{"line_number":109,"context_line":"        vip \u003d self.vips[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F9NU%3D","line":106,"in_reply_to":"AAAAT3%2F%2F%2FLo%3D","updated":"2013-12-26 10:37:25.000000000","message":"Done","commit_id":"bc49209fb9b885a186361f2abec062c9efcfb84f"}],"tempest/scenario/test_load_balancer_basic.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a61103b8764efa0a788e8c1fefaec0096be6036f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        the requests containing the same cookie to hit the same"},{"line_number":63,"context_line":"        member of the pool"},{"line_number":64,"context_line":"    6. Change session persistence type of the VIP to APP_COOKIE."},{"line_number":65,"context_line":"    7. Perform the same check."},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BhJ4%3D","line":65,"updated":"2014-03-26 08:42:26.000000000","message":"8. Change back to default and test again","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"372df20fe2d260162baf8f4d204d248bf25f4111","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        the requests containing the same cookie to hit the same"},{"line_number":63,"context_line":"        member of the pool"},{"line_number":64,"context_line":"    6. Change session persistence type of the VIP to APP_COOKIE."},{"line_number":65,"context_line":"    7. Perform the same check."},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BgV8%3D","line":65,"in_reply_to":"AAAAWH%2F%2Bg%2FU%3D","updated":"2014-03-26 10:41:26.000000000","message":"No session persistence","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"92bddc1f273003e088ec73a3c53e0c933ed6f3dd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        the requests containing the same cookie to hit the same"},{"line_number":63,"context_line":"        member of the pool"},{"line_number":64,"context_line":"    6. Change session persistence type of the VIP to APP_COOKIE."},{"line_number":65,"context_line":"    7. Perform the same check."},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bg%2FU%3D","line":65,"in_reply_to":"AAAAWH%2F%2BhJ4%3D","updated":"2014-03-26 09:04:50.000000000","message":"What do you mean by default here? No session persistence or SOURCE_IP persistence?","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a61103b8764efa0a788e8c1fefaec0096be6036f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.assertEqual(len(set(resp)), 1)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def _update_vip_session_persistence(self, persistence_type,"},{"line_number":362,"context_line":"                                        cookie_name\u003dNone):"},{"line_number":363,"context_line":"        update_data \u003d {\u0027vip\u0027: {\"session_persistence\": {"},{"line_number":364,"context_line":"            \"type\": persistence_type}}}"},{"line_number":365,"context_line":"        if cookie_name:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BhJA%3D","line":362,"updated":"2014-03-26 08:42:26.000000000","message":"I suggest implementing this as update() method of net_common.DeletableVIp object","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"92bddc1f273003e088ec73a3c53e0c933ed6f3dd","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.assertEqual(len(set(resp)), 1)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def _update_vip_session_persistence(self, persistence_type,"},{"line_number":362,"context_line":"                                        cookie_name\u003dNone):"},{"line_number":363,"context_line":"        update_data \u003d {\u0027vip\u0027: {\"session_persistence\": {"},{"line_number":364,"context_line":"            \"type\": persistence_type}}}"},{"line_number":365,"context_line":"        if cookie_name:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BhAU%3D","line":362,"in_reply_to":"AAAAWH%2F%2BhJA%3D","updated":"2014-03-26 09:04:50.000000000","message":"Good idea! I will consider it.","commit_id":"00cc0549170f88cd164b25da0639d60b004fd6ba"}]}