)]}'
{"tempest/api/identity/admin/v3/test_inherits.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d2f0e664e550e0d46f0e6a6dc4c24260665fafad","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def skip_checks(cls):"},{"line_number":46,"context_line":"        super(InheritsV3TestJSON, cls).skip_checks()"},{"line_number":47,"context_line":"        if not utils.is_extension_enabled(\u0027OS-INHERIT\u0027, \u0027identity\u0027):"},{"line_number":48,"context_line":"            raise cls.skipException(\"Inherits aren\u0027t enabled\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"},{"line_number":51,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_ffd902f4","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":62},"updated":"2019-01-07 09:35:17.000000000","message":"InheritsStaticV3TestJSON.test_inherit_assign_list_check_revoke_roles_on_domains_group doesn\u0027t need this?","commit_id":"4559bc1b0e8cd8bf4ca50e296ce2d33c418d2bc3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"7f55d3e27c08eabee0f71049a14c91841c7b354b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def skip_checks(cls):"},{"line_number":46,"context_line":"        super(InheritsV3TestJSON, cls).skip_checks()"},{"line_number":47,"context_line":"        if not utils.is_extension_enabled(\u0027OS-INHERIT\u0027, \u0027identity\u0027):"},{"line_number":48,"context_line":"            raise cls.skipException(\"Inherits aren\u0027t enabled\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"},{"line_number":51,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_68e9d57e","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":62},"in_reply_to":"dfd5e7cf_ffd902f4","updated":"2019-01-07 13:30:36.000000000","message":"Yeah it does, thanks for catching this. I will move it to the Base Class.","commit_id":"4559bc1b0e8cd8bf4ca50e296ce2d33c418d2bc3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d2f0e664e550e0d46f0e6a6dc4c24260665fafad","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            self.project[\u0027id\u0027], self.user[\u0027id\u0027], src_role[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u002726021436-d5a4-4256-943c-ded01e0d4b45\u0027)"},{"line_number":104,"context_line":"    def test_inherit_assign_check_revoke_roles_on_projects_group(self):"},{"line_number":105,"context_line":"        # Create role"},{"line_number":106,"context_line":"        src_role \u003d self.setup_test_role()"},{"line_number":107,"context_line":"        # Assign role on projects group"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_bffcda3e","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":64},"updated":"2019-01-07 09:35:17.000000000","message":"why this one need force_tenant_isolation \u003d True?","commit_id":"4559bc1b0e8cd8bf4ca50e296ce2d33c418d2bc3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"7f55d3e27c08eabee0f71049a14c91841c7b354b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            self.project[\u0027id\u0027], self.user[\u0027id\u0027], src_role[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u002726021436-d5a4-4256-943c-ded01e0d4b45\u0027)"},{"line_number":104,"context_line":"    def test_inherit_assign_check_revoke_roles_on_projects_group(self):"},{"line_number":105,"context_line":"        # Create role"},{"line_number":106,"context_line":"        src_role \u003d self.setup_test_role()"},{"line_number":107,"context_line":"        # Assign role on projects group"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_087da9b0","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":64},"in_reply_to":"dfd5e7cf_bffcda3e","updated":"2019-01-07 13:30:36.000000000","message":"It actually does not need it. I see there are no user creations done in this test after you have highlighted it for me. Thank you.","commit_id":"4559bc1b0e8cd8bf4ca50e296ce2d33c418d2bc3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"09fe81cd87856517e2b34117b954b7957582cfa5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        u_desc \u003d \u0027%s description\u0027 % u_name"},{"line_number":55,"context_line":"        u_email \u003d \u0027%s@testmail.tm\u0027 % u_name"},{"line_number":56,"context_line":"        u_password \u003d data_utils.rand_name(\u0027pass-\u0027)"},{"line_number":57,"context_line":"        cls.user \u003d cls.users_client.create_user("},{"line_number":58,"context_line":"            name\u003du_name, description\u003du_desc, password\u003du_password,"},{"line_number":59,"context_line":"            email\u003du_email, project_id\u003dcls.project[\u0027id\u0027],"},{"line_number":60,"context_line":"            domain_id\u003dcls.domain[\u0027id\u0027])[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfdaf3ff_40a6be55","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":48},"updated":"2019-01-17 14:02:49.000000000","message":"I should add skip checks for tests that create users in another change and rebase this patch on top of it. There will have to be some refactoring so that the user is created at a per-test level too.","commit_id":"1141f9baeb3db24a3a3e07ec0f69ffff720a79b2"}]}