)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"320b28fbea6f159043deb8992858ef4224c6f11e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":91,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":92,"context_line":"        self.assertIsNone(group_create_body[\u0027security_group\u0027][\u0027name\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SecGroupTestXML(SecGroupTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F%2FTA%3D","line":92,"updated":"2013-12-25 10:44:11.000000000","message":"I think it is better to use something like this\n\n    self.assertIn(group_create_body[\u0027security_group\u0027][\u0027name\u0027], [None, \u0027None\u0027])\n\nto avoid test copying.","commit_id":"20031a75b9e3e35738b0ee2e43ad8d46723cd585"},{"author":{"_account_id":8282,"name":"Dong Liu","email":"willowd878@gmail.com","username":"liudong"},"change_message_id":"a90bc9b8a9bf705949eb2b942b7a2d00646704e3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":91,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":92,"context_line":"        self.assertIsNone(group_create_body[\u0027security_group\u0027][\u0027name\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SecGroupTestXML(SecGroupTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F%2BNk%3D","line":92,"in_reply_to":"AAAAT3%2F%2F%2FTA%3D","updated":"2013-12-26 01:05:53.000000000","message":"Done","commit_id":"20031a75b9e3e35738b0ee2e43ad8d46723cd585"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"bb738506f403f1dfb3d992c96889091954ba767e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":86,"context_line":"    def test_create_security_group_without_name(self):"},{"line_number":87,"context_line":"        # Create a security group without specifying name."},{"line_number":88,"context_line":"        resp, group_create_body \u003d self.client.create_security_group(None)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":91,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F9aY%3D","line":88,"updated":"2013-12-26 09:44:29.000000000","message":"test is good. :-)  I only have a little confused here. Actually, this test creates \nsecgroup with parameter name, but the value is None(not without specifying \nname).  In create_security_group, name is a required parameter. So,\n\nWhich case do you want to test?\n \n1. specify a \"None\" name\n2. don\u0027t specify name in post_body\n\ndef create_security_group(self, name, **kwargs):\n        post_body \u003d {\n            \u0027security_group\u0027: {\n                \u0027name\u0027: name,\n            }\n        }","commit_id":"e194960da10792f80616475c4ae74737f93219ef"},{"author":{"_account_id":8282,"name":"Dong Liu","email":"willowd878@gmail.com","username":"liudong"},"change_message_id":"e080fa1b55ee4f938c98847f0bffa9231b9030d2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":86,"context_line":"    def test_create_security_group_without_name(self):"},{"line_number":87,"context_line":"        # Create a security group without specifying name."},{"line_number":88,"context_line":"        resp, group_create_body \u003d self.client.create_security_group(None)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":91,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F4Wc%3D","line":88,"in_reply_to":"AAAAT3%2F%2F4W8%3D","updated":"2013-12-28 06:53:21.000000000","message":"Do you think specify a null value to parameter \"name\" is unnecessary?","commit_id":"e194960da10792f80616475c4ae74737f93219ef"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"aa58b97a1823c83220bba2e1ea80722e8874dae5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":86,"context_line":"    def test_create_security_group_without_name(self):"},{"line_number":87,"context_line":"        # Create a security group without specifying name."},{"line_number":88,"context_line":"        resp, group_create_body \u003d self.client.create_security_group(None)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":91,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F2zQ%3D","line":88,"in_reply_to":"AAAAT3%2F%2F4Wc%3D","updated":"2013-12-30 03:32:50.000000000","message":"IMO, a null value for \"name\" is a reasonable case.  But it\u0027s better to use  \"test_create_security_group_with_null_name\" as test method\u0027s name.","commit_id":"e194960da10792f80616475c4ae74737f93219ef"},{"author":{"_account_id":8282,"name":"Dong Liu","email":"willowd878@gmail.com","username":"liudong"},"change_message_id":"096205cbf5ee25bc69cfd185b8a671c8becafb6c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":86,"context_line":"    def test_create_security_group_without_name(self):"},{"line_number":87,"context_line":"        # Create a security group without specifying name."},{"line_number":88,"context_line":"        resp, group_create_body \u003d self.client.create_security_group(None)"},{"line_number":89,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":90,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":91,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAT3%2F%2F4W8%3D","line":88,"in_reply_to":"AAAAT3%2F%2F9aY%3D","updated":"2013-12-28 06:50:39.000000000","message":"According to the code, the name is optional parameter.\nActually, I want to test specify a null value to parameter \"name\". This test is incorrect in xml test. I will fix it.\nAnd I will add another case is don\u0027t specify name in post_body.","commit_id":"e194960da10792f80616475c4ae74737f93219ef"}]}