)]}'
{"tempest/api/identity/admin/v3/test_regions.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"955b038b92ca92fba8bc69bf66e1a19781aee0af","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.setup_regions.append(region)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RegionsTestJSON(BaseRegionsTestJSON):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002756186092-82e4-43f2-b954-91013218ba42\u0027)"},{"line_number":45,"context_line":"    def test_create_update_get_delete_region(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_a76ca736","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":43},"updated":"2019-01-09 01:34:49.000000000","message":"Seems all the testcases in this class can use \"force_tenant_isolation \u003d False\"?","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"2ead77d29485c76ca45d323341110026d49104df","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.setup_regions.append(region)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RegionsTestJSON(BaseRegionsTestJSON):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002756186092-82e4-43f2-b954-91013218ba42\u0027)"},{"line_number":45,"context_line":"    def test_create_update_get_delete_region(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_e82122a1","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":43},"in_reply_to":"bfdaf3ff_135ff8e2","updated":"2019-01-14 15:33:12.000000000","message":"Done","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"fe08895e50f328497ceb6fa348f4b8863aef7db2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.setup_regions.append(region)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RegionsTestJSON(BaseRegionsTestJSON):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002756186092-82e4-43f2-b954-91013218ba42\u0027)"},{"line_number":45,"context_line":"    def test_create_update_get_delete_region(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_135ff8e2","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":43},"in_reply_to":"bfdaf3ff_ca180777","updated":"2019-01-14 14:29:47.000000000","message":"I have no objections to using \"force_tenant_isolation \u003d False\", I\u0027ll try to update this so that all tests use it. The concern I\u0027ve received in comments[0] is changing the test id path. If the test id is modified due to a new class name then I can\u0027t move tests in the interop repository because that would not align with their configured test ids[1].\n\n[0] https://review.openstack.org/#/c/523976/2/tempest/api/identity/admin/v3/test_list_projects.py@81\n[1] http://codesearch.openstack.org/?q\u003dtest_regions\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dinterop","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a70356e0648205b7205a3bba7d81a8bc6cc63f80","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.setup_regions.append(region)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RegionsTestJSON(BaseRegionsTestJSON):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002756186092-82e4-43f2-b954-91013218ba42\u0027)"},{"line_number":45,"context_line":"    def test_create_update_get_delete_region(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8daa0683","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":43},"in_reply_to":"bfdaf3ff_e82122a1","updated":"2019-01-21 14:49:15.000000000","message":"Yeah I think it\u0027s best not to change the underlying behavior of tests used by interop, even if that means setting \"force_tenant_isolat\u003dFalse\".","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b7afeaf1b433333e37602483ed93b552ecb41390","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.setup_regions.append(region)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RegionsTestJSON(BaseRegionsTestJSON):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002756186092-82e4-43f2-b954-91013218ba42\u0027)"},{"line_number":45,"context_line":"    def test_create_update_get_delete_region(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_ca180777","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":43},"in_reply_to":"dfd5e7cf_25996b6d","updated":"2019-01-11 01:32:10.000000000","message":"oh, I\u0027m not sure, where do you see the comments that interop doesn\u0027t want to use \"force_tenant_isolation \u003d True\"?","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"0ed941ec52c9b3858055e4ef24689d61b39866c1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            cls.setup_regions.append(region)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RegionsTestJSON(BaseRegionsTestJSON):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u002756186092-82e4-43f2-b954-91013218ba42\u0027)"},{"line_number":45,"context_line":"    def test_create_update_get_delete_region(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_25996b6d","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":43},"in_reply_to":"dfd5e7cf_a76ca736","updated":"2019-01-10 15:38:36.000000000","message":"I thought because they are interop tests we do want to use \"force_tenant_isolation \u003d True\". Is this not the case? If so, I can update these with \"force_tenant_isolation \u003d False\".","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a70356e0648205b7205a3bba7d81a8bc6cc63f80","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u00272d1057cb-bbde-413a-acdf-e2d265284542\u0027)"},{"line_number":112,"context_line":"    def test_list_regions_filter_by_parent_region_id(self):"},{"line_number":113,"context_line":"        # Add a sub-region to one of the existing test regions"},{"line_number":114,"context_line":"        r_description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":115,"context_line":"        region \u003d self.client.create_region("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_4d941e45","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":52},"updated":"2019-01-21 14:49:15.000000000","message":"This one looks OK to rename since it isn\u0027t referenced by anything.","commit_id":"24c15196f548d07e1ee69f9f3e97e73819836bc3"}]}