)]}'
{"tempest/clients.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"31acf01705d1bf7e7f4ab2c594dc8fb6712c8272","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.service_providers_client \u003d self.network.ServiceProvidersClient()"},{"line_number":71,"context_line":"        self.tags_client \u003d self.network.TagsClient()"},{"line_number":72,"context_line":"        self.qos_client \u003d self.network.QosClient()"},{"line_number":73,"context_line":"        self.qos_min_bw_client \u003d self.network.\\"},{"line_number":74,"context_line":"            QosMinimumBandwidthRulesClient()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _set_image_clients(self):"},{"line_number":77,"context_line":"        if CONF.service_available.glance:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_7092f2f8","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":44},"updated":"2019-05-21 03:02:05.000000000","message":"These can be put in one line","commit_id":"3d0566872e8cd64675980079bff9244a0bd39c3f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"56ba16517c4975d26936bf0b4504504a8f62fda9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.service_providers_client \u003d self.network.ServiceProvidersClient()"},{"line_number":71,"context_line":"        self.tags_client \u003d self.network.TagsClient()"},{"line_number":72,"context_line":"        self.qos_client \u003d self.network.QosClient()"},{"line_number":73,"context_line":"        self.qos_min_bw_client \u003d self.network.\\"},{"line_number":74,"context_line":"            QosMinimumBandwidthRulesClient()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _set_image_clients(self):"},{"line_number":77,"context_line":"        if CONF.service_available.glance:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_b6ab7fd4","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":44},"in_reply_to":"bfb3d3c7_7092f2f8","updated":"2019-05-21 09:09:48.000000000","message":"Done, anyway I have to wait till the the 2.70 \u0026 2.71 nova microversion schema validations are reviewed (see: https://review.opendev.org/640600, https://review.opendev.org/640601)","commit_id":"3d0566872e8cd64675980079bff9244a0bd39c3f"}],"tempest/lib/services/network/qos_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e310664beaa9416d5741080278633df982262a3","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class QosClient(base.BaseNetworkClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def create_qos_policy(self, **kwargs):"},{"line_number":21,"context_line":"        uri \u003d \u0027/qos/policies\u0027"},{"line_number":22,"context_line":"        post_data \u003d {\u0027policy\u0027: kwargs}"},{"line_number":23,"context_line":"        return self.create_resource(uri, post_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_dbc2f185","line":20,"updated":"2019-01-08 17:05:01.000000000","message":"Like in other clients, you should add documentation to the API. For example: https://developer.openstack.org/api-ref/network/v2/index.html#create-qos-policy","commit_id":"5f85a9cd73f05e38375d73a9536c9916aa806983"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e4959e14db48f28a54191c1b5809a7bb064e1d16","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class QosClient(base.BaseNetworkClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def create_qos_policy(self, **kwargs):"},{"line_number":21,"context_line":"        uri \u003d \u0027/qos/policies\u0027"},{"line_number":22,"context_line":"        post_data \u003d {\u0027policy\u0027: kwargs}"},{"line_number":23,"context_line":"        return self.create_resource(uri, post_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_95f65ff9","line":20,"in_reply_to":"dfd5e7cf_dbc2f185","updated":"2019-01-09 15:43:22.000000000","message":"Done","commit_id":"5f85a9cd73f05e38375d73a9536c9916aa806983"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8a978c5ed6f9c76d8975a7d037900791fda18ad9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class QosClient(base.BaseNetworkClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def create_qos_policy(self, **kwargs):"},{"line_number":21,"context_line":"        \"\"\"Creates a QoS policy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        For full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_38dc7473","line":20,"updated":"2019-01-11 21:18:26.000000000","message":"Why not include client implementation for the other REST endpoints, i.e. GET/PUT requests? \n\n GET\n/v2.0/qos/policies/{policy_id}/bandwidth_limit_rules\nList bandwidth limit rules for QoS policy\n\n POST\n/v2.0/qos/policies/{policy_id}/bandwidth_limit_rules\nCreate bandwidth limit rule\n\n GET\n/v2.0/qos/policies/{policy_id}/bandwidth_limit_rules/{rule_id}\nShow bandwidth limit rule details\n\n PUT\n/v2.0/qos/policies/{policy_id}/bandwidth_limit_rules/{rule_id}\nUpdate bandwidth limit rule\n\n DELETE\n/v2.0/qos/policies/{policy_id}/bandwidth_limit_rules/{rule_id}\nDelete bandwidth limit rule","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9fd4dc56d9bc52e46d498a4cef38cc8dccf259e8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class QosClient(base.BaseNetworkClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def create_qos_policy(self, **kwargs):"},{"line_number":21,"context_line":"        \"\"\"Creates a QoS policy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        For full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_0a011cb0","line":20,"in_reply_to":"bfdaf3ff_38dc7473","updated":"2019-02-05 13:14:01.000000000","message":"I added all the CRUDS operations for QoS policies, and QoS minimum bandwidth rules in a separate module (qos_minimum_bandwidth_rule_client.py)","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b8d8030873e448b73e207e54c00f1ce81b8e432d","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class QosClient(base.BaseNetworkClient):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def create_qos_policy(self, **kwargs):"},{"line_number":21,"context_line":"        \"\"\"Creates a QoS policy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        For full list of available parameters, please refer to the official"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_8da98b7c","line":20,"in_reply_to":"bfdaf3ff_38dc7473","updated":"2019-01-14 13:15:56.000000000","message":"Thanks for review\nThe idea was to add only the necessary clients for 2 reasons:\n* Keep the patch as simple as possible, see: https://review.openstack.org/#/c/622316/1//COMMIT_MSG@20\n* These client codes for QoS are duplication of the one implemented in neutron-tempest-plugin (https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/services/network/json/network_client.py#L570)","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8a978c5ed6f9c76d8975a7d037900791fda18ad9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        uri \u003d \u0027/qos/policies/%s\u0027 % qos_policy_id"},{"line_number":39,"context_line":"        return self.delete_resource(uri)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_minimum_bandwidth_rule(self, policy_id, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Creates a minimum bandwidth rule for a QoS policy."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":45,"context_line":"        API reference:"},{"line_number":46,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#create-minimum-bandwidth-rule"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules\u0027 % policy_id"},{"line_number":49,"context_line":"        post_data \u003d {\u0027minimum_bandwidth_rule\u0027: kwargs}"},{"line_number":50,"context_line":"        return self.create_resource(uri, post_data)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def delete_minimum_bandwidth_rule(self, qos_policy_id, rule_id):"},{"line_number":53,"context_line":"        \"\"\"Deletes a minimum bandwidth rule for a QoS policy."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":56,"context_line":"        API reference:"},{"line_number":57,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#delete-minimum-bandwidth-rule"},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":60,"context_line":"            qos_policy_id, rule_id)"},{"line_number":61,"context_line":"        return self.delete_resource(uri)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_d8ed2826","line":61,"range":{"start_line":41,"start_character":0,"end_line":61,"end_character":40},"updated":"2019-01-11 21:18:26.000000000","message":"Arguably these two belong in a separate client because they relate to a different endpoint: https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003d#qos-bandwidth-limit-rules","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9fd4dc56d9bc52e46d498a4cef38cc8dccf259e8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        uri \u003d \u0027/qos/policies/%s\u0027 % qos_policy_id"},{"line_number":39,"context_line":"        return self.delete_resource(uri)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_minimum_bandwidth_rule(self, policy_id, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Creates a minimum bandwidth rule for a QoS policy."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":45,"context_line":"        API reference:"},{"line_number":46,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#create-minimum-bandwidth-rule"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules\u0027 % policy_id"},{"line_number":49,"context_line":"        post_data \u003d {\u0027minimum_bandwidth_rule\u0027: kwargs}"},{"line_number":50,"context_line":"        return self.create_resource(uri, post_data)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def delete_minimum_bandwidth_rule(self, qos_policy_id, rule_id):"},{"line_number":53,"context_line":"        \"\"\"Deletes a minimum bandwidth rule for a QoS policy."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":56,"context_line":"        API reference:"},{"line_number":57,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#delete-minimum-bandwidth-rule"},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":60,"context_line":"            qos_policy_id, rule_id)"},{"line_number":61,"context_line":"        return self.delete_resource(uri)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_6a1d480e","line":61,"range":{"start_line":41,"start_character":0,"end_line":61,"end_character":40},"in_reply_to":"bfdaf3ff_d8ed2826","updated":"2019-02-05 13:14:01.000000000","message":"I moved to qos_minimum_bandwidth_rules_client.py","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b8d8030873e448b73e207e54c00f1ce81b8e432d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        uri \u003d \u0027/qos/policies/%s\u0027 % qos_policy_id"},{"line_number":39,"context_line":"        return self.delete_resource(uri)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_minimum_bandwidth_rule(self, policy_id, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Creates a minimum bandwidth rule for a QoS policy."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":45,"context_line":"        API reference:"},{"line_number":46,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#create-minimum-bandwidth-rule"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules\u0027 % policy_id"},{"line_number":49,"context_line":"        post_data \u003d {\u0027minimum_bandwidth_rule\u0027: kwargs}"},{"line_number":50,"context_line":"        return self.create_resource(uri, post_data)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def delete_minimum_bandwidth_rule(self, qos_policy_id, rule_id):"},{"line_number":53,"context_line":"        \"\"\"Deletes a minimum bandwidth rule for a QoS policy."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":56,"context_line":"        API reference:"},{"line_number":57,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html#delete-minimum-bandwidth-rule"},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":60,"context_line":"            qos_policy_id, rule_id)"},{"line_number":61,"context_line":"        return self.delete_resource(uri)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_8dc2eb32","line":61,"range":{"start_line":41,"start_character":0,"end_line":61,"end_character":40},"in_reply_to":"bfdaf3ff_d8ed2826","updated":"2019-01-14 13:15:56.000000000","message":"sure I can move these to separate client","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"}],"tempest/lib/services/network/qos_minimum_bandwidth_rules_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"adb3c0c846954940f4b1cc3039749beb566ee8f5","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":35,"context_line":"        API reference:"},{"line_number":36,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003dupdate-minimum-bandwidth-rule"},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":39,"context_line":"            qos_policy_id, rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_f4ec8ebc","line":36,"updated":"2019-04-03 07:09:51.000000000","message":"The URL should be \nhttps://developer.openstack.org/api-ref/network/v2/index.html#update-minimum-bandwidth-rule\nor\nhttps://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003dupdate-minimum-bandwidth-rule-detail#update-minimum-bandwidth-rule\n?","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4f53993bd349ff334cfd729e2e6b29939ef0e2c6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":35,"context_line":"        API reference:"},{"line_number":36,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003dupdate-minimum-bandwidth-rule"},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":39,"context_line":"            qos_policy_id, rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_80001204","line":36,"in_reply_to":"5fc1f717_f4ec8ebc","updated":"2019-04-08 06:37:10.000000000","message":"Thanks, you are right,","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4f53993bd349ff334cfd729e2e6b29939ef0e2c6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":35,"context_line":"        API reference:"},{"line_number":36,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003dupdate-minimum-bandwidth-rule"},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":39,"context_line":"            qos_policy_id, rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_340ac31f","line":36,"in_reply_to":"5fc1f717_f4ec8ebc","updated":"2019-04-08 06:37:10.000000000","message":"Thanks, you are right, I removed the expanded part","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"adb3c0c846954940f4b1cc3039749beb566ee8f5","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":47,"context_line":"        API reference:"},{"line_number":48,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003d#show-minimum-bandwidth-rule-details"},{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":51,"context_line":"            qos_policy_id, rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_94298af3","line":48,"updated":"2019-04-03 07:09:51.000000000","message":"\u0027?expanded\u003d\u0027 is not necessary.","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4f53993bd349ff334cfd729e2e6b29939ef0e2c6","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":47,"context_line":"        API reference:"},{"line_number":48,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003d#show-minimum-bandwidth-rule-details"},{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules/%s\u0027 % ("},{"line_number":51,"context_line":"            qos_policy_id, rule_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_d4125f58","line":48,"in_reply_to":"5fc1f717_94298af3","updated":"2019-04-08 06:37:10.000000000","message":"Done","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"adb3c0c846954940f4b1cc3039749beb566ee8f5","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":69,"context_line":"        API reference:"},{"line_number":70,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003d#list-minimum-bandwidth-rules-for-qos-policy"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules\u0027 % qos_policy_id"},{"line_number":73,"context_line":"        return self.list_resources(uri, **filters)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_b42cc601","line":70,"updated":"2019-04-03 07:09:51.000000000","message":"ditto","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4f53993bd349ff334cfd729e2e6b29939ef0e2c6","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        For full list of available parameters, please refer to the official"},{"line_number":69,"context_line":"        API reference:"},{"line_number":70,"context_line":"        https://developer.openstack.org/api-ref/network/v2/index.html?expanded\u003d#list-minimum-bandwidth-rules-for-qos-policy"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        uri \u003d \u0027/qos/policies/%s/minimum_bandwidth_rules\u0027 % qos_policy_id"},{"line_number":73,"context_line":"        return self.list_resources(uri, **filters)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_f40f5b2b","line":70,"in_reply_to":"5fc1f717_b42cc601","updated":"2019-04-08 06:37:10.000000000","message":"Done","commit_id":"a63226ae5bbb008f9bd3d298671a7e9571856f59"}],"tempest/tests/lib/services/network/test_qos_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e310664beaa9416d5741080278633df982262a3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027name\u0027: \u0027foo\u0027,"},{"line_number":33,"context_line":"            \u0027id\u0027: FAKE_QOS_POLICY_ID,"},{"line_number":34,"context_line":"            \u0027shared\u0027: True,"},{"line_number":35,"context_line":"            \u0027rules\u0027: []"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_3b8f7d24","line":35,"updated":"2019-01-08 17:05:01.000000000","message":"You are missing the \"description\", \"is_default\" and \"project_id\" fields","commit_id":"5f85a9cd73f05e38375d73a9536c9916aa806983"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e4959e14db48f28a54191c1b5809a7bb064e1d16","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027name\u0027: \u0027foo\u0027,"},{"line_number":33,"context_line":"            \u0027id\u0027: FAKE_QOS_POLICY_ID,"},{"line_number":34,"context_line":"            \u0027shared\u0027: True,"},{"line_number":35,"context_line":"            \u0027rules\u0027: []"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_75289b33","line":35,"in_reply_to":"dfd5e7cf_3b8f7d24","updated":"2019-01-09 15:43:22.000000000","message":"Done","commit_id":"5f85a9cd73f05e38375d73a9536c9916aa806983"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8a978c5ed6f9c76d8975a7d037900791fda18ad9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    FAKE_QOS_POLICY_RESPONSE \u003d {"},{"line_number":31,"context_line":"        \u0027policy\u0027: {"},{"line_number":32,"context_line":"            \u0027description\u0027: \u0027bar\u0027,"},{"line_number":33,"context_line":"            \u0027project_id\u0027: \u002742\u0027,"},{"line_number":34,"context_line":"            \u0027is_default\u0027: False,"},{"line_number":35,"context_line":"            \u0027name\u0027: \u0027foo\u0027,"},{"line_number":36,"context_line":"            \u0027id\u0027: FAKE_QOS_POLICY_ID,"},{"line_number":37,"context_line":"            \u0027shared\u0027: True,"},{"line_number":38,"context_line":"            \u0027rules\u0027: []"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    FAKE_MIN_BW_RULE_REQUEST \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_d888c872","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":9},"updated":"2019-01-11 21:18:26.000000000","message":"Response example is better taken from API example as it is complete:\n\n{\n    \"policy\": {\n        \"name\": \"10Mbit\",\n        \"description\": \"This policy limits the ports to 10Mbit max.\",\n        \"rules\": [],\n        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\",\n        \"is_default\": false,\n        \"project_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\",\n        \"revision_number\": 1,\n        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\",\n        \"created_at\": \"2018-04-03T21:26:39Z\",\n        \"updated_at\": \"2018-04-03T21:26:39Z\",\n        \"shared\": false,\n        \"tags\": [\"tag1,tag2\"]\n    }\n}","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9fd4dc56d9bc52e46d498a4cef38cc8dccf259e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    FAKE_QOS_POLICY_RESPONSE \u003d {"},{"line_number":31,"context_line":"        \u0027policy\u0027: {"},{"line_number":32,"context_line":"            \u0027description\u0027: \u0027bar\u0027,"},{"line_number":33,"context_line":"            \u0027project_id\u0027: \u002742\u0027,"},{"line_number":34,"context_line":"            \u0027is_default\u0027: False,"},{"line_number":35,"context_line":"            \u0027name\u0027: \u0027foo\u0027,"},{"line_number":36,"context_line":"            \u0027id\u0027: FAKE_QOS_POLICY_ID,"},{"line_number":37,"context_line":"            \u0027shared\u0027: True,"},{"line_number":38,"context_line":"            \u0027rules\u0027: []"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    FAKE_MIN_BW_RULE_REQUEST \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_cad1d431","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":9},"in_reply_to":"bfdaf3ff_d888c872","updated":"2019-02-05 13:14:01.000000000","message":"Done","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8a978c5ed6f9c76d8975a7d037900791fda18ad9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027direction\u0027: \u0027ingress\u0027"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    FAKE_MIN_BW_RULE_RESPONSE \u003d {"},{"line_number":49,"context_line":"        \u0027minimum_bandwidth_rule\u0027: {"},{"line_number":50,"context_line":"            \u0027id\u0027: FAKE_MIN_BW_RULE_ID,"},{"line_number":51,"context_line":"            \u0027min_kbps\u0027: 1000,"},{"line_number":52,"context_line":"            \u0027direction\u0027: \u0027ingress\u0027"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def setUp(self):"},{"line_number":57,"context_line":"        super(TestQosClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_9882404f","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":5},"updated":"2019-01-11 21:18:26.000000000","message":"Ditto:\n\n{\n    \"bandwidth_limit_rule\": {\n        \"id\": \"5f126d84-551a-4dcf-bb01-0e9c0df0c793\",\n        \"max_kbps\": 10000,\n        \"max_burst_kbps\": 0,\n        \"direction\": \"egress\"\n    }\n}","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9fd4dc56d9bc52e46d498a4cef38cc8dccf259e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027direction\u0027: \u0027ingress\u0027"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    FAKE_MIN_BW_RULE_RESPONSE \u003d {"},{"line_number":49,"context_line":"        \u0027minimum_bandwidth_rule\u0027: {"},{"line_number":50,"context_line":"            \u0027id\u0027: FAKE_MIN_BW_RULE_ID,"},{"line_number":51,"context_line":"            \u0027min_kbps\u0027: 1000,"},{"line_number":52,"context_line":"            \u0027direction\u0027: \u0027ingress\u0027"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def setUp(self):"},{"line_number":57,"context_line":"        super(TestQosClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ead61828","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":5},"in_reply_to":"bfdaf3ff_9882404f","updated":"2019-02-05 13:14:01.000000000","message":"Done in the separate test module: test_qos_minimum_bandwidth_rules_client.py","commit_id":"553ca44ff16b25f300815588c337cbedf096c31b"}]}