)]}'
{".zuul.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d3fc19a4c41ce624a729f1407485de6e21706796","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        post-config:"},{"line_number":282,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"},{"line_number":283,"context_line":"            ovs:"},{"line_number":284,"context_line":"              bridge_mappings: public:br-ex"},{"line_number":285,"context_line":"              resource_provider_bandwidths: br-ex:1000000:1000000"},{"line_number":286,"context_line":"        test-config:"},{"line_number":287,"context_line":"          $TEMPEST_CONFIG:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"bfb3d3c7_edf17696","line":284,"updated":"2019-05-31 08:04:27.000000000","message":"this is probably problem on compute-1 node. See in log http://logs.openstack.org/53/629253/25/check/tempest-slow/9917a90/compute1/logs/screen-neutron-agent.txt.gz#_May_30_10_21_27_024241 - because of that this agent is dead and then every attempt to bind port, like http://logs.openstack.org/53/629253/25/check/tempest-slow/9917a90/controller/logs/screen-q-svc.txt.gz#_May_30_10_32_12_755972 fails.\nAnd I think that reason for that is that on controller node, service is enabled as q-agt, so it\u0027s using lib/neutron-legacy from devstack but on compute it\u0027s enabled as neutron-agent, so it\u0027s using lib/neutron (please check local.conf files from both nodes.\nSo IMO, quick fix for this will be to enable q-agt service on subnodes instead of neutron-agent but proper way fix would be to check in lib/neutron why it\u0027s not creating such br-ex (lib/neutron-legacy is creating it properly).","commit_id":"6a943618bb9580885e4721762382734382df0cc1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57727f79cb9c6daacbcc557fdacb32e119528d71","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        post-config:"},{"line_number":282,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"},{"line_number":283,"context_line":"            ovs:"},{"line_number":284,"context_line":"              bridge_mappings: public:br-ex"},{"line_number":285,"context_line":"              resource_provider_bandwidths: br-ex:1000000:1000000"},{"line_number":286,"context_line":"        test-config:"},{"line_number":287,"context_line":"          $TEMPEST_CONFIG:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"bfb3d3c7_516e18c9","line":284,"in_reply_to":"bfb3d3c7_edf17696","updated":"2019-05-31 10:41:10.000000000","message":"thanks. I hope adding q-agt to devstack_services will force both controller and compute to use old neutron-legacy code, and if this solves the problem I add this check to my todo list.","commit_id":"6a943618bb9580885e4721762382734382df0cc1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36d294ba1e0a81bb208361fbfd481c4db57fbf13","unresolved":false,"context_lines":[{"line_number":276,"context_line":"      devstack_plugins:"},{"line_number":277,"context_line":"        neutron: https://opendev.org/openstack/neutron"},{"line_number":278,"context_line":"      devstack_services:"},{"line_number":279,"context_line":"        q-agt: true"},{"line_number":280,"context_line":"        neutron-placement: true"},{"line_number":281,"context_line":"        neutron-qos: true"},{"line_number":282,"context_line":"      devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_8f9bbdc7","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":19},"updated":"2019-06-05 08:13:56.000000000","message":"it is already enabled in base job.","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8aacc86dc4608346ff3d2e7f61af5b2710cbeac7","unresolved":false,"context_lines":[{"line_number":276,"context_line":"      devstack_plugins:"},{"line_number":277,"context_line":"        neutron: https://opendev.org/openstack/neutron"},{"line_number":278,"context_line":"      devstack_services:"},{"line_number":279,"context_line":"        q-agt: true"},{"line_number":280,"context_line":"        neutron-placement: true"},{"line_number":281,"context_line":"        neutron-qos: true"},{"line_number":282,"context_line":"      devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_984c619f","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":19},"in_reply_to":"9fb8cfa7_8f9bbdc7","updated":"2019-06-05 11:39:02.000000000","message":"thanks, removed","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36d294ba1e0a81bb208361fbfd481c4db57fbf13","unresolved":false,"context_lines":[{"line_number":289,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":290,"context_line":"            scenario:"},{"line_number":291,"context_line":"              qos_placement_physnet: public"},{"line_number":292,"context_line":"            compute:"},{"line_number":293,"context_line":"              max_microversion: latest"},{"line_number":294,"context_line":"            placement:"},{"line_number":295,"context_line":"              max_microversion: latest"},{"line_number":296,"context_line":"      tempest_concurrency: 2"},{"line_number":297,"context_line":"    group-vars:"},{"line_number":298,"context_line":"      # NOTE(mriedem): The ENABLE_VOLUME_MULTIATTACH variable is used on both"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_2f0e5132","line":295,"range":{"start_line":292,"start_character":0,"end_line":295,"end_character":38},"updated":"2019-06-05 08:13:56.000000000","message":"these are set by devstack per branch basis.  for exmaple, the stable branch will cap max_microversion to max available microvesion of that branch. \n\nFor master, it is always latest. But we do not have placement microvesion setting on devstack yet. I will do that.","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"38e6b3e619161ec0d062c2c3d75124eaba99ea30","unresolved":false,"context_lines":[{"line_number":289,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":290,"context_line":"            scenario:"},{"line_number":291,"context_line":"              qos_placement_physnet: public"},{"line_number":292,"context_line":"            compute:"},{"line_number":293,"context_line":"              max_microversion: latest"},{"line_number":294,"context_line":"            placement:"},{"line_number":295,"context_line":"              max_microversion: latest"},{"line_number":296,"context_line":"      tempest_concurrency: 2"},{"line_number":297,"context_line":"    group-vars:"},{"line_number":298,"context_line":"      # NOTE(mriedem): The ENABLE_VOLUME_MULTIATTACH variable is used on both"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_cf0215b5","line":295,"range":{"start_line":292,"start_character":0,"end_line":295,"end_character":38},"in_reply_to":"9fb8cfa7_2f0e5132","updated":"2019-06-05 08:27:06.000000000","message":"done in https://review.opendev.org/#/c/663270/1","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8aacc86dc4608346ff3d2e7f61af5b2710cbeac7","unresolved":false,"context_lines":[{"line_number":289,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":290,"context_line":"            scenario:"},{"line_number":291,"context_line":"              qos_placement_physnet: public"},{"line_number":292,"context_line":"            compute:"},{"line_number":293,"context_line":"              max_microversion: latest"},{"line_number":294,"context_line":"            placement:"},{"line_number":295,"context_line":"              max_microversion: latest"},{"line_number":296,"context_line":"      tempest_concurrency: 2"},{"line_number":297,"context_line":"    group-vars:"},{"line_number":298,"context_line":"      # NOTE(mriedem): The ENABLE_VOLUME_MULTIATTACH variable is used on both"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_f8547d23","line":295,"range":{"start_line":292,"start_character":0,"end_line":295,"end_character":38},"in_reply_to":"9fb8cfa7_cf0215b5","updated":"2019-06-05 11:39:02.000000000","message":"thanks I added this as dependency, just to make it clear","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36d294ba1e0a81bb208361fbfd481c4db57fbf13","unresolved":false,"context_lines":[{"line_number":299,"context_line":"      # the controller and subnode prior to Rocky so we have to make sure the"},{"line_number":300,"context_line":"      # variable is set in both locations."},{"line_number":301,"context_line":"      subnode:"},{"line_number":302,"context_line":"        devstack_services:"},{"line_number":303,"context_line":"          # Note: Copy paste from https://review.opendev.org/662480"},{"line_number":304,"context_line":"          # If that patch makes multinode setup work, this can be removed"},{"line_number":305,"context_line":"          q-agt: true"},{"line_number":306,"context_line":"        devstack_localrc:"},{"line_number":307,"context_line":"          ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_6f73e9b2","line":305,"range":{"start_line":302,"start_character":0,"end_line":305,"end_character":21},"updated":"2019-06-05 08:13:56.000000000","message":"you can remove this also as it is done in base job by https://review.opendev.org/#/c/662480","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8aacc86dc4608346ff3d2e7f61af5b2710cbeac7","unresolved":false,"context_lines":[{"line_number":299,"context_line":"      # the controller and subnode prior to Rocky so we have to make sure the"},{"line_number":300,"context_line":"      # variable is set in both locations."},{"line_number":301,"context_line":"      subnode:"},{"line_number":302,"context_line":"        devstack_services:"},{"line_number":303,"context_line":"          # Note: Copy paste from https://review.opendev.org/662480"},{"line_number":304,"context_line":"          # If that patch makes multinode setup work, this can be removed"},{"line_number":305,"context_line":"          q-agt: true"},{"line_number":306,"context_line":"        devstack_localrc:"},{"line_number":307,"context_line":"          ENABLE_VOLUME_MULTIATTACH: true"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9fb8cfa7_9831c10e","line":305,"range":{"start_line":302,"start_character":0,"end_line":305,"end_character":21},"in_reply_to":"9fb8cfa7_6f73e9b2","updated":"2019-06-05 11:39:02.000000000","message":"Done","commit_id":"497d71e18fa117c505c0df85c870fda478df0ee1"}],"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"abb8b04a728c8d73469f3e4d5fec054ef59579bc","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie274f199ce33199a6fc8c4d6846a853522a90d3a"},{"line_number":13,"context_line":"Depends-On: https://review.openstack.org/574783"},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/569459"},{"line_number":15,"context_line":"Partial-Bug: #1578989"},{"line_number":16,"context_line":"See-Also: https://review.openstack.org/502306 (nova spec)"},{"line_number":17,"context_line":"See-Also: https://review.openstack.org/508149 (neutron spec)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_037fc7ab","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":47},"updated":"2019-02-05 16:08:07.000000000","message":"Actually it will not work with this nova patch, as a new nova microversion will enable the feature.\nTODO: change this to the good patch as soon as it is public","commit_id":"319e0cd917e7a0c4eb00fa88c00665c37e7d4e9b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0dd133ace93ab8f7123b99b819030228147c552e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie274f199ce33199a6fc8c4d6846a853522a90d3a"},{"line_number":13,"context_line":"Depends-On: https://review.openstack.org/574783"},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/569459"},{"line_number":15,"context_line":"Partial-Bug: #1578989"},{"line_number":16,"context_line":"See-Also: https://review.openstack.org/502306 (nova spec)"},{"line_number":17,"context_line":"See-Also: https://review.openstack.org/508149 (neutron spec)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_f7982f1c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":47},"updated":"2019-02-06 09:06:16.000000000","message":"Actually it will not work with this nova patch, as a new nova microversion will enable the feature.\nTODO: change this to the good patch as soon as it is public","commit_id":"4079ef451216aba7c80e80621ae70cdf3626784c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f14bd5feeee0305fad1b27838c3b8310e3cbebb7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie274f199ce33199a6fc8c4d6846a853522a90d3a"},{"line_number":13,"context_line":"Depends-On: https://review.openstack.org/574783"},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/636360"},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/660924"},{"line_number":16,"context_line":"Depends-On: https://review.opendev.org/663270"},{"line_number":17,"context_line":"Partial-Bug: #1578989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"9fb8cfa7_f6af52e0","line":14,"updated":"2019-06-11 07:52:45.000000000","message":"I think you wanted make these URLs \u0027review.opendev.org/...\u0027 but both of those were already merged. So, I think there\u0027s no problem and nit picks.","commit_id":"c87a06b3c29427dc8f2513047c804e0410b4b99c"}],"tempest/config.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"5b1d49ff7ef3d3258424ddac5d9d1b0af97b9609","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"    cfg.StrOpt(\u0027qos_placement_physnet\u0027, default\u003dNone,"},{"line_number":1053,"context_line":"               help\u003d\u0027Name of the physnet for placement based minimum \u0027"},{"line_number":1054,"context_line":"                    \u0027bandwidth allocation.\u0027),"},{"line_number":1055,"context_line":"    cfg.StrOpt(\u0027provider_net_base_segm_id\u0027, default\u003d3000,"},{"line_number":1056,"context_line":"               help\u003d\u0027Base segmentation ID to create provider networks. \u0027"},{"line_number":1057,"context_line":"                    \u0027This value will be increased in case of conflict.\u0027)"},{"line_number":1058,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_8f01e33a","line":1055,"range":{"start_line":1055,"start_character":34,"end_line":1055,"end_character":38},"updated":"2019-01-31 13:47:52.000000000","message":"Avoiding abbreviations would be nicer.","commit_id":"76db46047e6db7d3a794aa1269ff8f5566dc3a29"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0a6a8542d3b7c4e50338437aecff21890c144934","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"    cfg.StrOpt(\u0027qos_placement_physnet\u0027, default\u003dNone,"},{"line_number":1053,"context_line":"               help\u003d\u0027Name of the physnet for placement based minimum \u0027"},{"line_number":1054,"context_line":"                    \u0027bandwidth allocation.\u0027),"},{"line_number":1055,"context_line":"    cfg.StrOpt(\u0027provider_net_base_segm_id\u0027, default\u003d3000,"},{"line_number":1056,"context_line":"               help\u003d\u0027Base segmentation ID to create provider networks. \u0027"},{"line_number":1057,"context_line":"                    \u0027This value will be increased in case of conflict.\u0027)"},{"line_number":1058,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_234bebb0","line":1055,"range":{"start_line":1055,"start_character":34,"end_line":1055,"end_character":38},"in_reply_to":"9fdfeff1_8f01e33a","updated":"2019-02-05 16:04:22.000000000","message":"Done","commit_id":"76db46047e6db7d3a794aa1269ff8f5566dc3a29"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"               choices\u003d(\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027),"},{"line_number":1059,"context_line":"               help\u003d\u0027The protocol used in security groups tests to check \u0027"},{"line_number":1060,"context_line":"                    \u0027connectivity.\u0027),"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    # Options for QoS bandwidth placement allocation"},{"line_number":1063,"context_line":"    cfg.StrOpt(\u0027qos_placement_physnet\u0027, default\u003dNone,"},{"line_number":1064,"context_line":"               help\u003d\u0027Name of the physnet for placement based minimum \u0027"},{"line_number":1065,"context_line":"                    \u0027bandwidth allocation.\u0027),"},{"line_number":1066,"context_line":"    cfg.StrOpt(\u0027provider_net_base_segmentation_id\u0027, default\u003d3000,"},{"line_number":1067,"context_line":"               help\u003d\u0027Base segmentation ID to create provider networks. \u0027"},{"line_number":1068,"context_line":"                    \u0027This value will be increased in case of conflict.\u0027)"},{"line_number":1069,"context_line":"]"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_4e504733","line":1068,"range":{"start_line":1061,"start_character":0,"end_line":1068,"end_character":72},"updated":"2019-06-06 16:39:24.000000000","message":"as these are placement related config, can you add those in new group \u0027placement-feature-enabled\u0027 at L399.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"               choices\u003d(\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027),"},{"line_number":1059,"context_line":"               help\u003d\u0027The protocol used in security groups tests to check \u0027"},{"line_number":1060,"context_line":"                    \u0027connectivity.\u0027),"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    # Options for QoS bandwidth placement allocation"},{"line_number":1063,"context_line":"    cfg.StrOpt(\u0027qos_placement_physnet\u0027, default\u003dNone,"},{"line_number":1064,"context_line":"               help\u003d\u0027Name of the physnet for placement based minimum \u0027"},{"line_number":1065,"context_line":"                    \u0027bandwidth allocation.\u0027),"},{"line_number":1066,"context_line":"    cfg.StrOpt(\u0027provider_net_base_segmentation_id\u0027, default\u003d3000,"},{"line_number":1067,"context_line":"               help\u003d\u0027Base segmentation ID to create provider networks. \u0027"},{"line_number":1068,"context_line":"                    \u0027This value will be increased in case of conflict.\u0027)"},{"line_number":1069,"context_line":"]"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_fd844160","line":1068,"range":{"start_line":1061,"start_character":0,"end_line":1068,"end_character":72},"in_reply_to":"9fb8cfa7_4e504733","updated":"2019-06-07 10:34:24.000000000","message":"I added to network-feature-enabled, as these are more related to network than to placement, is that ok?","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08af849652c6474b2d77cee7364c05f432be119e","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"               choices\u003d(\u0027icmp\u0027, \u0027tcp\u0027, \u0027udp\u0027),"},{"line_number":1059,"context_line":"               help\u003d\u0027The protocol used in security groups tests to check \u0027"},{"line_number":1060,"context_line":"                    \u0027connectivity.\u0027),"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    # Options for QoS bandwidth placement allocation"},{"line_number":1063,"context_line":"    cfg.StrOpt(\u0027qos_placement_physnet\u0027, default\u003dNone,"},{"line_number":1064,"context_line":"               help\u003d\u0027Name of the physnet for placement based minimum \u0027"},{"line_number":1065,"context_line":"                    \u0027bandwidth allocation.\u0027),"},{"line_number":1066,"context_line":"    cfg.StrOpt(\u0027provider_net_base_segmentation_id\u0027, default\u003d3000,"},{"line_number":1067,"context_line":"               help\u003d\u0027Base segmentation ID to create provider networks. \u0027"},{"line_number":1068,"context_line":"                    \u0027This value will be increased in case of conflict.\u0027)"},{"line_number":1069,"context_line":"]"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_1d1ef56f","line":1068,"range":{"start_line":1061,"start_character":0,"end_line":1068,"end_character":72},"in_reply_to":"9fb8cfa7_fd844160","updated":"2019-06-07 11:37:10.000000000","message":"+1","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"}],"tempest/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f14bd5feeee0305fad1b27838c3b8310e3cbebb7","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"        :param tenant_id: id of tenant to create resources in."},{"line_number":1269,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1270,"context_line":"        :param port_security_enabled: whether or not port_security is enabled"},{"line_number":1271,"context_line":"        :param: net_dict: a dict containing experimental network information in"},{"line_number":1272,"context_line":"                a form like this: {\u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":1273,"context_line":"                                   \u0027provider:physical_network\u0027: \u0027foo\u0027,"},{"line_number":1274,"context_line":"                                   \u0027provider:segmentation_id\u0027: \u002742\u0027}"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fb8cfa7_16ad46e8","line":1271,"updated":"2019-06-11 07:52:45.000000000","message":"Nit.\nI think you wanted to write::\n  :param net_dict: ...\n\n?","commit_id":"c87a06b3c29427dc8f2513047c804e0410b4b99c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ee56a133e4069c1e46f717ce56dfed4bd4913bda","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"        :param tenant_id: id of tenant to create resources in."},{"line_number":1269,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1270,"context_line":"        :param port_security_enabled: whether or not port_security is enabled"},{"line_number":1271,"context_line":"        :param: net_dict: a dict containing experimental network information in"},{"line_number":1272,"context_line":"                a form like this: {\u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":1273,"context_line":"                                   \u0027provider:physical_network\u0027: \u0027foo\u0027,"},{"line_number":1274,"context_line":"                                   \u0027provider:segmentation_id\u0027: \u002742\u0027}"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fb8cfa7_b618fa1d","line":1271,"in_reply_to":"9fb8cfa7_16ad46e8","updated":"2019-06-11 08:02:54.000000000","message":"thanks, you are right, I will upload a follow-up patch for this.","commit_id":"c87a06b3c29427dc8f2513047c804e0410b4b99c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"148fb7a67eec491f82d4b3960ed56b53e86ae23b","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"        :param tenant_id: id of tenant to create resources in."},{"line_number":1269,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1270,"context_line":"        :param port_security_enabled: whether or not port_security is enabled"},{"line_number":1271,"context_line":"        :param: net_dict: a dict containing experimental network information in"},{"line_number":1272,"context_line":"                a form like this: {\u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":1273,"context_line":"                                   \u0027provider:physical_network\u0027: \u0027foo\u0027,"},{"line_number":1274,"context_line":"                                   \u0027provider:segmentation_id\u0027: \u002742\u0027}"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fb8cfa7_20ab2e75","line":1271,"in_reply_to":"9fb8cfa7_b618fa1d","updated":"2019-06-13 13:13:41.000000000","message":"Masayuki: I pushed a patch for this, see: https://review.opendev.org/665132","commit_id":"c87a06b3c29427dc8f2513047c804e0410b4b99c"}],"tempest/scenario/test_minbw_allocation_placement.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f8d48aa718d2323d75248167cec4a22d3d60380e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            })[\u0027minimum_bandwidth_rule\u0027]"},{"line_number":86,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":87,"context_line":"                        self.qos_client.delete_qos_policy, policy[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.addCleanup("},{"line_number":89,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":90,"context_line":"            self.qos_client.delete_minimum_bandwidth_rule, policy[\u0027id\u0027],"},{"line_number":91,"context_line":"            rule[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_cee9c080","line":88,"updated":"2019-01-09 08:45:31.000000000","message":"There is no need to delete the rule if the policy is deleted first.","commit_id":"96ebf38bfb206b897c39d9b11b36c6b7e65f3e0f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"5b1d49ff7ef3d3258424ddac5d9d1b0af97b9609","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    INGRESS_DIRECTION \u003d \u0027ingress\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    SMALLEST_POSSIBLE_BW \u003d 1"},{"line_number":44,"context_line":"    # The largest int value what we expect to be rejected by placement, this"},{"line_number":45,"context_line":"    # way it\u0027s not necessary to check the resource provider inventories, see:"},{"line_number":46,"context_line":"    # https://github.com/openstack/placement/blob/master/placement/"},{"line_number":47,"context_line":"    # db/constants.py#L16"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_ef398fa3","line":44,"range":{"start_line":44,"start_character":49,"end_line":44,"end_character":57},"updated":"2019-01-31 13:47:52.000000000","message":"This is technically not true. Something like this would be:\n\nFor any realistic inventory value (that is inventory !\u003d MAX_INT) an allocation_candidate request of MAX_INT is expected to be rejected.","commit_id":"76db46047e6db7d3a794aa1269ff8f5566dc3a29"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0a6a8542d3b7c4e50338437aecff21890c144934","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    INGRESS_DIRECTION \u003d \u0027ingress\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    SMALLEST_POSSIBLE_BW \u003d 1"},{"line_number":44,"context_line":"    # The largest int value what we expect to be rejected by placement, this"},{"line_number":45,"context_line":"    # way it\u0027s not necessary to check the resource provider inventories, see:"},{"line_number":46,"context_line":"    # https://github.com/openstack/placement/blob/master/placement/"},{"line_number":47,"context_line":"    # db/constants.py#L16"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_43d94ff2","line":44,"range":{"start_line":44,"start_character":49,"end_line":44,"end_character":57},"in_reply_to":"9fdfeff1_ef398fa3","updated":"2019-02-05 16:04:22.000000000","message":"Done","commit_id":"76db46047e6db7d3a794aa1269ff8f5566dc3a29"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"98d374e917560431565b3196e2162dc936729463","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    required_extensions \u003d [\u0027port-resource-request\u0027,"},{"line_number":35,"context_line":"                           \u0027qos\u0027,"},{"line_number":36,"context_line":"                           \u0027qos-bw-minimum-ingress\u0027]"},{"line_number":37,"context_line":"    min_microversion \u003d \u00271.29\u0027"},{"line_number":38,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    INGRESS_RESOURCE_CLASS \u003d \"NET_BW_IGR_KILOBIT_PER_SEC\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_6fe616b3","line":37,"updated":"2019-02-14 06:34:48.000000000","message":"I feel it\u0027s good to add a comment about the reason for this version.","commit_id":"4079ef451216aba7c80e80621ae70cdf3626784c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"66dd8acddeea9f640c0a18e4aed0e865e98774d5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    required_extensions \u003d [\u0027port-resource-request\u0027,"},{"line_number":35,"context_line":"                           \u0027qos\u0027,"},{"line_number":36,"context_line":"                           \u0027qos-bw-minimum-ingress\u0027]"},{"line_number":37,"context_line":"    min_microversion \u003d \u00271.29\u0027"},{"line_number":38,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    INGRESS_RESOURCE_CLASS \u003d \"NET_BW_IGR_KILOBIT_PER_SEC\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_4b19a61f","line":37,"in_reply_to":"9fdfeff1_6fe616b3","updated":"2019-02-15 13:47:47.000000000","message":"I added some explanation for the placement microversion and a similar for the compute microversion as nova decided to reject boot VMs with resource_request below 2.69. (This 2.69 can change if the patch (https://review.openstack.org/636360) will merged later.","commit_id":"4079ef451216aba7c80e80621ae70cdf3626784c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e1505eb7ec7dbe34c89f584fd298113f66d28486","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            **{"},{"line_number":132,"context_line":"                \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":133,"context_line":"                \u0027shared\u0027: True,"},{"line_number":134,"context_line":"                \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":135,"context_line":"                \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":136,"context_line":"                \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_473ea029","line":134,"updated":"2019-02-27 10:11:07.000000000","message":"it may happen that vlan type_driver will not be available. In such case You should use flat network or maybe skip test if vlan is really needed for test.","commit_id":"46a7d35e397e4edb467feb7e5f1899b87dd38bfb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"92f0ec3fdcf49ae1a88945dbb179ed23f2709725","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            **{"},{"line_number":132,"context_line":"                \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":133,"context_line":"                \u0027shared\u0027: True,"},{"line_number":134,"context_line":"                \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":135,"context_line":"                \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":136,"context_line":"                \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_524080a2","line":134,"in_reply_to":"9fdfeff1_25dcaf72","updated":"2019-02-28 08:58:01.000000000","message":"Hmm, so maybe You can do it in try...except... block, catch error and if it\u0027s \"missing type driver\" error than just skip test instead of failure.","commit_id":"46a7d35e397e4edb467feb7e5f1899b87dd38bfb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8940cbdd64e150d7644ac7e24e56622b7f6b1fb5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            **{"},{"line_number":132,"context_line":"                \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":133,"context_line":"                \u0027shared\u0027: True,"},{"line_number":134,"context_line":"                \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":135,"context_line":"                \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":136,"context_line":"                \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_a583bf55","line":134,"in_reply_to":"9fdfeff1_473ea029","updated":"2019-02-27 14:42:57.000000000","message":"Is there a way to know that VLAN type driver is enabled from tempest?","commit_id":"46a7d35e397e4edb467feb7e5f1899b87dd38bfb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"add226aa74d3e5e8706502c7aba34d234c59a51e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            **{"},{"line_number":132,"context_line":"                \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":133,"context_line":"                \u0027shared\u0027: True,"},{"line_number":134,"context_line":"                \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":135,"context_line":"                \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":136,"context_line":"                \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d5ae957f","line":134,"in_reply_to":"9fdfeff1_524080a2","updated":"2019-02-28 12:46:47.000000000","message":"good idea, I used the http response message, as it is perfect I think to use as skip reason (i.e.: \"Invalid input for operation: network_type value \u0027vlan\u0027 not supported.\")\nDo you think that can work?","commit_id":"46a7d35e397e4edb467feb7e5f1899b87dd38bfb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"167f35dddaf40d1117aa7d10288b5a21b8b83990","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            **{"},{"line_number":132,"context_line":"                \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":133,"context_line":"                \u0027shared\u0027: True,"},{"line_number":134,"context_line":"                \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":135,"context_line":"                \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":136,"context_line":"                \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_25dcaf72","line":134,"in_reply_to":"9fdfeff1_a583bf55","updated":"2019-02-27 14:44:27.000000000","message":"As I see in neutron-tempest-plugin available_type_drivers config option is there, but nothing for tempest","commit_id":"46a7d35e397e4edb467feb7e5f1899b87dd38bfb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b0b7b183b60ed01ddce0d0dae9eb8defa34212da","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            **{"},{"line_number":132,"context_line":"                \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":133,"context_line":"                \u0027shared\u0027: True,"},{"line_number":134,"context_line":"                \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":135,"context_line":"                \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":136,"context_line":"                \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_08d4041f","line":134,"in_reply_to":"9fdfeff1_d5ae957f","updated":"2019-02-28 13:23:11.000000000","message":"yes, I think that this is good solution and should be better than failing test :) Thx","commit_id":"46a7d35e397e4edb467feb7e5f1899b87dd38bfb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1faf311eefdb36557c840c707a02c665a3201d06","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @decorators.idempotent_id(\u002778625d92-212c-400e-8695-dd51706858b8\u0027)"},{"line_number":191,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":192,"context_line":"    def test_qos_min_bw_allocation_basic(self):"},{"line_number":193,"context_line":"        \"\"\"\"Basic scenario with QoS min bw allocation in placement."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        Steps:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5fc1f717_c5c827a9","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":40},"updated":"2019-04-10 14:39:13.000000000","message":"How long does this test take to run? I\u0027m guessing it should be marked as \u0027slow\u0027.\n\nI don\u0027t even see it run here:\n\nhttp://logs.openstack.org/53/629253/13/check/tempest-full-py3/73e115a/job-output.txt.gz","commit_id":"a29cbb08fe628a6ec6c32bc75c9517495c5979b5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"948398874cbe28d1426e2cf7155fbeeae022411c","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @decorators.idempotent_id(\u002778625d92-212c-400e-8695-dd51706858b8\u0027)"},{"line_number":191,"context_line":"    @utils.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":192,"context_line":"    def test_qos_min_bw_allocation_basic(self):"},{"line_number":193,"context_line":"        \"\"\"\"Basic scenario with QoS min bw allocation in placement."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        Steps:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fce034c_b8662751","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":40},"in_reply_to":"5fc1f717_c5c827a9","updated":"2019-04-11 19:29:23.000000000","message":"I just executed in my local env (bionic, 8Gib, 4 vCPU) and it was ~1min. I suppose this slow mark is not that strict line, but of course I can add the slow decorator.\nTo make it run, I have to add I suppose qos_placement_physnet to scenario config group, for the slow job.\nDo you know which physnet can I use in zuul jobs?","commit_id":"a29cbb08fe628a6ec6c32bc75c9517495c5979b5"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e914a79180acd0006f1b0be1684500ab6353c7fe","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    INGRESS_DIRECTION \u003d \u0027ingress\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SMALLEST_POSSIBLE_BW \u003d 1"},{"line_number":57,"context_line":"    # For any ralistic inventory value (that is inventory !\u003d MAX_INT) an"},{"line_number":58,"context_line":"    # allocation candidate request of MAX_INT is expected to be rejected, see:"},{"line_number":59,"context_line":"    # https://github.com/openstack/placement/blob/master/placement/"},{"line_number":60,"context_line":"    # db/constants.py#L16"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fce034c_61b8d975","line":57,"range":{"start_line":57,"start_character":14,"end_line":57,"end_character":22},"updated":"2019-04-15 16:36:00.000000000","message":"nit: realistic","commit_id":"c85492e88b41dbf3a8fb96fb699c1756115bd57a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"373370fb2de52545ae50dc68bf3da832fcbd32d6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    INGRESS_DIRECTION \u003d \u0027ingress\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    SMALLEST_POSSIBLE_BW \u003d 1"},{"line_number":57,"context_line":"    # For any ralistic inventory value (that is inventory !\u003d MAX_INT) an"},{"line_number":58,"context_line":"    # allocation candidate request of MAX_INT is expected to be rejected, see:"},{"line_number":59,"context_line":"    # https://github.com/openstack/placement/blob/master/placement/"},{"line_number":60,"context_line":"    # db/constants.py#L16"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fce034c_5dcfb2af","line":57,"range":{"start_line":57,"start_character":14,"end_line":57,"end_character":22},"in_reply_to":"3fce034c_61b8d975","updated":"2019-04-16 08:00:56.000000000","message":"Done","commit_id":"c85492e88b41dbf3a8fb96fb699c1756115bd57a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c98a04009f473715f393ed0e1943d1206abc52ed","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":93,"context_line":"                cls.compute_min_microversion,"},{"line_number":94,"context_line":"                CONF.compute.min_microversion))"},{"line_number":95,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d cls.compute_req_microversion"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _create_policy_and_min_bw_rule(self, name_prefix, min_kbps):"},{"line_number":98,"context_line":"        policy \u003d self.qos_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":27,"id":"9fb8cfa7_7b3bbe37","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":79},"updated":"2019-06-04 12:33:17.000000000","message":"this is the problem which is causing the other tests to use microversion 2.72 and failure. \n\nWe need to use the fixture to set the microversion on service client which will reset it once test is completed. \n\nAlso these bits can be taken care in base class so that we do not need to repeat the microversion selection etc steps. \n\nI will add the microvesion support in base class and then you can just add the tests microversion.","commit_id":"65c8051dd9e5edfc05a4d971179c29929e230218"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1dafaf486243324f0bdf4fd095b1afa129abc71e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def resource_setup(cls):"},{"line_number":83,"context_line":"        super(MinBwAllocationPlacementTest, cls).resource_setup()"},{"line_number":84,"context_line":"        cls.placement_req_microversion \u003d ("},{"line_number":85,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":86,"context_line":"                cls.placement_min_microversion,"},{"line_number":87,"context_line":"                CONF.placement.min_microversion))"},{"line_number":88,"context_line":"        base_placement_client.PLACEMENT_MICROVERSION \u003d \\"},{"line_number":89,"context_line":"            cls.placement_req_microversion"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        cls.compute_req_microversion \u003d ("},{"line_number":92,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":93,"context_line":"                cls.compute_min_microversion,"},{"line_number":94,"context_line":"                CONF.compute.min_microversion))"},{"line_number":95,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d cls.compute_req_microversion"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _create_policy_and_min_bw_rule(self, name_prefix, min_kbps):"},{"line_number":98,"context_line":"        policy \u003d self.qos_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":27,"id":"9fb8cfa7_f6c02553","line":95,"range":{"start_line":84,"start_character":0,"end_line":95,"end_character":79},"updated":"2019-06-04 13:13:30.000000000","message":"you can remove all these bits. These has been taken care in scenario base class - https://review.opendev.org/#/c/663025/1\n\nIf you rebase your patch on top of 663025 then L45- L51 will do all work for this test.","commit_id":"65c8051dd9e5edfc05a4d971179c29929e230218"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36d294ba1e0a81bb208361fbfd481c4db57fbf13","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def resource_setup(cls):"},{"line_number":83,"context_line":"        super(MinBwAllocationPlacementTest, cls).resource_setup()"},{"line_number":84,"context_line":"        cls.placement_req_microversion \u003d ("},{"line_number":85,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":86,"context_line":"                cls.placement_min_microversion,"},{"line_number":87,"context_line":"                CONF.placement.min_microversion))"},{"line_number":88,"context_line":"        base_placement_client.PLACEMENT_MICROVERSION \u003d \\"},{"line_number":89,"context_line":"            cls.placement_req_microversion"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        cls.compute_req_microversion \u003d ("},{"line_number":92,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":93,"context_line":"                cls.compute_min_microversion,"},{"line_number":94,"context_line":"                CONF.compute.min_microversion))"},{"line_number":95,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d cls.compute_req_microversion"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _create_policy_and_min_bw_rule(self, name_prefix, min_kbps):"},{"line_number":98,"context_line":"        policy \u003d self.qos_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":27,"id":"9fb8cfa7_af50010c","line":95,"range":{"start_line":84,"start_character":0,"end_line":95,"end_character":79},"in_reply_to":"9fb8cfa7_5beef522","updated":"2019-06-05 08:13:56.000000000","message":"Yeah, you do not need that service after slaweq patch. I have approved that patch.","commit_id":"65c8051dd9e5edfc05a4d971179c29929e230218"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d5991354a57327eeec6ed922daee084900f8b859","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def resource_setup(cls):"},{"line_number":83,"context_line":"        super(MinBwAllocationPlacementTest, cls).resource_setup()"},{"line_number":84,"context_line":"        cls.placement_req_microversion \u003d ("},{"line_number":85,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":86,"context_line":"                cls.placement_min_microversion,"},{"line_number":87,"context_line":"                CONF.placement.min_microversion))"},{"line_number":88,"context_line":"        base_placement_client.PLACEMENT_MICROVERSION \u003d \\"},{"line_number":89,"context_line":"            cls.placement_req_microversion"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        cls.compute_req_microversion \u003d ("},{"line_number":92,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":93,"context_line":"                cls.compute_min_microversion,"},{"line_number":94,"context_line":"                CONF.compute.min_microversion))"},{"line_number":95,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d cls.compute_req_microversion"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _create_policy_and_min_bw_rule(self, name_prefix, min_kbps):"},{"line_number":98,"context_line":"        policy \u003d self.qos_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":27,"id":"9fb8cfa7_5beef522","line":95,"range":{"start_line":84,"start_character":0,"end_line":95,"end_character":79},"in_reply_to":"9fb8cfa7_db3d05bc","updated":"2019-06-04 15:41:53.000000000","message":"GMann: if you would be so kind to check the .zuul.yaml (https://review.opendev.org/#/c/629253/28/.zuul.yaml).\n\nI added now \ndevstack_services:\n  q-agt: true\nBut I am not sure if that is needed when slaweq\u0027s patch is on devsatck master for legacy q-agt handling (see: https://review.opendev.org/662480)","commit_id":"65c8051dd9e5edfc05a4d971179c29929e230218"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ae7ff1e7fa91d9e97b6dbe6a28a859bcdbca256a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @classmethod"},{"line_number":82,"context_line":"    def resource_setup(cls):"},{"line_number":83,"context_line":"        super(MinBwAllocationPlacementTest, cls).resource_setup()"},{"line_number":84,"context_line":"        cls.placement_req_microversion \u003d ("},{"line_number":85,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":86,"context_line":"                cls.placement_min_microversion,"},{"line_number":87,"context_line":"                CONF.placement.min_microversion))"},{"line_number":88,"context_line":"        base_placement_client.PLACEMENT_MICROVERSION \u003d \\"},{"line_number":89,"context_line":"            cls.placement_req_microversion"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        cls.compute_req_microversion \u003d ("},{"line_number":92,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":93,"context_line":"                cls.compute_min_microversion,"},{"line_number":94,"context_line":"                CONF.compute.min_microversion))"},{"line_number":95,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d cls.compute_req_microversion"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _create_policy_and_min_bw_rule(self, name_prefix, min_kbps):"},{"line_number":98,"context_line":"        policy \u003d self.qos_client.create_qos_policy("}],"source_content_type":"text/x-python","patch_set":27,"id":"9fb8cfa7_db3d05bc","line":95,"range":{"start_line":84,"start_character":0,"end_line":95,"end_character":79},"in_reply_to":"9fb8cfa7_f6c02553","updated":"2019-06-04 15:37:39.000000000","message":"Thanks GMann for the quick help.","commit_id":"65c8051dd9e5edfc05a4d971179c29929e230218"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest.common import utils"},{"line_number":17,"context_line":"from tempest.common import waiters"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_0e3fafd6","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":32},"updated":"2019-06-06 16:39:24.000000000","message":"you need to separate these import by new line so that tempest import and third-party import order can be maintained.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest.common import utils"},{"line_number":17,"context_line":"from tempest.common import waiters"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_1d88356f","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":32},"in_reply_to":"9fb8cfa7_0e3fafd6","updated":"2019-06-07 10:34:24.000000000","message":"Done","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class MinBwAllocationPlacementTest(manager.NetworkScenarioTest):"},{"line_number":31,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":32,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":33,"context_line":"    required_extensions \u003d [\u0027port-resource-request\u0027,"},{"line_number":34,"context_line":"                           \u0027qos\u0027,"},{"line_number":35,"context_line":"                           \u0027qos-bw-minimum-ingress\u0027]"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_b19844c0","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":34},"updated":"2019-06-06 16:39:24.000000000","message":"you do not need to set it false. If any test wants tenant isolation then they can set it to True otherwise tenant isolation is not considered.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class MinBwAllocationPlacementTest(manager.NetworkScenarioTest):"},{"line_number":31,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":32,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":33,"context_line":"    required_extensions \u003d [\u0027port-resource-request\u0027,"},{"line_number":34,"context_line":"                           \u0027qos\u0027,"},{"line_number":35,"context_line":"                           \u0027qos-bw-minimum-ingress\u0027]"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_bd7ec968","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":34},"in_reply_to":"9fb8cfa7_b19844c0","updated":"2019-06-07 10:34:24.000000000","message":"Done","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def setup_clients(cls):"},{"line_number":62,"context_line":"        super(MinBwAllocationPlacementTest, cls).setup_clients()"},{"line_number":63,"context_line":"        cls.placement_client \u003d cls.os_admin.placement_client"},{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_11eef087","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":60},"updated":"2019-06-06 16:39:24.000000000","message":"does this need to be admin client?  you can create os_primary.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def setup_clients(cls):"},{"line_number":62,"context_line":"        super(MinBwAllocationPlacementTest, cls).setup_clients()"},{"line_number":63,"context_line":"        cls.placement_client \u003d cls.os_admin.placement_client"},{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_5de22d31","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":60},"in_reply_to":"9fb8cfa7_11eef087","updated":"2019-06-07 10:34:24.000000000","message":"Yes, I need admin api:\nhttps://opendev.org/openstack/placement/src/branch/master/placement/policies/allocation_candidate.py#L24-L25\n and\nhttps://opendev.org/openstack/placement/src/branch/master/placement/policies/allocation.py#L42-L43","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08af849652c6474b2d77cee7364c05f432be119e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def setup_clients(cls):"},{"line_number":62,"context_line":"        super(MinBwAllocationPlacementTest, cls).setup_clients()"},{"line_number":63,"context_line":"        cls.placement_client \u003d cls.os_admin.placement_client"},{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_a00ea22f","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":60},"in_reply_to":"9fb8cfa7_5de22d31","updated":"2019-06-07 11:37:10.000000000","message":"I see, thanks","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def setup_clients(cls):"},{"line_number":62,"context_line":"        super(MinBwAllocationPlacementTest, cls).setup_clients()"},{"line_number":63,"context_line":"        cls.placement_client \u003d cls.os_admin.placement_client"},{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"},{"line_number":67,"context_line":"        cls.qos_client \u003d cls.os_admin.qos_client"},{"line_number":68,"context_line":"        cls.qos_min_bw_client \u003d cls.os_admin.qos_min_bw_client"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_7122cc02","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":56},"updated":"2019-06-06 16:39:24.000000000","message":"these does not need to be created these alias and these does not need to be admin client. You should be able to use class var defined in parent class - https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/manager.py#L94","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def setup_clients(cls):"},{"line_number":62,"context_line":"        super(MinBwAllocationPlacementTest, cls).setup_clients()"},{"line_number":63,"context_line":"        cls.placement_client \u003d cls.os_admin.placement_client"},{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"},{"line_number":67,"context_line":"        cls.qos_client \u003d cls.os_admin.qos_client"},{"line_number":68,"context_line":"        cls.qos_min_bw_client \u003d cls.os_admin.qos_min_bw_client"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_1dd6f550","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":56},"in_reply_to":"9fb8cfa7_7122cc02","updated":"2019-06-07 10:34:24.000000000","message":"To create provider network I need admin credentials, and even if I create it as shared than I need admin routers\u0027 client.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"},{"line_number":67,"context_line":"        cls.qos_client \u003d cls.os_admin.qos_client"},{"line_number":68,"context_line":"        cls.qos_min_bw_client \u003d cls.os_admin.qos_min_bw_client"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_f1d1dcce","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":62},"updated":"2019-06-06 16:39:24.000000000","message":"are these admin only operation? as per doc you can use os_primary cred for these.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        cls.servers_client \u003d cls.os_primary.servers_client"},{"line_number":65,"context_line":"        cls.networks_client \u003d cls.os_admin.networks_client"},{"line_number":66,"context_line":"        cls.subnets_client \u003d cls.os_admin.subnets_client"},{"line_number":67,"context_line":"        cls.qos_client \u003d cls.os_admin.qos_client"},{"line_number":68,"context_line":"        cls.qos_min_bw_client \u003d cls.os_admin.qos_min_bw_client"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"},{"line_number":71,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_dd44dd1d","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":62},"in_reply_to":"9fb8cfa7_f1d1dcce","updated":"2019-06-07 10:34:24.000000000","message":"To create policy and rules I need admin creds:\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/conf/policies/qos.py#L35-L36\n\nand\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/conf/policies/qos.py#L205-L206","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                \u0027min_kbps\u0027: min_kbps,"},{"line_number":86,"context_line":"                \u0027direction\u0027: self.INGRESS_DIRECTION"},{"line_number":87,"context_line":"            })[\u0027minimum_bandwidth_rule\u0027]"},{"line_number":88,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":89,"context_line":"                        self.qos_client.delete_qos_policy, policy[\u0027id\u0027])"},{"line_number":90,"context_line":"        self.addCleanup("},{"line_number":91,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":92,"context_line":"            self.qos_min_bw_client.delete_minimum_bandwidth_rule, policy[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_d1adb831","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":72},"updated":"2019-06-06 16:39:24.000000000","message":"can you add this before L82 right after the policy is created?","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                \u0027min_kbps\u0027: min_kbps,"},{"line_number":86,"context_line":"                \u0027direction\u0027: self.INGRESS_DIRECTION"},{"line_number":87,"context_line":"            })[\u0027minimum_bandwidth_rule\u0027]"},{"line_number":88,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":89,"context_line":"                        self.qos_client.delete_qos_policy, policy[\u0027id\u0027])"},{"line_number":90,"context_line":"        self.addCleanup("},{"line_number":91,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":92,"context_line":"            self.qos_min_bw_client.delete_minimum_bandwidth_rule, policy[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_3d55f9c6","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":72},"in_reply_to":"9fb8cfa7_d1adb831","updated":"2019-06-07 10:34:24.000000000","message":"Done","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # method, see: https://review.openstack.org/#/c/598423/16/"},{"line_number":111,"context_line":"        # neutron_tempest_plugin/api/base.py"},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            self.prov_network \u003d self.networks_client.create_network("},{"line_number":114,"context_line":"                **{"},{"line_number":115,"context_line":"                    \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":116,"context_line":"                    \u0027shared\u0027: True,"},{"line_number":117,"context_line":"                    \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":118,"context_line":"                    \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":119,"context_line":"                    \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":120,"context_line":"                }"},{"line_number":121,"context_line":"            )[\u0027network\u0027]"},{"line_number":122,"context_line":"        except lib_exceptions.BadRequest as e:"},{"line_number":123,"context_line":"            self.skipTest(e.resp_body[\u0027message\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":126,"context_line":"                        self.networks_client.delete_network,"},{"line_number":127,"context_line":"                        self.prov_network[\u0027id\u0027])"},{"line_number":128,"context_line":"        self.create_subnet(network\u003dself.prov_network,"},{"line_number":129,"context_line":"                           subnets_client\u003dself.subnets_client,"},{"line_number":130,"context_line":"                           namestart\u003d\u0027prov-subnet\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_91a74050","line":127,"range":{"start_line":113,"start_character":0,"end_line":127,"end_character":48},"updated":"2019-06-06 16:39:24.000000000","message":"we can use the parent class method to create a network here.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # method, see: https://review.openstack.org/#/c/598423/16/"},{"line_number":111,"context_line":"        # neutron_tempest_plugin/api/base.py"},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            self.prov_network \u003d self.networks_client.create_network("},{"line_number":114,"context_line":"                **{"},{"line_number":115,"context_line":"                    \u0027name\u0027: data_utils.rand_name(\u0027prov-network\u0027),"},{"line_number":116,"context_line":"                    \u0027shared\u0027: True,"},{"line_number":117,"context_line":"                    \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":118,"context_line":"                    \u0027provider:physical_network\u0027: physnet_name,"},{"line_number":119,"context_line":"                    \u0027provider:segmentation_id\u0027: base_segm"},{"line_number":120,"context_line":"                }"},{"line_number":121,"context_line":"            )[\u0027network\u0027]"},{"line_number":122,"context_line":"        except lib_exceptions.BadRequest as e:"},{"line_number":123,"context_line":"            self.skipTest(e.resp_body[\u0027message\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":126,"context_line":"                        self.networks_client.delete_network,"},{"line_number":127,"context_line":"                        self.prov_network[\u0027id\u0027])"},{"line_number":128,"context_line":"        self.create_subnet(network\u003dself.prov_network,"},{"line_number":129,"context_line":"                           subnets_client\u003dself.subnets_client,"},{"line_number":130,"context_line":"                           namestart\u003d\u0027prov-subnet\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_5d50edd4","line":127,"range":{"start_line":113,"start_character":0,"end_line":127,"end_character":48},"in_reply_to":"9fb8cfa7_91a74050","updated":"2019-06-07 10:34:24.000000000","message":"I started to use that, and added an extra param net_dict to make possible creating shared provider network, please check that.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            self.fail(\u0027For %s:%s there should be no available candidate!\u0027 %"},{"line_number":149,"context_line":"                      (self.INGRESS_RESOURCE_CLASS, self.PLACEMENT_MAX_INT))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def create_server(self, networks):"},{"line_number":152,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":153,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        server \u003d self.servers_client.create_server("},{"line_number":156,"context_line":"            name\u003ddata_utils.rand_name(\u0027server-test\u0027),"},{"line_number":157,"context_line":"            flavorRef\u003dflavor_ref,"},{"line_number":158,"context_line":"            imageRef\u003dimage_ref,"},{"line_number":159,"context_line":"            networks\u003dnetworks,"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":163,"context_line":"                        waiters.wait_for_server_termination,"},{"line_number":164,"context_line":"                        self.servers_client,"},{"line_number":165,"context_line":"                        server[\u0027server\u0027][\u0027id\u0027])"},{"line_number":166,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":167,"context_line":"                        self.servers_client.delete_server,"},{"line_number":168,"context_line":"                        server[\u0027server\u0027][\u0027id\u0027])"},{"line_number":169,"context_line":"        return server"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @decorators.idempotent_id(\u002778625d92-212c-400e-8695-dd51706858b8\u0027)"},{"line_number":172,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_312f7440","line":169,"range":{"start_line":151,"start_character":0,"end_line":169,"end_character":21},"updated":"2019-06-06 16:39:24.000000000","message":"you do not need to create this method, base class mehtod can be used[1]\n\n[1] https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/manager.py#L166","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            self.fail(\u0027For %s:%s there should be no available candidate!\u0027 %"},{"line_number":149,"context_line":"                      (self.INGRESS_RESOURCE_CLASS, self.PLACEMENT_MAX_INT))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def create_server(self, networks):"},{"line_number":152,"context_line":"        flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":153,"context_line":"        image_ref \u003d CONF.compute.image_ref"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        server \u003d self.servers_client.create_server("},{"line_number":156,"context_line":"            name\u003ddata_utils.rand_name(\u0027server-test\u0027),"},{"line_number":157,"context_line":"            flavorRef\u003dflavor_ref,"},{"line_number":158,"context_line":"            imageRef\u003dimage_ref,"},{"line_number":159,"context_line":"            networks\u003dnetworks,"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":163,"context_line":"                        waiters.wait_for_server_termination,"},{"line_number":164,"context_line":"                        self.servers_client,"},{"line_number":165,"context_line":"                        server[\u0027server\u0027][\u0027id\u0027])"},{"line_number":166,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":167,"context_line":"                        self.servers_client.delete_server,"},{"line_number":168,"context_line":"                        server[\u0027server\u0027][\u0027id\u0027])"},{"line_number":169,"context_line":"        return server"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @decorators.idempotent_id(\u002778625d92-212c-400e-8695-dd51706858b8\u0027)"},{"line_number":172,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_fd60c1a7","line":169,"range":{"start_line":151,"start_character":0,"end_line":169,"end_character":21},"in_reply_to":"9fb8cfa7_312f7440","updated":"2019-06-07 10:34:24.000000000","message":"Done","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        server1 \u003d self.create_server("},{"line_number":202,"context_line":"            networks\u003d[{\u0027port\u0027: valid_port[\u0027id\u0027]}])[\u0027server\u0027]"},{"line_number":203,"context_line":"        waiters.wait_for_server_status(self.os_primary.servers_client,"},{"line_number":204,"context_line":"                                       server1[\u0027id\u0027],"},{"line_number":205,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":206,"context_line":"        allocations \u003d self.placement_client.list_allocations(server1[\u0027id\u0027])"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertGreater(len(allocations[\u0027allocations\u0027]), 0)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_71816c8f","line":205,"range":{"start_line":203,"start_character":0,"end_line":205,"end_character":48},"updated":"2019-06-06 16:39:24.000000000","message":"this can be taken care in base method if you use that for creating the server.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        server1 \u003d self.create_server("},{"line_number":202,"context_line":"            networks\u003d[{\u0027port\u0027: valid_port[\u0027id\u0027]}])[\u0027server\u0027]"},{"line_number":203,"context_line":"        waiters.wait_for_server_status(self.os_primary.servers_client,"},{"line_number":204,"context_line":"                                       server1[\u0027id\u0027],"},{"line_number":205,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":206,"context_line":"        allocations \u003d self.placement_client.list_allocations(server1[\u0027id\u0027])"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertGreater(len(allocations[\u0027allocations\u0027]), 0)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_3d6e5995","line":205,"range":{"start_line":203,"start_character":0,"end_line":205,"end_character":48},"in_reply_to":"9fb8cfa7_71816c8f","updated":"2019-06-07 10:34:24.000000000","message":"Done","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ca166110ab112f75314abd169f65c958d7d4fef","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        allocations \u003d self.placement_client.list_allocations(server2[\u0027id\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.assertEqual(0, len(allocations[\u0027allocations\u0027]))"},{"line_number":227,"context_line":"        server2 \u003d self.servers_client.show_server(server2[\u0027id\u0027])"},{"line_number":228,"context_line":"        self.assertIn(\u0027fault\u0027, server2[\u0027server\u0027])"},{"line_number":229,"context_line":"        self.assertIn(\u0027No valid host\u0027, server2[\u0027server\u0027][\u0027fault\u0027][\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_11e110ff","line":227,"range":{"start_line":227,"start_character":18,"end_line":227,"end_character":37},"updated":"2019-06-06 16:39:24.000000000","message":"you can use self.os_primary.servers_client and then do not need to create self.servers_client alias of admin client.","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0888a0275fa66243a207138a4f57b2fe127812b6","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        allocations \u003d self.placement_client.list_allocations(server2[\u0027id\u0027])"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.assertEqual(0, len(allocations[\u0027allocations\u0027]))"},{"line_number":227,"context_line":"        server2 \u003d self.servers_client.show_server(server2[\u0027id\u0027])"},{"line_number":228,"context_line":"        self.assertIn(\u0027fault\u0027, server2[\u0027server\u0027])"},{"line_number":229,"context_line":"        self.assertIn(\u0027No valid host\u0027, server2[\u0027server\u0027][\u0027fault\u0027][\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"9fb8cfa7_9d6f4591","line":227,"range":{"start_line":227,"start_character":18,"end_line":227,"end_character":37},"in_reply_to":"9fb8cfa7_11e110ff","updated":"2019-06-07 10:34:24.000000000","message":"Done","commit_id":"af7ef61a0238a57ea887a8879e92c0ec1c0707e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08af849652c6474b2d77cee7364c05f432be119e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        server1 \u003d self.create_server("},{"line_number":172,"context_line":"            flavor\u003dflavor_ref, image_id\u003dimage_ref,"},{"line_number":173,"context_line":"            networks\u003d[{\u0027port\u0027: valid_port[\u0027id\u0027]}])"},{"line_number":174,"context_line":"        waiters.wait_for_server_status(self.os_primary.servers_client,"},{"line_number":175,"context_line":"                                       server1[\u0027id\u0027],"},{"line_number":176,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":177,"context_line":"        allocations \u003d self.placement_client.list_allocations(server1[\u0027id\u0027])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.assertGreater(len(allocations[\u0027allocations\u0027]), 0)"}],"source_content_type":"text/x-python","patch_set":30,"id":"9fb8cfa7_60466a52","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":48},"updated":"2019-06-07 11:37:10.000000000","message":"you can remove this as base class mehtod wait for server to be active.","commit_id":"32dc495969007acac1b1d78fc601ad53698471ca"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"636b8368612e6f474bc1ad1f146af07a080df920","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        server1 \u003d self.create_server("},{"line_number":172,"context_line":"            flavor\u003dflavor_ref, image_id\u003dimage_ref,"},{"line_number":173,"context_line":"            networks\u003d[{\u0027port\u0027: valid_port[\u0027id\u0027]}])"},{"line_number":174,"context_line":"        waiters.wait_for_server_status(self.os_primary.servers_client,"},{"line_number":175,"context_line":"                                       server1[\u0027id\u0027],"},{"line_number":176,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":177,"context_line":"        allocations \u003d self.placement_client.list_allocations(server1[\u0027id\u0027])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.assertGreater(len(allocations[\u0027allocations\u0027]), 0)"}],"source_content_type":"text/x-python","patch_set":30,"id":"9fb8cfa7_2332bca8","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":48},"in_reply_to":"9fb8cfa7_60466a52","updated":"2019-06-07 12:42:53.000000000","message":"True, thanks","commit_id":"32dc495969007acac1b1d78fc601ad53698471ca"}]}