)]}'
{"tempest/api/identity/admin/v3/test_roles.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"90ddaf577fbf8f586a49e979116a87ca25ab1511","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            domain_id\u003dcls.domain[\u0027id\u0027])[\u0027group\u0027]"},{"line_number":49,"context_line":"        cls.addClassResourceCleanup(cls.groups_client.delete_group,"},{"line_number":50,"context_line":"                                    cls.group_body[\u0027id\u0027])"},{"line_number":51,"context_line":"        cls.user_body \u003d cls.users_client.create_user("},{"line_number":52,"context_line":"            name\u003du_name, description\u003du_desc, password\u003dcls.u_password,"},{"line_number":53,"context_line":"            email\u003du_email, project_id\u003dcls.project[\u0027id\u0027],"},{"line_number":54,"context_line":"            domain_id\u003dcls.domain[\u0027id\u0027])[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2504af49","side":"PARENT","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":53},"updated":"2019-02-14 08:53:54.000000000","message":"maybe we can add a check before this, \n\"if not CONF.identity_feature_enabled.immutable_user_source:\",\nso we can avoid creating users in each testcase that requires a new user.","commit_id":"7ece7d2253e57774f2cb458d9a2776bf343314ed"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"755df58a90398cba883632b3d4eeceb73d5f041e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        cls.addClassResourceCleanup(cls.roles_client.delete_role,"},{"line_number":58,"context_line":"                                    cls.role[\u0027id\u0027])"},{"line_number":59,"context_line":"        if not CONF.identity_feature_enabled.immutable_user_source:"},{"line_number":60,"context_line":"            cls.user_body \u003d cls.users_client.create_user(name\u003dcls.u_name,"},{"line_number":61,"context_line":"                                                         description\u003dcls.u_desc,"},{"line_number":62,"context_line":"                                                         password\u003dcls.u_password,"},{"line_number":63,"context_line":"                                                         email\u003dcls.u_email,"},{"line_number":64,"context_line":"                                                         project_id\u003dcls.project[\u0027id\u0027],"},{"line_number":65,"context_line":"                                                         domain_id\u003dcls.domain[\u0027id\u0027]"},{"line_number":66,"context_line":"                                                        )[\u0027user\u0027]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.attr(type\u003d\u0027smoke\u0027)"},{"line_number":69,"context_line":"    @decorators.idempotent_id(\u002718afc6c0-46cf-4911-824e-9989cc056c3a\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_cce33e34","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":65},"updated":"2019-02-19 02:33:19.000000000","message":"\"cls.addClassResourceCleanup(cls.users_client.delete_user\" is missing","commit_id":"7a77de1fc60a7b614e0df108eda8d66b5bdc0c03"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"755df58a90398cba883632b3d4eeceb73d5f041e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                      \u0027immutable user source and solely \u0027"},{"line_number":96,"context_line":"                      \u0027provides read-only access to users.\u0027)"},{"line_number":97,"context_line":"    def test_grant_list_revoke_role_to_user_on_project(self):"},{"line_number":98,"context_line":"        self.user_body \u003d self.users_client.create_user("},{"line_number":99,"context_line":"            name\u003dself.u_name, description\u003dself.u_desc,"},{"line_number":100,"context_line":"            password\u003dself.u_password,"},{"line_number":101,"context_line":"            email\u003dself.u_email, project_id\u003dself.project[\u0027id\u0027],"},{"line_number":102,"context_line":"            domain_id\u003dself.domain[\u0027id\u0027])[\u0027user\u0027]"},{"line_number":103,"context_line":"        self.addCleanup(self.users_client.delete_user,"},{"line_number":104,"context_line":"                        self.user_body[\u0027id\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        self.roles_client.create_user_role_on_project(self.project[\u0027id\u0027],"},{"line_number":107,"context_line":"                                                      self.user_body[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_6cced2b5","line":104,"range":{"start_line":98,"start_character":0,"end_line":104,"end_character":45},"updated":"2019-02-19 02:33:19.000000000","message":"These can be removed. So as the other occurrencies","commit_id":"7a77de1fc60a7b614e0df108eda8d66b5bdc0c03"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"221c1fb02886f4b396cf0ed1002a2faf0841999b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                      \u0027immutable user source and solely \u0027"},{"line_number":99,"context_line":"                      \u0027provides read-only access to users.\u0027)"},{"line_number":100,"context_line":"    def test_grant_list_revoke_role_to_user_on_project(self):"},{"line_number":101,"context_line":"        self.user_body \u003d self.users_client.create_user("},{"line_number":102,"context_line":"            name\u003dself.u_name, description\u003dself.u_desc,"},{"line_number":103,"context_line":"            password\u003dself.u_password,"},{"line_number":104,"context_line":"            email\u003dself.u_email, project_id\u003dself.project[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_b4df0539","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":22},"updated":"2019-02-20 03:50:45.000000000","message":"This is already created in resource_setup, so no need to create it in the testcases.","commit_id":"7cceeef329d8b1ab2e71828dc6aaabb72c6549fd"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2fb15ffe13f7035211d2db100533be214fdd68a9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            cls.addClassResourceCleanup(cls.roles_client.delete_role,"},{"line_number":37,"context_line":"                                        role[\u0027id\u0027])"},{"line_number":38,"context_line":"            cls.roles.append(role)"},{"line_number":39,"context_line":"        cls.u_name \u003d data_utils.rand_name(\u0027user\u0027)"},{"line_number":40,"context_line":"        cls.u_desc \u003d \u0027%s description\u0027 % cls.u_name"},{"line_number":41,"context_line":"        cls.u_email \u003d \u0027%s@testmail.tm\u0027 % cls.u_name"},{"line_number":42,"context_line":"        cls.u_password \u003d data_utils.rand_password()"},{"line_number":43,"context_line":"        cls.domain \u003d cls.create_domain()"},{"line_number":44,"context_line":"        cls.project \u003d cls.projects_client.create_project("}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_0b29a335","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":51},"updated":"2019-02-26 03:00:52.000000000","message":"why change these to instance variables?","commit_id":"c32449cdeb16f1c4fabd7babcc34417c83870a3b"}]}