)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"d1825df47d1820f4a5e84be580b5e08fdf116003","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Noam Angel \u003cnoama@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-27 10:57:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"allow create_server with vnic_type and port_profile from kwargs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5b9a4bd5350809d6b295dfede0c5059d01455404"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_dc2ee390","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":63},"updated":"2019-01-30 06:26:10.000000000","message":"Could you please elaborate the commit message for the advantage of this patch set change?","commit_id":"1c15bc19e75fe9702e0b5f6fe05726f137e3ed9a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b869b6174a3075ddfa098209e0d57741c09eaffa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"allow create_server with vnic_type and port_profile from kwargs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the purpose of this change is to enable creating advance network"},{"line_number":10,"context_line":"scenarios like checking connectivity from VM with port type \"direct\" to"},{"line_number":11,"context_line":"VM with port type \"normal\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5b9a4bd5350809d6b295dfede0c5059d01455404"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_fd277363","line":11,"range":{"start_line":10,"start_character":42,"end_line":11,"end_character":26},"updated":"2019-02-09 01:32:33.000000000","message":"Maybe you want to change port_vnic_type for each test, right?\nCould you provide the detail of purpose?\n\nThe above description seems only for port_vnic_type, could you provide the reason why we need to change port_profile also on this patch?","commit_id":"895021e3476cb8e36c514943d652b794188d673f"}],"tempest/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2290a768b1b732af3ebb21c8f587a907aacdeee8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \"-server\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        vnic_type \u003d kwargs.pop(\u0027vnic_type\u0027, CONF.network.port_vnic_type)"},{"line_number":147,"context_line":"        profile \u003d kwargs.pop(\u0027port_profile\u0027, CONF.network.port_profile)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # If vnic_type or profile are configured create port for"},{"line_number":150,"context_line":"        # every network"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_cfddab41","line":147,"updated":"2019-02-15 03:01:01.000000000","message":"Could you add docstrings for these parameter? Because there\u0027s no usage so far. I think it could be helpful to understand this API(create_server()).","commit_id":"a78c1cd1e370a2275a96555afc0667e8a3f2e061"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d45b57256b7cceed9782a8c8a5bea48ad8c55689","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \"-server\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        vnic_type \u003d kwargs.pop(\u0027vnic_type\u0027, CONF.network.port_vnic_type)"},{"line_number":147,"context_line":"        profile \u003d kwargs.pop(\u0027port_profile\u0027, CONF.network.port_profile)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # If vnic_type or profile are configured create port for"},{"line_number":150,"context_line":"        # every network"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_d4611713","line":147,"in_reply_to":"9fdfeff1_cfddab41","updated":"2019-02-25 01:40:16.000000000","message":"+1 on doc string.","commit_id":"a78c1cd1e370a2275a96555afc0667e8a3f2e061"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3253dc87412846b220495aa9d7b3c646f6255cba","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        #           linux bridge or an openvswitch bridge on a compute node."},{"line_number":150,"context_line":"        #   direct: an SR-IOV port that is directly attached to a VM"},{"line_number":151,"context_line":"        #   macvtap: an SR-IOV port that is attached to a VM via a macvtap"},{"line_number":152,"context_line":"        #            device."},{"line_number":153,"context_line":"        vnic_type \u003d kwargs.pop(\u0027vnic_type\u0027, CONF.network.port_vnic_type)"},{"line_number":154,"context_line":"        # port_profile - This attribute is a dictionary that can be used (with"},{"line_number":155,"context_line":"        #                admin credentials) to"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_e51d7062","line":152,"updated":"2019-02-26 00:28:58.000000000","message":"Maybe they might want to see this kind of comment as docstring, that means we need to write this explanation on line 127 as an explanation of kwargs option.","commit_id":"27224a4bfadeff665527cbb943dda64dd459baf3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3253dc87412846b220495aa9d7b3c646f6255cba","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # port_profile - This attribute is a dictionary that can be used (with"},{"line_number":155,"context_line":"        #                admin credentials) to"},{"line_number":156,"context_line":"        # supply information influencing the binding of the port."},{"line_number":157,"context_line":"        # example: port_profile \u003d \"capabilities:[switchdev]\""},{"line_number":158,"context_line":"        profile \u003d kwargs.pop(\u0027port_profile\u0027, CONF.network.port_profile)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # If vnic_type or profile are configured create port for"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_c5386cd4","line":157,"updated":"2019-02-26 00:28:58.000000000","message":"ditto","commit_id":"27224a4bfadeff665527cbb943dda64dd459baf3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac52a47e96e5b14c143d94fd531adc7a14fe7467","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def create_server(self, name\u003dNone, image_id\u003dNone, flavor\u003dNone,"},{"line_number":120,"context_line":"                      validatable\u003dFalse, wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":121,"context_line":"                      clients\u003dNone, **kwargs):"},{"line_number":122,"context_line":"        r\"\"\"Wrapper utility that returns a test server."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        This wrapper utility calls the common create test server and"},{"line_number":125,"context_line":"        returns a test server. The purpose of this wrapper is to minimize"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_38b14402","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":9},"updated":"2019-02-26 23:16:12.000000000","message":"https://stackoverflow.com/questions/1137161/what-is-the-correct-way-to-document-a-kwargs-parameter shows different opinions and \u0027r\u0027 is not necessary because we don\u0027t use it and it would make it inconsistent.","commit_id":"dcd91f5e76512daa99d1be9f5cdc672b4220544c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac52a47e96e5b14c143d94fd531adc7a14fe7467","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        returns a test server. The purpose of this wrapper is to minimize"},{"line_number":126,"context_line":"        the impact on the code of the tests already using this"},{"line_number":127,"context_line":"        function."},{"line_number":128,"context_line":"        "},{"line_number":129,"context_line":"        :param \\**kwargs:"},{"line_number":130,"context_line":"            See extra parameters below"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_b8c45461","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":8},"updated":"2019-02-26 23:16:12.000000000","message":"unnecessary spaces against pep8 rule as http://logs.openstack.org/83/633383/10/check/openstack-tox-pep8/981aa8c/job-output.txt.gz#_2019-02-26_10_44_34_693604","commit_id":"dcd91f5e76512daa99d1be9f5cdc672b4220544c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac84048cba9a9677d3b60dc8334eaa17c978b8de","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        the impact on the code of the tests already using this"},{"line_number":127,"context_line":"        function."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param \\**kwargs:"},{"line_number":130,"context_line":"            See extra parameters below"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :Keyword Arguments:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_2fe79ce5","line":129,"range":{"start_line":129,"start_character":15,"end_line":129,"end_character":16},"updated":"2019-02-28 01:59:55.000000000","message":"We need to remove this escape for passing pep8 as http://logs.openstack.org/83/633383/11/check/openstack-tox-pep8/e7c01c2/job-output.txt.gz#_2019-02-27_08_47_36_771099","commit_id":"078a8a655554ced6b153b00b0684e5470287adfa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3edde02ea86672c4c6ad9433c22b3043242d520c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            See extra parameters below"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :Keyword Arguments:"},{"line_number":133,"context_line":"            * *vnic_type* (``string``) --"},{"line_number":134,"context_line":"              used when launching instances with pre-configured ports."},{"line_number":135,"context_line":"              Examples:"},{"line_number":136,"context_line":"                normal: a traditional virtual port that is either attached"},{"line_number":137,"context_line":"                        to a linux bridge or an openvswitch bridge on a"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_c2e22731","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":70},"updated":"2019-03-03 16:20:06.000000000","message":"can you add the default value for this if not passed which is from CONF","commit_id":"9ae7eaf1f21d4a9ecda7c3e0bd4a8bb0c2ba9266"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3edde02ea86672c4c6ad9433c22b3043242d520c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                direct: an SR-IOV port that is directly attached to a VM"},{"line_number":140,"context_line":"                macvtap: an SR-IOV port that is attached to a VM via a macvtap"},{"line_number":141,"context_line":"                         device."},{"line_number":142,"context_line":"            * *port_profile* (``dict``) --"},{"line_number":143,"context_line":"              This attribute is a dictionary that can be used (with admin"},{"line_number":144,"context_line":"              credentials) to supply information influencing the binding of"},{"line_number":145,"context_line":"              the port."}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_e2df2b64","line":142,"range":{"start_line":142,"start_character":10,"end_line":142,"end_character":42},"updated":"2019-03-03 16:20:06.000000000","message":"ditto","commit_id":"9ae7eaf1f21d4a9ecda7c3e0bd4a8bb0c2ba9266"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a4a8b2b5f50dd148adb989d4e5b65c676ad46dde","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                        compute node."},{"line_number":139,"context_line":"                direct: an SR-IOV port that is directly attached to a VM"},{"line_number":140,"context_line":"                macvtap: an SR-IOV port that is attached to a VM via a macvtap"},{"line_number":141,"context_line":"                         device."},{"line_number":142,"context_line":"              Defaults to None."},{"line_number":143,"context_line":"            * *port_profile* (``dict``) --"},{"line_number":144,"context_line":"              This attribute is a dictionary that can be used (with admin"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_fcba3edc","line":141,"updated":"2019-03-07 20:13:19.000000000","message":"The \"Defaults to None\" is incorrect because it depends on what the CONF options are. While the default of the CONF option might be None, that is not true for all systems/configurations.","commit_id":"6555046bea93ff11285d1abcc1970b198a3194cb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a4a8b2b5f50dd148adb989d4e5b65c676ad46dde","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                direct: an SR-IOV port that is directly attached to a VM"},{"line_number":140,"context_line":"                macvtap: an SR-IOV port that is attached to a VM via a macvtap"},{"line_number":141,"context_line":"                         device."},{"line_number":142,"context_line":"              Defaults to None."},{"line_number":143,"context_line":"            * *port_profile* (``dict``) --"},{"line_number":144,"context_line":"              This attribute is a dictionary that can be used (with admin"},{"line_number":145,"context_line":"              credentials) to supply information influencing the binding of"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_fce1deff","line":142,"range":{"start_line":142,"start_character":26,"end_line":142,"end_character":30},"updated":"2019-03-07 20:13:19.000000000","message":"``CONF.network.port_vnic_type``","commit_id":"6555046bea93ff11285d1abcc1970b198a3194cb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a4a8b2b5f50dd148adb989d4e5b65c676ad46dde","unresolved":false,"context_lines":[{"line_number":145,"context_line":"              credentials) to supply information influencing the binding of"},{"line_number":146,"context_line":"              the port."},{"line_number":147,"context_line":"              example: port_profile \u003d \"capabilities:[switchdev]\""},{"line_number":148,"context_line":"              Defaults to None."},{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE(jlanoux): As a first step, ssh checks in the scenario"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_9ce69a16","line":148,"range":{"start_line":148,"start_character":26,"end_line":148,"end_character":30},"updated":"2019-03-07 20:13:19.000000000","message":"``CONF.network.port_profile``","commit_id":"6555046bea93ff11285d1abcc1970b198a3194cb"}]}