)]}'
{"tempest/api/compute/admin/test_servers_on_multinodes.py":[{"author":{"_account_id":27078,"name":"Manik Bindlish","email":"manikbindlish19@gmail.com","username":"manik"},"change_message_id":"847c04ab6c1119a7c51e3e58a854ee5b290f6f13","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        asserts the servers are in the group and on different hosts."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        hosts \u003d self._create_servers_with_group(\u0027anti-affinity\u0027)"},{"line_number":108,"context_line":"        hostnames \u003d list(hosts.values())"},{"line_number":109,"context_line":"        self.assertNotEqual(hostnames[0], hostnames[1],"},{"line_number":110,"context_line":"                            \u0027Servers are on the same host: %s\u0027 % hosts)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f4af2927","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":40},"updated":"2019-01-31 09:01:52.000000000","message":"I think there is no need to add list.\nhostnames is already a list.\n\ntaking e.g.:\n\u003e\u003e\u003e a\u003d{\u0027m\u0027:1, \u0027n\u0027:2}\n\u003e\u003e\u003e a.values()\n[1, 2]\n\u003e\u003e\u003e type(a.values())\n\u003ctype \u0027list\u0027\u003e\n\u003e\u003e\u003e \n\na is dictionary here\na.values() comes as list\nSo already it\u0027s list. No need to convert in list\n\nPlease correct if I am mistaken?","commit_id":"ebc2186e7ffe89dadea833c1c4ddd0bee3cd58d2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d6b82673bbb9aa49aa7faa9da6f405fbe44cc7a7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        asserts the servers are in the group and on different hosts."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        hosts \u003d self._create_servers_with_group(\u0027anti-affinity\u0027)"},{"line_number":108,"context_line":"        hostnames \u003d list(hosts.values())"},{"line_number":109,"context_line":"        self.assertNotEqual(hostnames[0], hostnames[1],"},{"line_number":110,"context_line":"                            \u0027Servers are on the same host: %s\u0027 % hosts)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2fb47cd0","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":40},"in_reply_to":"9fdfeff1_f4af2927","updated":"2019-01-31 09:26:37.000000000","message":"He means in python3,\n\u003e\u003e\u003e test \u003d {\"a\": 100}\n\u003e\u003e\u003e test.values()[0]\nTraceback (most recent call last):\n  File \"\u003cpyshell#3\u003e\", line 1, in \u003cmodule\u003e\n    test.values()[0]\nTypeError: \u0027dict_values\u0027 object does not support indexing\n\u003e\u003e\u003e","commit_id":"ebc2186e7ffe89dadea833c1c4ddd0bee3cd58d2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7a5ced7300284489e0adc39d4ba33656d4a2d8b6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        asserts the servers are in the group and on different hosts."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        hosts \u003d self._create_servers_with_group(\u0027anti-affinity\u0027)"},{"line_number":108,"context_line":"        hostnames \u003d list(hosts.values())"},{"line_number":109,"context_line":"        self.assertNotEqual(hostnames[0], hostnames[1],"},{"line_number":110,"context_line":"                            \u0027Servers are on the same host: %s\u0027 % hosts)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_eff7548a","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":40},"in_reply_to":"9fdfeff1_f4af2927","updated":"2019-01-31 09:26:56.000000000","message":"You\u0027re right in Python 2 but not in 3:\n\n    \u003e\u003e\u003e a\u003d{\u0027m\u0027:1, \u0027n\u0027:2}\n    \u003e\u003e\u003e type(a.values())\n    \u003cclass \u0027dict_values\u0027\u003e\n    \u003e\u003e\u003e a.values()[0]\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    TypeError: \u0027dict_values\u0027 object does not support indexing","commit_id":"ebc2186e7ffe89dadea833c1c4ddd0bee3cd58d2"}]}
