)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8334c68ddede8f14fe1e3b2b2ef3a09fa5cec423","unresolved":false,"context_lines":[{"line_number":11,"context_line":" * NetworkVipService"},{"line_number":12,"context_line":" * NetworkMemberService"},{"line_number":13,"context_line":" * NetworkHealthMonitorService"},{"line_number":14,"context_line":" * NetworkPoolService"},{"line_number":15,"context_line":" * FloatingIpService"},{"line_number":16,"context_line":" * SecurityGroupService"},{"line_number":17,"context_line":"The above services are not used by the cleanup tool, they"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_f94414ba","line":14,"updated":"2019-02-14 02:57:05.000000000","message":"yeah, these four classes are not used.","commit_id":"9e43fd8bbe9355f6cf1bb15d9b0240988a3b2a5c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8334c68ddede8f14fe1e3b2b2ef3a09fa5cec423","unresolved":false,"context_lines":[{"line_number":13,"context_line":" * NetworkHealthMonitorService"},{"line_number":14,"context_line":" * NetworkPoolService"},{"line_number":15,"context_line":" * FloatingIpService"},{"line_number":16,"context_line":" * SecurityGroupService"},{"line_number":17,"context_line":"The above services are not used by the cleanup tool, they"},{"line_number":18,"context_line":"call clients which were already removed from Tempest or"},{"line_number":19,"context_line":"the clients are marked as deprecated ones."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_194238ac","line":16,"updated":"2019-02-14 02:57:05.000000000","message":"Did you want to mention about IdentityService, too?","commit_id":"9e43fd8bbe9355f6cf1bb15d9b0240988a3b2a5c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"01846e2e9b7356288a7296827875d7ad6d9e922a","unresolved":false,"context_lines":[{"line_number":13,"context_line":" * NetworkHealthMonitorService"},{"line_number":14,"context_line":" * NetworkPoolService"},{"line_number":15,"context_line":" * FloatingIpService"},{"line_number":16,"context_line":" * SecurityGroupService"},{"line_number":17,"context_line":"The above services are not used by the cleanup tool, they"},{"line_number":18,"context_line":"call clients which were already removed from Tempest or"},{"line_number":19,"context_line":"the clients are marked as deprecated ones."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_80ee9fea","line":16,"in_reply_to":"9fdfeff1_194238ac","updated":"2019-02-14 16:36:28.000000000","message":"oh yeah, I forgot about that one, thanks.","commit_id":"9e43fd8bbe9355f6cf1bb15d9b0240988a3b2a5c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8334c68ddede8f14fe1e3b2b2ef3a09fa5cec423","unresolved":false,"context_lines":[{"line_number":16,"context_line":" * SecurityGroupService"},{"line_number":17,"context_line":"The above services are not used by the cleanup tool, they"},{"line_number":18,"context_line":"call clients which were already removed from Tempest or"},{"line_number":19,"context_line":"the clients are marked as deprecated ones."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I55ddbce64404c67688600dc6b1231d0bd8ff7006"},{"line_number":22,"context_line":"Related-Bug: #1812660"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_b9144ca1","line":19,"updated":"2019-02-14 02:57:05.000000000","message":"I\u0027m not sure here. Do we already deprecate FloatingIpsClient and SecurityGroupClient in Tempest? The apis are deprecated in Nova, though.\nhttps://developer.openstack.org/api-ref/compute/#floating-ips-os-floating-ips-deprecated\nhttps://developer.openstack.org/api-ref/compute/#security-groups-os-security-groups-deprecated","commit_id":"9e43fd8bbe9355f6cf1bb15d9b0240988a3b2a5c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"effd57bfbad3a04bbe88f2676a8835fe9096804f","unresolved":false,"context_lines":[{"line_number":16,"context_line":" * SecurityGroupService"},{"line_number":17,"context_line":"The above services are not used by the cleanup tool, they"},{"line_number":18,"context_line":"call clients which were already removed from Tempest or"},{"line_number":19,"context_line":"the clients are marked as deprecated ones."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I55ddbce64404c67688600dc6b1231d0bd8ff7006"},{"line_number":22,"context_line":"Related-Bug: #1812660"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_cfd12bce","line":19,"updated":"2019-02-15 03:34:48.000000000","message":"well, yeah. We should be able to use Neutron APIs directory for cleaning. So, we don\u0027t need to use proxy APIs for just cleaning up. And they should also work in the tempest supporting versions.","commit_id":"9e43fd8bbe9355f6cf1bb15d9b0240988a3b2a5c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"01846e2e9b7356288a7296827875d7ad6d9e922a","unresolved":false,"context_lines":[{"line_number":16,"context_line":" * SecurityGroupService"},{"line_number":17,"context_line":"The above services are not used by the cleanup tool, they"},{"line_number":18,"context_line":"call clients which were already removed from Tempest or"},{"line_number":19,"context_line":"the clients are marked as deprecated ones."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I55ddbce64404c67688600dc6b1231d0bd8ff7006"},{"line_number":22,"context_line":"Related-Bug: #1812660"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_e07a0b22","line":19,"in_reply_to":"9fdfeff1_b9144ca1","updated":"2019-02-14 16:36:28.000000000","message":"Well, if i get it right, these two classes were a proxy classes - their clients did proxy calls to Network service. Now we can see in the links you attached that Nova has deprecated all the proxy APIs and only native APIs should be used. And I think, those native APIs should be included in the following network classes:\n\nhttps://review.openstack.org/#/c/636387/3/tempest/cmd/cleanup_service.py@346\nhttps://review.openstack.org/#/c/636387/3/tempest/cmd/cleanup_service.py@480","commit_id":"9e43fd8bbe9355f6cf1bb15d9b0240988a3b2a5c"}]}
