)]}'
{"tempest/api/compute/servers/test_device_tagging.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"137c608f738e0e8a76b6ebcd1f7632d9c5f58f3d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # bug in the 2.32 microversion, tags on block devices only worked with the"},{"line_number":111,"context_line":"    # 2.32 microversion specifically. And tags on networks only worked between"},{"line_number":112,"context_line":"    # 2.32 and 2.36 inclusive; the 2.37 microversion broke tags for networks."},{"line_number":113,"context_line":"    max_microversion \u003d \u00272.32\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def verify_device_metadata(self, md_json):"},{"line_number":116,"context_line":"        md_dict \u003d json.loads(md_json)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_43394fd6","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":29},"updated":"2019-02-19 15:54:06.000000000","message":"Your change won\u0027t work because the test is capped at 2.32 so it\u0027s not going to run with 2.70. As I said in the nova change, the device tags in API microversion (currently 2.70) is all API and DB in nova so I don\u0027t think we need to add any integration testing to tempest for it. If anything we should be working on splitting more testing out of tempest if possible given the timeouts we\u0027ve been seeing in tempest jobs lately.","commit_id":"b98d2fd507f5560e27c88c8d705bdfdee74cdb47"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"81871efa7280b23bc60fb433ae2e5de2c1aeb5fb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # bug in the 2.32 microversion, tags on block devices only worked with the"},{"line_number":111,"context_line":"    # 2.32 microversion specifically. And tags on networks only worked between"},{"line_number":112,"context_line":"    # 2.32 and 2.36 inclusive; the 2.37 microversion broke tags for networks."},{"line_number":113,"context_line":"    max_microversion \u003d \u00272.32\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def verify_device_metadata(self, md_json):"},{"line_number":116,"context_line":"        md_dict \u003d json.loads(md_json)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6371f3de","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":29},"in_reply_to":"9fdfeff1_43394fd6","updated":"2019-02-19 16:13:34.000000000","message":"\u003e Your change won\u0027t work because the test is capped at 2.32 so it\u0027s\n \u003e not going to run with 2.70.\n\nWhich is why I added lines 429-431 :)\n\n\u003e As I said in the nova change, the\n \u003e device tags in API microversion (currently 2.70) is all API and DB\n \u003e in nova so I don\u0027t think we need to add any integration testing to\n \u003e tempest for it.\n\nI know, I know. I just have more confidence in a thing if I see it working for \"real\". Consider this patch a DNM for my own OCD, if you wish :)\n\n\u003e If anything we should be working on splitting more\n \u003e testing out of tempest if possible given the timeouts we\u0027ve been\n \u003e seeing in tempest jobs lately.\n\n*shrug* Dunno. Like I said, I think there\u0027s still value in \"real\" testing.","commit_id":"b98d2fd507f5560e27c88c8d705bdfdee74cdb47"}]}