)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"27f3a3e347a20f582fae6df96e55d9a42add92c8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"1) CONF.auth.admin_domain_name"},{"line_number":18,"context_line":"2) CONF.auth.default_credentials_domain_name"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This is already taken into account when a domain_name is passed from"},{"line_number":21,"context_line":"identity_utils during object instantiation and used for in the"},{"line_number":22,"context_line":"create_project method specific to V3CredsClient. The API calls only"},{"line_number":23,"context_line":"accept a domain_id which is why creds_domain field of a V3CredsClient"},{"line_number":24,"context_line":"object is used to store an id of a domain_name domain passed via"},{"line_number":25,"context_line":"constructor. The same can be used for create_user method specific to v3."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I66f22c61d7a8596cafdc415654edfecdc5495d2e"},{"line_number":28,"context_line":"Closes-Bug: #1613819"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"048ab7b1_b5e2f959","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":0},"updated":"2021-02-16 16:17:27.000000000","message":"yeah and from dynamic creds it is CONF.auth.default_credentials_domain_name\n- https://github.com/openstack/tempest/blob/739a9f82227c8fea950ac6d682f6e0918495bf81/tempest/common/credentials_factory.py#L53","commit_id":"1ce92bf34d0177c34be9be661e79c4f98e6cce47"}],"tempest/lib/common/cred_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1c073e82b7c24a559ae73226493301d97802f43","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def delete_project(self, project_id):"},{"line_number":157,"context_line":"        self.projects_client.delete_project(project_id)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":160,"context_line":"        params \u003d {\u0027name\u0027: username,"},{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"},{"line_number":163,"context_line":"                  \u0027email\u0027: email,"},{"line_number":164,"context_line":"                  \u0027domain_id\u0027: self.creds_domain[\u0027id\u0027]}"},{"line_number":165,"context_line":"        user \u003d self.users_client.create_user(**params)"},{"line_number":166,"context_line":"        if \u0027user\u0027 in user:"},{"line_number":167,"context_line":"            user \u003d user[\u0027user\u0027]"},{"line_number":168,"context_line":"        return user"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def get_credentials(self, user, project, password):"},{"line_number":171,"context_line":"        # User, project and domain already include both ID and name here,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_72dbb21a","line":168,"range":{"start_line":159,"start_character":0,"end_line":168,"end_character":19},"updated":"2019-03-10 22:15:11.000000000","message":"This can be simplified by simply building on top of create_user in the base class:\n\n    def create_user(self, username, password, project, email, **kwargs):\n        params \u003d {\u0027name\u0027: username,\n                  \u0027password\u0027: password,\n                  self.project_id_param: project[\u0027id\u0027],\n                  \u0027email\u0027: email}\n        params \u003d params.update(kwargs)\n        user \u003d self.users_client.create_user(**params)\n        if \u0027user\u0027 in user:\n            user \u003d user[\u0027user\u0027]\n        return user\n\n     def create_user(self, username, password, project, email):\n         return super(username, password, project, email, domain_id\u003dself.creds_domain[\u0027id\u0027])","commit_id":"a5a4ac0878df87ea9dbedf6190706c2e3521b5dc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c9158bdb8d6d7134cde7e217fe9ad74bbd5b30e2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def delete_project(self, project_id):"},{"line_number":157,"context_line":"        self.projects_client.delete_project(project_id)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":160,"context_line":"        params \u003d {\u0027name\u0027: username,"},{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_a2501ad6","line":159,"range":{"start_line":159,"start_character":46,"end_line":159,"end_character":53},"updated":"2019-03-20 18:10:17.000000000","message":"Could you change project to project_id on arguments for simple method?","commit_id":"da3c19311393cf74faaeb4f3af7bdae04df7cb05"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a60ed5a16d72bd42360192ee8e91bdf5bef33979","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def delete_project(self, project_id):"},{"line_number":157,"context_line":"        self.projects_client.delete_project(project_id)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":160,"context_line":"        params \u003d {\u0027name\u0027: username,"},{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7ec2d75a","line":159,"range":{"start_line":159,"start_character":46,"end_line":159,"end_character":53},"in_reply_to":"5fc1f717_a2501ad6","updated":"2020-08-05 13:59:16.000000000","message":"why would that be simpler? create_user method in CredsClient class has also project not project_id parameter ..","commit_id":"da3c19311393cf74faaeb4f3af7bdae04df7cb05"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6ac827e3de3520b892d5c4f52291ad388eeca3a9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"},{"line_number":163,"context_line":"                  \u0027email\u0027: email,"},{"line_number":164,"context_line":"                  \u0027domain_id\u0027: self.creds_domain[\u0027id\u0027]}"},{"line_number":165,"context_line":"        user \u003d self.users_client.create_user(**params)"},{"line_number":166,"context_line":"        if \u0027user\u0027 in user:"},{"line_number":167,"context_line":"            user \u003d user[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_235b9a2e","line":164,"range":{"start_line":164,"start_character":18,"end_line":164,"end_character":54},"updated":"2019-03-11 05:06:26.000000000","message":"I\u0027m curious why not support overriding the domain_id via an argument, as in:\n\n    def create_user(self, username, password, project, email, domain_id\u003dNone):\n        ...\n        params \u003d {\n            ...,\n            \u0027domain_id\u0027: domain_id or self.creds_domain[\u0027id\u0027]\n        }","commit_id":"da3c19311393cf74faaeb4f3af7bdae04df7cb05"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c9158bdb8d6d7134cde7e217fe9ad74bbd5b30e2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"},{"line_number":163,"context_line":"                  \u0027email\u0027: email,"},{"line_number":164,"context_line":"                  \u0027domain_id\u0027: self.creds_domain[\u0027id\u0027]}"},{"line_number":165,"context_line":"        user \u003d self.users_client.create_user(**params)"},{"line_number":166,"context_line":"        if \u0027user\u0027 in user:"},{"line_number":167,"context_line":"            user \u003d user[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c2dbe67a","line":164,"range":{"start_line":164,"start_character":18,"end_line":164,"end_character":54},"in_reply_to":"5fc1f717_235b9a2e","updated":"2019-03-20 18:10:17.000000000","message":"+1","commit_id":"da3c19311393cf74faaeb4f3af7bdae04df7cb05"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"424119171b78b23aa4c1953f036c83ce8e7bcf6c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"},{"line_number":163,"context_line":"                  \u0027email\u0027: email,"},{"line_number":164,"context_line":"                  \u0027domain_id\u0027: self.creds_domain[\u0027id\u0027]}"},{"line_number":165,"context_line":"        user \u003d self.users_client.create_user(**params)"},{"line_number":166,"context_line":"        if \u0027user\u0027 in user:"},{"line_number":167,"context_line":"            user \u003d user[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2f5dcb14","line":164,"range":{"start_line":164,"start_character":31,"end_line":164,"end_character":54},"updated":"2020-08-24 11:13:11.000000000","message":"this value is set on line 143 by listing domains, however, it seems it doesn\u0027t take into account CONF.auth.default_domain_id option - when i tried to override it via my tempest.conf, it still contained id\u003d\u003d\u0027default\u0027 , i wonder why is that","commit_id":"f765cd27cbea2142630a00f0c1527318e78a6c46"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d77e4a6d2e15e486a7c38b9bf73ffd728fb05f36","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                  \u0027password\u0027: password,"},{"line_number":162,"context_line":"                  self.project_id_param: project[\u0027id\u0027],"},{"line_number":163,"context_line":"                  \u0027email\u0027: email,"},{"line_number":164,"context_line":"                  \u0027domain_id\u0027: self.creds_domain[\u0027id\u0027]}"},{"line_number":165,"context_line":"        user \u003d self.users_client.create_user(**params)"},{"line_number":166,"context_line":"        if \u0027user\u0027 in user:"},{"line_number":167,"context_line":"            user \u003d user[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_deccbe8a","line":164,"range":{"start_line":164,"start_character":31,"end_line":164,"end_character":54},"in_reply_to":"9f560f44_2f5dcb14","updated":"2020-08-24 13:31:38.000000000","message":"The value of variable domain_name which is passed to the V3CredsClient is set on this line [1]. It seems that the line does not take into consideration CONF.auth.default_domain_id option.\n\n[1]https://github.com/openstack/tempest/blob/a0ee8b4ccfc512a09e1ddb135950b767110aae9b/tempest/lib/common/dynamic_creds.py#L110","commit_id":"f765cd27cbea2142630a00f0c1527318e78a6c46"}]}