)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"de14ebca231a6809cb10beb97df4b37ec5316ce1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add base class for Telemetry tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the base class for all Telemetry tests."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If467d05bceb4f5c29a7cac6c83be6fc8aae159c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2F96U%3D","line":10,"updated":"2014-01-06 04:39:10.000000000","message":"I think this should have like a following comment:\n\n Partially implements: blueprint add-basic-ceilometer-tests","commit_id":"38f0a818ba9f51aeb2176e83b8327fdaff48ab98"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"4ebaf52b532a4d89f885e7bb07794c36f4fbf019","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add base class for Telemetry tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the base class for all Telemetry tests."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If467d05bceb4f5c29a7cac6c83be6fc8aae159c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2F9Bo%3D","line":10,"in_reply_to":"AAAAUH%2F%2F96U%3D","updated":"2014-01-06 09:29:17.000000000","message":"Yea, thanks !","commit_id":"38f0a818ba9f51aeb2176e83b8327fdaff48ab98"}],"tempest/api/telemetry/base.py":[{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"3319e509d56ee9765ae46699642995c8693a1224","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import tempest.test"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class BaseTelemetryTest(tempest.test.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2FIU%3D","line":18,"updated":"2014-01-04 21:06:44.000000000","message":"Please remove this. It\u0027s not necessary.","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"0bf84eb1106f64479f35a759d739c092c08ac8f9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import tempest.test"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class BaseTelemetryTest(tempest.test.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2Bro%3D","line":18,"in_reply_to":"AAAAUH%2F%2F%2FIU%3D","updated":"2014-01-05 15:07:16.000000000","message":"Done","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"742d142964e9b685ee5f5f5540a6f4dee509c2c6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Base test case class for all Telemetry API tests.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setUpClass(cls):"},{"line_number":29,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FwRQ%3D","line":26,"updated":"2014-01-02 10:19:30.000000000","message":"This looks like something copy/pasted from the compute code. I think we should remove this for now, and only add it when there is some piece of code that actually needs to force tenant isolation.","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"3319e509d56ee9765ae46699642995c8693a1224","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Base test case class for all Telemetry API tests.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setUpClass(cls):"},{"line_number":29,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2FIo%3D","line":26,"in_reply_to":"AAAAT3%2F%2FwRQ%3D","updated":"2014-01-04 21:06:44.000000000","message":"Please remove line 25. It\u0027s not necessary.","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"0bf84eb1106f64479f35a759d739c092c08ac8f9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Base test case class for all Telemetry API tests.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def setUpClass(cls):"},{"line_number":29,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2Brg%3D","line":26,"in_reply_to":"AAAAUH%2F%2F%2FIo%3D","updated":"2014-01-05 15:07:16.000000000","message":"Done","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"3319e509d56ee9765ae46699642995c8693a1224","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"},{"line_number":30,"context_line":"        os \u003d cls.get_client_manager()"},{"line_number":31,"context_line":"        cls.telemetry_cfg \u003d os.config.telemetry"},{"line_number":32,"context_line":"        if not os.config.service_available.ceilometer:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2FIc%3D","line":32,"updated":"2014-01-04 21:06:44.000000000","message":"Please move this \"if\" immediately after \"super\".","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"0bf84eb1106f64479f35a759d739c092c08ac8f9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"},{"line_number":30,"context_line":"        os \u003d cls.get_client_manager()"},{"line_number":31,"context_line":"        cls.telemetry_cfg \u003d os.config.telemetry"},{"line_number":32,"context_line":"        if not os.config.service_available.ceilometer:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2BrU%3D","line":32,"in_reply_to":"AAAAUH%2F%2F%2FIc%3D","updated":"2014-01-05 15:07:16.000000000","message":"Done","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"3319e509d56ee9765ae46699642995c8693a1224","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def tearDownClass(cls):"},{"line_number":37,"context_line":"        cls.clear_isolated_creds()"},{"line_number":38,"context_line":"        super(BaseTelemetryTest, cls).tearDownClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2FIk%3D","line":36,"updated":"2014-01-04 21:06:44.000000000","message":"Please, remove all tearDownClass. It\u0027s not necessary.","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"0bf84eb1106f64479f35a759d739c092c08ac8f9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def tearDownClass(cls):"},{"line_number":37,"context_line":"        cls.clear_isolated_creds()"},{"line_number":38,"context_line":"        super(BaseTelemetryTest, cls).tearDownClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F%2BrQ%3D","line":36,"in_reply_to":"AAAAUH%2F%2F%2FIk%3D","updated":"2014-01-05 15:07:16.000000000","message":"Done","commit_id":"5c0c088e42f99354682a374afae58c9dbf5ea88f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1075f5526791818ea5d02e990a01778135c2d0ed","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        if not os.config.service_available.ceilometer:"},{"line_number":25,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        cls.telemetry_cfg \u003d os.config.telemetry"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F%2BQw%3D","line":27,"updated":"2014-01-06 00:59:34.000000000","message":"Is this config necessary for now?\nI could not find this telemetry_cfg in https://review.openstack.org/#/c/39237 .","commit_id":"38f0a818ba9f51aeb2176e83b8327fdaff48ab98"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"4ebaf52b532a4d89f885e7bb07794c36f4fbf019","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        if not os.config.service_available.ceilometer:"},{"line_number":25,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        cls.telemetry_cfg \u003d os.config.telemetry"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F9B4%3D","line":27,"in_reply_to":"AAAAUH%2F%2F%2BQw%3D","updated":"2014-01-06 09:29:17.000000000","message":"No, we can remove it for now, thanks !","commit_id":"38f0a818ba9f51aeb2176e83b8327fdaff48ab98"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"e7ca51eece90bdadebe59876f2e1880f95f035b6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def setUpClass(cls):"},{"line_number":22,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"},{"line_number":23,"context_line":"        os \u003d cls.get_client_manager()"},{"line_number":24,"context_line":"        if not os.config.service_available.ceilometer:"},{"line_number":25,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F2%2Fk%3D","line":24,"updated":"2014-01-07 15:34:00.000000000","message":"Please use something like:\n\nfrom tempest import config\n\nCONF \u003d config.CONF\n\n.... inside some class ...\n    if CONF.service_available.neutron: \n\n(see http://openstack.10931.n7.nabble.com/qa-changes-to-interacting-with-Tempest-config-td27732.html)","commit_id":"43a4d72ae46073337bbcad7ab26404a348a90b50"},{"author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"change_message_id":"9a1027745bf16e6a8dcb1043ce4d36ed04616863","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def setUpClass(cls):"},{"line_number":22,"context_line":"        super(BaseTelemetryTest, cls).setUpClass()"},{"line_number":23,"context_line":"        os \u003d cls.get_client_manager()"},{"line_number":24,"context_line":"        if not os.config.service_available.ceilometer:"},{"line_number":25,"context_line":"            raise cls.skipException(\"Ceilometer support is required\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F2mY%3D","line":24,"in_reply_to":"AAAAUH%2F%2F2%2Fk%3D","updated":"2014-01-07 17:01:11.000000000","message":"Thanks! Done","commit_id":"43a4d72ae46073337bbcad7ab26404a348a90b50"}]}
