)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d22dd127b66db2aa0137b4e26dd24e1108b6b10f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                        volume_id)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def validate_server(self, server, validation_resources):"},{"line_number":199,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":200,"context_line":"            self.get_server_ip(server, validation_resources),"},{"line_number":201,"context_line":"            self.image_ssh_user,"},{"line_number":202,"context_line":"            self.image_ssh_password,"},{"line_number":203,"context_line":"            validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":204,"context_line":"            server\u003dserver,"},{"line_number":205,"context_line":"            servers_client\u003dself.servers_client)"},{"line_number":206,"context_line":"        linux_client.validate_authentication()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def create_server("},{"line_number":209,"context_line":"            self, wait_until\u003d\u0027ACTIVE\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_6c9ece6a","line":206,"range":{"start_line":199,"start_character":0,"end_line":206,"end_character":46},"updated":"2019-03-29 21:20:57.000000000","message":"let\u0027s add below if condition in this method so that we do not need to worry about that every user needs to check that config option. \n\nif CONF.validation.run_validation:\n\nLater on we can move this method itself into test.py or inside the common.create_server with sshable/pingable flag.","commit_id":"a915d564e65434f525d51c71b89d3c6ec56284b8"}],"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"92b8065d1796a3f5bca7fe49238b86951353852a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # Create a server and attach it"},{"line_number":84,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":85,"context_line":"            self.os_primary)"},{"line_number":86,"context_line":"        server \u003d self.create_server(validation_resources\u003dvalidation_resources)"},{"line_number":87,"context_line":"        self.attach_volume(server[\u0027id\u0027], self.volume_origin[\u0027id\u0027])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Now that the volume is attached, create another snapshots"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7e6014a6","line":86,"updated":"2019-03-26 04:38:57.000000000","message":"validateable\u003dTrue is missing,\ncan you move it to the base class ?","commit_id":"b47a08881efd8554b297ad27f3aca165d00ca83b"}],"tempest/test.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3c4323738d2944c8d05da5ff12ae615e2729cae","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        Based on the configuration we\u0027re in, return a correct ip"},{"line_number":703,"context_line":"        address for validating that a guest is up."},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        :param server: The server dict as returned by the API"},{"line_number":706,"context_line":"        :param validation_resources: The dict of validation resources"},{"line_number":707,"context_line":"            provisioned for the server."},{"line_number":708,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_3746bcc2","line":705,"range":{"start_line":705,"start_character":54,"end_line":705,"end_character":61},"updated":"2019-04-01 17:05:25.000000000","message":"this has been a problem on the usage of this method. nova return different server dict for different API. for example, POST, LIST will give shorter dict which does not have \u0027addressess\u0027 field which this method need @L717. This is returned by SHOW, List Detail API only. \n\nWe have fixed many usage of this method earlier by calling SHOW API before this method. \n\nAs this is in test.py which is a stable interface for tempest plugins, let\u0027s be more auto-corrective there.\n\n- add the above info about pass the full server dict which user can get by SHOW, List detail nova API only.\n- let\u0027s call the SHOW server with server[\u0027id\u0027] in the starting of this method if server[\u0027addresses\u0027] is not present. server[\u0027addresses\u0027] attribute is present or not can save the unnecessary SHOW call.","commit_id":"cbae6a9f2686fec46436bb70587cd2bab58eea66"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8bbbcb6fc331f42e4f3777046eb4a33f168ee4f","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        Based on the configuration we\u0027re in, return a correct ip"},{"line_number":703,"context_line":"        address for validating that a guest is up."},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        :param server: The server dict as returned by the API"},{"line_number":706,"context_line":"        :param validation_resources: The dict of validation resources"},{"line_number":707,"context_line":"            provisioned for the server."},{"line_number":708,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_d785f8d0","line":705,"range":{"start_line":705,"start_character":54,"end_line":705,"end_character":61},"in_reply_to":"5fc1f717_3746bcc2","updated":"2019-04-01 17:08:22.000000000","message":"or if we do call SHOW API in case of connect_method \u003d\u003d \u0027fixed\u0027 that will be more optimized.\n\ninside L716 elif","commit_id":"cbae6a9f2686fec46436bb70587cd2bab58eea66"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59d4610ac06e11b2e6bf3c4d66f2e7182fa24926","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        Based on the configuration we\u0027re in, return a correct ip"},{"line_number":703,"context_line":"        address for validating that a guest is up."},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        :param server: The server dict as returned by the API"},{"line_number":706,"context_line":"        :param validation_resources: The dict of validation resources"},{"line_number":707,"context_line":"            provisioned for the server."},{"line_number":708,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_7e172647","line":705,"range":{"start_line":705,"start_character":54,"end_line":705,"end_character":61},"in_reply_to":"5fc1f717_8e9d0e59","updated":"2019-04-02 16:45:22.000000000","message":"we can instantiate the manager here but we need to know the credentials_type of test calling this method. we can fall back in credentials_type one by one. But all these are too hacky.\n\nLet\u0027s improve the doc string only and state that user need to pass complete server dict which they get from SHOW, or List detail API.\n\nalong with that, can we catch the attribute error at 717 and raise error with appropriate msg.","commit_id":"cbae6a9f2686fec46436bb70587cd2bab58eea66"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"bea7d08b6fb02b84879ad683388682598bc600b2","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        Based on the configuration we\u0027re in, return a correct ip"},{"line_number":703,"context_line":"        address for validating that a guest is up."},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"        :param server: The server dict as returned by the API"},{"line_number":706,"context_line":"        :param validation_resources: The dict of validation resources"},{"line_number":707,"context_line":"            provisioned for the server."},{"line_number":708,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_8e9d0e59","line":705,"range":{"start_line":705,"start_character":54,"end_line":705,"end_character":61},"in_reply_to":"5fc1f717_d785f8d0","updated":"2019-04-02 07:13:59.000000000","message":"No authentication context used in this method,\nWhich creads should be used for the show api request ?","commit_id":"cbae6a9f2686fec46436bb70587cd2bab58eea66"}]}