)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e9f101938faebd6fb4869fa86c7a3eccc7033d7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Init placement client in tempest Manager object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Placement client is not yet added/initialized in"},{"line_number":10,"context_line":"the tempest/clients.py Manager object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I19224b178e2860ee29c56546340cee36cd71b0e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_5fd38460","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":38},"updated":"2019-03-29 09:04:59.000000000","message":"Thanks, In this patch:\nhttps://review.openstack.org/#/c/629253/13/tempest/clients.py@48\nI added to manager only when I start using it, for me no problem to add independently of my tests.","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"ad086c40fb7a9c06136b084065fb36be3d378f0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Init placement client in tempest Manager object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Placement client is not yet added/initialized in"},{"line_number":10,"context_line":"the tempest/clients.py Manager object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I19224b178e2860ee29c56546340cee36cd71b0e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_58cb7e49","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":38},"in_reply_to":"5fc1f717_0f3b7cc8","updated":"2019-04-01 13:37:04.000000000","message":"Done","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"07790cdd882d99c8661f28ca66c33cb231f229b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Init placement client in tempest Manager object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Placement client is not yet added/initialized in"},{"line_number":10,"context_line":"the tempest/clients.py Manager object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I19224b178e2860ee29c56546340cee36cd71b0e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_a156062a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":38},"in_reply_to":"5fc1f717_5fd38460","updated":"2019-03-29 15:44:02.000000000","message":"Thanks! also, i wanted this to be merged sooner","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4c6bdcf26241fa1ed5057144d8864dece95e8d00","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Init placement client in tempest Manager object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Placement client is not yet added/initialized in"},{"line_number":10,"context_line":"the tempest/clients.py Manager object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I19224b178e2860ee29c56546340cee36cd71b0e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_0f3b7cc8","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":38},"in_reply_to":"5fc1f717_a156062a","updated":"2019-03-29 22:13:15.000000000","message":"Either way is ok for me. if we need to make placement client in manager soon then we can merge this first and then 629253.\n\nas 629253 doing, you need to add the placement client in tempest/tests/lib/services/registry_fixture.py also","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"}],"tempest/clients.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"df06d6666eba4803af02b92b92137ce7b06d4fa6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._set_object_storage_clients()"},{"line_number":45,"context_line":"        self._set_image_clients()"},{"line_number":46,"context_line":"        self._set_network_clients()"},{"line_number":47,"context_line":"        self.placement_client \u003d self.placement.PlacementClient()"},{"line_number":48,"context_line":"        # TODO(andreaf) This is maintained for backward compatibility"},{"line_number":49,"context_line":"        # with plugins, but it should removed eventually, since it was"},{"line_number":50,"context_line":"        # never a stable interface and it\u0027s not useful anyways"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_8af1b56d","line":47,"updated":"2019-03-28 18:48:51.000000000","message":"As tempest supports different OpenStack releases, does this work also for the placement service in-tree, before the split?","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"fc5e0c15ff69ad1f1e180425fba5f204ba181c39","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._set_object_storage_clients()"},{"line_number":45,"context_line":"        self._set_image_clients()"},{"line_number":46,"context_line":"        self._set_network_clients()"},{"line_number":47,"context_line":"        self.placement_client \u003d self.placement.PlacementClient()"},{"line_number":48,"context_line":"        # TODO(andreaf) This is maintained for backward compatibility"},{"line_number":49,"context_line":"        # with plugins, but it should removed eventually, since it was"},{"line_number":50,"context_line":"        # never a stable interface and it\u0027s not useful anyways"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ea7879c1","line":47,"in_reply_to":"5fc1f717_8af1b56d","updated":"2019-03-28 18:55:27.000000000","message":"@gmann can you answer this?","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4c6bdcf26241fa1ed5057144d8864dece95e8d00","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._set_object_storage_clients()"},{"line_number":45,"context_line":"        self._set_image_clients()"},{"line_number":46,"context_line":"        self._set_network_clients()"},{"line_number":47,"context_line":"        self.placement_client \u003d self.placement.PlacementClient()"},{"line_number":48,"context_line":"        # TODO(andreaf) This is maintained for backward compatibility"},{"line_number":49,"context_line":"        # with plugins, but it should removed eventually, since it was"},{"line_number":50,"context_line":"        # never a stable interface and it\u0027s not useful anyways"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_cc8ca2d9","line":47,"in_reply_to":"5fc1f717_dff9b4c7","updated":"2019-03-29 22:13:15.000000000","message":"yeah, as long as tempest gets the endpoint with catalog_type as \u0027placement\u0027 it is good.","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e9f101938faebd6fb4869fa86c7a3eccc7033d7e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._set_object_storage_clients()"},{"line_number":45,"context_line":"        self._set_image_clients()"},{"line_number":46,"context_line":"        self._set_network_clients()"},{"line_number":47,"context_line":"        self.placement_client \u003d self.placement.PlacementClient()"},{"line_number":48,"context_line":"        # TODO(andreaf) This is maintained for backward compatibility"},{"line_number":49,"context_line":"        # with plugins, but it should removed eventually, since it was"},{"line_number":50,"context_line":"        # never a stable interface and it\u0027s not useful anyways"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_dff9b4c7","line":47,"in_reply_to":"5fc1f717_ea7879c1","updated":"2019-03-29 09:04:59.000000000","message":"If I understand well it will work based on the endpoints given by keystone, so there is no difference if placement is nova in-tree or split to separate repo.","commit_id":"a0b075bed92b18443ecbda63a4338962ce1dba5d"}]}