)]}'
{"tempest/api/network/admin/test_lbaas_agent_scheduler.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3a04c9019c33f2464d6b1014f19ad13c658304bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9qg8%3D","line":2,"updated":"2014-02-05 08:11:41.000000000","message":"nit: please remove the above two lines.\n\nwe have removed a lot of these lines already.","commit_id":"bfe5cbe3fe6a374529ef74805e01e87b9db955df"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3a04c9019c33f2464d6b1014f19ad13c658304bb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LBaaSAgentSchedulerJSON(base.BaseAdminNetworkTest):"},{"line_number":23,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9qhE%3D","line":22,"updated":"2014-02-05 08:11:41.000000000","message":"Please add \"Test\" for showing test class clearly.\n\ns/LBaaSAgentSchedulerJSON/LBaaSAgentSchedulerTestJSON/","commit_id":"bfe5cbe3fe6a374529ef74805e01e87b9db955df"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3a04c9019c33f2464d6b1014f19ad13c658304bb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertEqual(\u0027Loadbalancer agent\u0027, body[\u0027agent\u0027][\u0027agent_type\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"class LBaaSAgentSchedulerXML(LBaaSAgentSchedulerJSON):"},{"line_number":76,"context_line":"    _interface \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9qgs%3D","line":75,"updated":"2014-02-05 08:11:41.000000000","message":"ditto\n\ns/LBaaSAgentSchedulerXML/LBaaSAgentSchedulerTestXML/","commit_id":"bfe5cbe3fe6a374529ef74805e01e87b9db955df"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2722fe49320a355079ff0f94fe403a9689141833","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":50,"context_line":"    def test_list_pools_on_lbaas_agent(self):"},{"line_number":51,"context_line":"        found \u003d False"},{"line_number":52,"context_line":"        resp, body \u003d self.admin_client.list_agents()"},{"line_number":53,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":54,"context_line":"        for a in agents:"},{"line_number":55,"context_line":"            if a[\u0027agent_type\u0027] \u003d\u003d \u0027Loadbalancer agent\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FcOA%3D","line":52,"updated":"2014-02-13 07:20:25.000000000","message":"How about to use a filter to only get lbaas agent?  In this way, it doesn\u0027t need to iterate all agents.\n\nresp, body \u003d self.admin_client.list_agents(agent_type\u003d\"Loadbalancer agent\")","commit_id":"d22172f5da654f3c0de10c3b50fddd6cbea31fbd"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2722fe49320a355079ff0f94fe403a9689141833","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                pools \u003d body[\u0027pools\u0027]"},{"line_number":61,"context_line":"                if self.pool[\u0027id\u0027] in [p[\u0027id\u0027] for p in pools]:"},{"line_number":62,"context_line":"                    found \u003d True"},{"line_number":63,"context_line":"        self.assertTrue(found)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":66,"context_line":"    def test_show_lbaas_agent_hosting_pool(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FcR8%3D","line":63,"updated":"2014-02-13 07:20:25.000000000","message":"better to add a message parameter in assertTrue to describe the failure.","commit_id":"d22172f5da654f3c0de10c3b50fddd6cbea31fbd"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2722fe49320a355079ff0f94fe403a9689141833","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(\u0027Loadbalancer agent\u0027, body[\u0027agent\u0027][\u0027agent_type\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class LBaaSAgentSchedulerXML(LBaaSAgentSchedulerTestJSON):"},{"line_number":74,"context_line":"    _interface \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FcNU%3D","line":73,"updated":"2014-02-13 07:20:25.000000000","message":"LBaaSAgentSchedulerXML -\u003e LBaaSAgentSchedulerTestXML","commit_id":"d22172f5da654f3c0de10c3b50fddd6cbea31fbd"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"563ccad6f61eb6671acc5c4446f2f6f53ff83d16","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            agent_type\u003d\"Loadbalancer agent\")"},{"line_number":54,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":55,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":56,"context_line":"        for a in agents:"},{"line_number":57,"context_line":"            msg \u003d \u0027Load Balancer agent expected\u0027"},{"line_number":58,"context_line":"            self.assertEqual(a[\u0027agent_type\u0027], \u0027Loadbalancer agent\u0027, msg)"},{"line_number":59,"context_line":"            resp, body \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FFuk%3D","line":56,"updated":"2014-02-17 07:57:52.000000000","message":"As here only list LBaaS agent, could the for loop be removed?","commit_id":"e5082c794690ec8ca15446d1809708138140ee8c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8ef263cde11b2612b71011f0e228b8ab2aaa6b15","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            agent_type\u003d\"Loadbalancer agent\")"},{"line_number":54,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":55,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":56,"context_line":"        for a in agents:"},{"line_number":57,"context_line":"            msg \u003d \u0027Load Balancer agent expected\u0027"},{"line_number":58,"context_line":"            self.assertEqual(a[\u0027agent_type\u0027], \u0027Loadbalancer agent\u0027, msg)"},{"line_number":59,"context_line":"            resp, body \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FADM%3D","line":56,"in_reply_to":"AAAAUX%2F%2FASo%3D","updated":"2014-02-17 18:05:18.000000000","message":"@Zhi Kun Liu\n\nFor further reference, please read the first paragraph in the document below. It clearly indicates that there may be many lbaas agents\n\nhttp://docs.openstack.org/api/openstack-network/2.0/content/Scheduler_LBaaS_Agent.html\n\nCheers","commit_id":"e5082c794690ec8ca15446d1809708138140ee8c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"80efdf2725f989d1bb6bdf9e81f98ffb0b1a4690","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            agent_type\u003d\"Loadbalancer agent\")"},{"line_number":54,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":55,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":56,"context_line":"        for a in agents:"},{"line_number":57,"context_line":"            msg \u003d \u0027Load Balancer agent expected\u0027"},{"line_number":58,"context_line":"            self.assertEqual(a[\u0027agent_type\u0027], \u0027Loadbalancer agent\u0027, msg)"},{"line_number":59,"context_line":"            resp, body \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FASo%3D","line":56,"in_reply_to":"AAAAUX%2F%2FFuk%3D","updated":"2014-02-17 17:37:44.000000000","message":"@Zhi Kun Liu\n\nThanks for your comment. Not really. There may be several load balancer agents. I am looking for the one hosting the pool I created in setUpClass. So I have to iterate over the list returned by the api above. Besides, I saw this as an opportunity to do one additional check of the api behavior. That\u0027s why I added the assert in line 58. I am making sure that the api only returned lbaas agents","commit_id":"e5082c794690ec8ca15446d1809708138140ee8c"}]}