)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"eec14fcf1b66d4dad6dcf75300be0e7ef8d2b9c5","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":325,"context_line":"        return snapshot"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _cleanup_volume_type(self, admin_volume_type_client, volume_type):"},{"line_number":328,"context_line":"        \"\"\"Clean up a given volume type."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        Ensuring all volumes associated to a type are first removed before"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5dd8ac50","line":327,"range":{"start_line":327,"start_character":35,"end_line":327,"end_character":59},"updated":"2019-04-09 15:29:13.000000000","message":"Does this need to be passed in or couldn\u0027t we just do what\u0027s on L336 for volume type client and initialize the client as a local variable instead?","commit_id":"87118e2598d901a4f9a90ae9974d9ac71b05f4d1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"50e1e5a135177cad45223f2349a69b9b1929fa75","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":325,"context_line":"        return snapshot"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _cleanup_volume_type(self, admin_volume_type_client, volume_type):"},{"line_number":328,"context_line":"        \"\"\"Clean up a given volume type."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        Ensuring all volumes associated to a type are first removed before"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_98d06121","line":327,"range":{"start_line":327,"start_character":35,"end_line":327,"end_character":59},"in_reply_to":"5fc1f717_5dd8ac50","updated":"2019-04-09 16:18:13.000000000","message":"It doesn\u0027t have to be passed no, happy to just initialise it within the method if you would prefer.","commit_id":"87118e2598d901a4f9a90ae9974d9ac71b05f4d1"}]}