)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.api.compute import api_microversion_fixture"},{"line_number":21,"context_line":"from tempest.common import compute"},{"line_number":22,"context_line":"from tempest.common import waiters"},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_f6a4a20a","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":56},"updated":"2019-04-13 15:33:17.000000000","message":"Do you want to issue deprecation warnings in places like http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/api_microversion_fixture.py#n23 to urge plugins to start using the new library interface instead?","commit_id":"69761f5a44ae8291dcb285512c0e943dc91596df"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5e213ad2190dbbb7648ed7e4513718baca34d81a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.api.compute import api_microversion_fixture"},{"line_number":21,"context_line":"from tempest.common import compute"},{"line_number":22,"context_line":"from tempest.common import waiters"},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_1e2fce3f","side":"PARENT","line":20,"updated":"2019-04-17 02:25:05.000000000","message":"FYI. According to the codesearch[0], there\u0027s no usage of this module in the master. I\u0027m fine with removing that in a following patch, though.\n\n[0] http://codesearch.openstack.org/?q\u003dAPIMicroversionFixture\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"69761f5a44ae8291dcb285512c0e943dc91596df"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"677b378ca71eb52e429df9b962b9586077ad67e3","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.api.compute import api_microversion_fixture"},{"line_number":21,"context_line":"from tempest.common import compute"},{"line_number":22,"context_line":"from tempest.common import waiters"},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_bee23a00","side":"PARENT","line":20,"in_reply_to":"3fce034c_1e2fce3f","updated":"2019-04-17 02:28:10.000000000","message":"yeah, we are always good team for not breaking anyone :) so we will fix them before we remove that from the tempest.","commit_id":"69761f5a44ae8291dcb285512c0e943dc91596df"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.api.compute import api_microversion_fixture"},{"line_number":21,"context_line":"from tempest.common import compute"},{"line_number":22,"context_line":"from tempest.common import waiters"},{"line_number":23,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_7cac138c","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":56},"in_reply_to":"3fce034c_f6a4a20a","updated":"2019-04-14 16:51:24.000000000","message":"these are not stable interface so we do not need to maintain them with a deprecation warning. For safer side, we can fix the plugins first if any of them are using those and then delete from tempest.","commit_id":"69761f5a44ae8291dcb285512c0e943dc91596df"}],"tempest/lib/common/api_microversion_fixture.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.lib.services.compute import base_compute_client"},{"line_number":18,"context_line":"from tempest.lib.services.placement import base_placement_client"},{"line_number":19,"context_line":"from tempest.lib.services.volume import base_client"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class APIMicroversionFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_b6ae1ae5","line":19,"range":{"start_line":19,"start_character":40,"end_line":19,"end_character":51},"updated":"2019-04-13 15:33:17.000000000","message":"nit: \"as base_volume_client\" will make code below a little bit more consistent, readable.","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.lib.services.compute import base_compute_client"},{"line_number":18,"context_line":"from tempest.lib.services.placement import base_placement_client"},{"line_number":19,"context_line":"from tempest.lib.services.volume import base_client"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class APIMicroversionFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_4c040616","line":19,"range":{"start_line":19,"start_character":40,"end_line":19,"end_character":51},"in_reply_to":"3fce034c_b6ae1ae5","updated":"2019-04-14 16:51:24.000000000","message":"Done","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    on service client. Service client has global variable to set the"},{"line_number":27,"context_line":"    microversion for that service API request."},{"line_number":28,"context_line":"    For example: base_compute_client.COMPUTE_MICROVERSION"},{"line_number":29,"context_line":"    global variable is always risky to set directly which can affect the"},{"line_number":30,"context_line":"    other test\u0027s API request also. This class provides a way to reset the"},{"line_number":31,"context_line":"    service microversion once test finish the API request."},{"line_number":32,"context_line":"    This class can be used with useFixture: Example:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_16aa8ed3","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":5},"updated":"2019-04-13 15:33:17.000000000","message":"G","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    on service client. Service client has global variable to set the"},{"line_number":27,"context_line":"    microversion for that service API request."},{"line_number":28,"context_line":"    For example: base_compute_client.COMPUTE_MICROVERSION"},{"line_number":29,"context_line":"    global variable is always risky to set directly which can affect the"},{"line_number":30,"context_line":"    other test\u0027s API request also. This class provides a way to reset the"},{"line_number":31,"context_line":"    service microversion once test finish the API request."},{"line_number":32,"context_line":"    This class can be used with useFixture: Example:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_ec085229","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":5},"in_reply_to":"3fce034c_16aa8ed3","updated":"2019-04-14 16:51:24.000000000","message":"Done","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    global variable is always risky to set directly which can affect the"},{"line_number":30,"context_line":"    other test\u0027s API request also. This class provides a way to reset the"},{"line_number":31,"context_line":"    service microversion once test finish the API request."},{"line_number":32,"context_line":"    This class can be used with useFixture: Example:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(BaseV2ComputeTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_d6aba6d3","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":52},"updated":"2019-04-13 15:33:17.000000000","message":"nit: If you make this \"::\" then indent the \"def setUp\" code block by 4 spaces it will render as code block.","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    global variable is always risky to set directly which can affect the"},{"line_number":30,"context_line":"    other test\u0027s API request also. This class provides a way to reset the"},{"line_number":31,"context_line":"    service microversion once test finish the API request."},{"line_number":32,"context_line":"    This class can be used with useFixture: Example:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(BaseV2ComputeTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_2cff3a02","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":52},"in_reply_to":"3fce034c_d6aba6d3","updated":"2019-04-14 16:51:24.000000000","message":"Done","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.useFixture(api_microversion_fixture.APIMicroversionFixture("},{"line_number":37,"context_line":"            compute_microversion\u003dself.compute_request_microversion))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Or you can set microversion on multiple services together."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(ScenarioTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_76b8b229","line":39,"range":{"start_line":39,"start_character":61,"end_line":39,"end_character":62},"updated":"2019-04-13 15:33:17.000000000","message":"Ditto.","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.useFixture(api_microversion_fixture.APIMicroversionFixture("},{"line_number":37,"context_line":"            compute_microversion\u003dself.compute_request_microversion))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Or you can set microversion on multiple services together."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(ScenarioTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_89042019","line":39,"range":{"start_line":39,"start_character":61,"end_line":39,"end_character":62},"in_reply_to":"3fce034c_76b8b229","updated":"2019-04-14 16:51:24.000000000","message":"Done","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            base_placement_client.PLACEMENT_MICROVERSION \u003d ("},{"line_number":75,"context_line":"                self.placement_microversion)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.addCleanup(self._reset_compute_microversion)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _reset_compute_microversion(self):"},{"line_number":80,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_5689f672","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":43},"updated":"2019-04-13 15:33:17.000000000","message":"all or service","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            base_placement_client.PLACEMENT_MICROVERSION \u003d ("},{"line_number":75,"context_line":"                self.placement_microversion)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.addCleanup(self._reset_compute_microversion)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _reset_compute_microversion(self):"},{"line_number":80,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_c90a2825","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":43},"in_reply_to":"3fce034c_5689f672","updated":"2019-04-14 16:51:24.000000000","message":"Done","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.addCleanup(self._reset_compute_microversion)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _reset_compute_microversion(self):"},{"line_number":80,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d None"},{"line_number":81,"context_line":"        base_client.VOLUME_MICROVERSION \u003d None"},{"line_number":82,"context_line":"        base_placement_client.PLACEMENT_MICROVERSION \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_96b51e34","line":79,"range":{"start_line":79,"start_character":15,"end_line":79,"end_character":22},"updated":"2019-04-13 15:33:17.000000000","message":"all or service","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dea15c81b87d0f1a66df20a6a552afa185ceb501","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.addCleanup(self._reset_compute_microversion)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _reset_compute_microversion(self):"},{"line_number":80,"context_line":"        base_compute_client.COMPUTE_MICROVERSION \u003d None"},{"line_number":81,"context_line":"        base_client.VOLUME_MICROVERSION \u003d None"},{"line_number":82,"context_line":"        base_placement_client.PLACEMENT_MICROVERSION \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_6907741e","line":79,"range":{"start_line":79,"start_character":15,"end_line":79,"end_character":22},"in_reply_to":"3fce034c_96b51e34","updated":"2019-04-14 16:51:24.000000000","message":"Done","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"}],"tempest/tests/lib/test_api_microversion_fixture.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8292da2c6dbb1205d1ec81700c72ffc1293c0c78","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TestAPIMicroversionFixture(base.TestCase):"},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(TestAPIMicroversionFixture, self).setUp()"},{"line_number":25,"context_line":"        # Verify that all the microversion are reset back to None"},{"line_number":26,"context_line":"        # by Fixture."},{"line_number":27,"context_line":"        self.assertIsNone(base_compute_client.COMPUTE_MICROVERSION)"},{"line_number":28,"context_line":"        self.assertIsNone(base_client.VOLUME_MICROVERSION)"},{"line_number":29,"context_line":"        self.assertIsNone(base_placement_client.PLACEMENT_MICROVERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_36846a5e","line":26,"range":{"start_line":25,"start_character":8,"end_line":26,"end_character":21},"updated":"2019-04-13 15:33:17.000000000","message":"Nice, +1","commit_id":"f1a407693d2840649f15b069c493e7bb4138885b"}]}