)]}'
{"tempest/api/compute/servers/test_list_server_filters.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"342f858c4b4cb31fdf18c48cda445a77cef006ea","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # Verify only the expected number of servers are returned"},{"line_number":134,"context_line":"        params \u003d {\u0027limit\u0027: 0}"},{"line_number":135,"context_line":"        resp, servers \u003d self.client.list_servers(params)"},{"line_number":136,"context_line":"        # when _interface\u003d\u0027xml\u0027, zero element for servers_links in servers"},{"line_number":137,"context_line":"        self.assertEqual(0, len([x for x in servers[\u0027servers\u0027] if \u0027id\u0027 in x]))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Fzgo%3D","line":136,"updated":"2014-01-08 08:57:07.000000000","message":"Per my understanding, when _interface\u003d\u0027xml\u0027, list_servers return servers list, but it has an extra item \"servers_links\". The size of list is servers_number + 1.  So it uses \"[x for x in servers[\u0027servers\u0027] if \u0027id\u0027 in x]\" to filter the item \u0027servers_links\u0027 by checking \u0027id\u0027.\n\nPlease check if servers_links is in xml response data of list_servers when limit\u003d0. If yes, the comment should be \"# when _interface\u003d\u0027xml\u0027, one element for servers_links in servers\". If no, it don\u0027t need the comment line and the assert could be \"self.assertEqual(0, len(servers[\u0027servers\u0027]))\"","commit_id":"ee58c9a512e50659ec5d6af6e30762cfa8490c7b"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"11b08fd2a2ab7188296700dc2880edb77c8c2a56","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # Verify only the expected number of servers are returned"},{"line_number":134,"context_line":"        params \u003d {\u0027limit\u0027: 0}"},{"line_number":135,"context_line":"        resp, servers \u003d self.client.list_servers(params)"},{"line_number":136,"context_line":"        # when _interface\u003d\u0027xml\u0027, zero element for servers_links in servers"},{"line_number":137,"context_line":"        self.assertEqual(0, len([x for x in servers[\u0027servers\u0027] if \u0027id\u0027 in x]))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Fyp8%3D","line":136,"in_reply_to":"AAAAUH%2F%2Fzgo%3D","updated":"2014-01-08 12:39:39.000000000","message":"Thanks for the comments. this annotation means that when _interface \u003d \u0027xml\u0027, there is no servers_links element as JSON format under servers, but not has an extra item. So I will remove the comment.","commit_id":"ee58c9a512e50659ec5d6af6e30762cfa8490c7b"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"342f858c4b4cb31fdf18c48cda445a77cef006ea","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        # Verify only the expected number of servers are returned"},{"line_number":142,"context_line":"        params \u003d {\u0027limit\u0027: 100000}"},{"line_number":143,"context_line":"        resp, servers \u003d self.client.list_servers(params)"},{"line_number":144,"context_line":"        resp, all_servers \u003d self.client.list_servers()"},{"line_number":145,"context_line":"        self.assertEqual(len([x for x in all_servers[\u0027servers\u0027] if \u0027id\u0027 in x]),"},{"line_number":146,"context_line":"                         len([x for x in servers[\u0027servers\u0027] if \u0027id\u0027 in x]))"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FzgQ%3D","line":144,"updated":"2014-01-08 08:57:07.000000000","message":"same comment","commit_id":"ee58c9a512e50659ec5d6af6e30762cfa8490c7b"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"11b08fd2a2ab7188296700dc2880edb77c8c2a56","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        # Verify only the expected number of servers are returned"},{"line_number":142,"context_line":"        params \u003d {\u0027limit\u0027: 100000}"},{"line_number":143,"context_line":"        resp, servers \u003d self.client.list_servers(params)"},{"line_number":144,"context_line":"        resp, all_servers \u003d self.client.list_servers()"},{"line_number":145,"context_line":"        self.assertEqual(len([x for x in all_servers[\u0027servers\u0027] if \u0027id\u0027 in x]),"},{"line_number":146,"context_line":"                         len([x for x in servers[\u0027servers\u0027] if \u0027id\u0027 in x]))"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Fym8%3D","line":144,"in_reply_to":"AAAAUH%2F%2FzgQ%3D","updated":"2014-01-08 12:39:39.000000000","message":"This could be remain as what it looks like.","commit_id":"ee58c9a512e50659ec5d6af6e30762cfa8490c7b"}]}