)]}'
{"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"6a4fe8dd02208d74900bd91f71e36e2d168f2201","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def test_create_server_with_default_flavor_name(self):"},{"line_number":133,"context_line":"        # use_default_flavor_name m1.tiny"},{"line_number":134,"context_line":"        resp, server \u003d self.create_test_server(flavor\u003d\u0027m1.tiny\u0027,"},{"line_number":135,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class ServersTestXML(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F4go%3D","line":135,"updated":"2014-01-07 09:14:36.000000000","message":"what do you test? It should be verified. And make same change in nova v3 tests, please.","commit_id":"e187b9bbf3b41af86d5cd16b5b834dc9d4989dc3"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"0fd8f6096acf9ec01207d8d7ec283637e2ca2efb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def test_create_server_with_default_flavor_name(self):"},{"line_number":133,"context_line":"        # use_default_flavor_name m1.tiny"},{"line_number":134,"context_line":"        resp, server \u003d self.create_test_server(flavor\u003d\u0027m1.tiny\u0027,"},{"line_number":135,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class ServersTestXML(ServersTestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F4ZM%3D","line":135,"in_reply_to":"AAAAUH%2F%2F4go%3D","updated":"2014-01-07 09:50:01.000000000","message":"test boot instance with default flavor name.","commit_id":"e187b9bbf3b41af86d5cd16b5b834dc9d4989dc3"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a9ef6188c005ac41bc4c966ef1a39661f1e599ed","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":132,"context_line":"    def test_create_server_with_default_flavor_name(self):"},{"line_number":133,"context_line":"        # use_default_flavor_name m1.tiny"},{"line_number":134,"context_line":"        resp, server \u003d self.create_test_server(flavor\u003d\u0027m1.tiny\u0027,"},{"line_number":135,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":136,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":137,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F4Fg%3D","line":134,"updated":"2014-01-07 10:44:13.000000000","message":"If you set the flavor here it is not a \"default\" value. So you only check the id with get_flavor_details and this already checked in test_verify_server_details (api/compute/servers/test_create_server.py).","commit_id":"e2f0a14f986ffb99b052cdf3b72cb458c4b9ed00"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"beed8eaf3167a7d63a9e56499a7de9b4d5e880d4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":132,"context_line":"    def test_create_server_with_default_flavor_name(self):"},{"line_number":133,"context_line":"        # use_default_flavor_name m1.tiny"},{"line_number":134,"context_line":"        resp, server \u003d self.create_test_server(flavor\u003d\u0027m1.tiny\u0027,"},{"line_number":135,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":136,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":137,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F3mw%3D","line":134,"in_reply_to":"AAAAUH%2F%2F4Fg%3D","updated":"2014-01-07 12:57:42.000000000","message":"Hi, if this not the default value, how do we test with default flavor to create the server? BTW, thanks for the comments","commit_id":"e2f0a14f986ffb99b052cdf3b72cb458c4b9ed00"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"a6ad560c1cb51b6c6367b6088d9114313974fd63","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"},{"line_number":138,"context_line":"        flavor_id \u003d server[\u0027flavor\u0027]"},{"line_number":139,"context_line":"        resp, flavor_detail \u003d self.flavors_client.get_flavor_details("},{"line_number":140,"context_line":"            flavor_id[\u0027id\u0027])"},{"line_number":141,"context_line":"        self.assertEqual(resp.status, 200)"},{"line_number":142,"context_line":"        self.assertEqual(flavor_detail[\u0027name\u0027], \u0027m1.tiny\u0027)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F4SQ%3D","line":140,"updated":"2014-01-07 09:53:40.000000000","message":"Why we need flavor deatils ??","commit_id":"e2f0a14f986ffb99b052cdf3b72cb458c4b9ed00"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"193287a18cfbda0a6cdd6cdac4addad4096fbabe","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"},{"line_number":138,"context_line":"        flavor_id \u003d server[\u0027flavor\u0027]"},{"line_number":139,"context_line":"        resp, flavor_detail \u003d self.flavors_client.get_flavor_details("},{"line_number":140,"context_line":"            flavor_id[\u0027id\u0027])"},{"line_number":141,"context_line":"        self.assertEqual(resp.status, 200)"},{"line_number":142,"context_line":"        self.assertEqual(flavor_detail[\u0027name\u0027], \u0027m1.tiny\u0027)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F4Ow%3D","line":140,"in_reply_to":"AAAAUH%2F%2F4SQ%3D","updated":"2014-01-07 10:06:18.000000000","message":"We need to find the flavor name through this. Thanks for the comments.","commit_id":"e2f0a14f986ffb99b052cdf3b72cb458c4b9ed00"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0ad2d53b20b08062895c4d49ea6b344926127f76","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def test_create_server_with_default_flavor_name(self):"},{"line_number":133,"context_line":"        # use_default_flavor_name m1.tiny"},{"line_number":134,"context_line":"        resp, server \u003d self.create_test_server(flavor\u003d\u0027m1.tiny\u0027,"},{"line_number":135,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":136,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":137,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"},{"line_number":138,"context_line":"        flavor_id \u003d server[\u0027flavor\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fuv8%3D","line":135,"updated":"2014-01-09 04:01:07.000000000","message":"We can remove any flavors from nova with \"nova flavor-delete\" command.\n\n $ nova flavor-delete m1.tiny\n +----+---------+-----------+------+-----------+------+-------+-------------+-----------+\n | ID | Name    | Memory_MB | Disk | Ephemeral | Swap | VCPUs | RXTX_Factor | Is_Public |\n +----+---------+-----------+------+-----------+------+-------+-------------+-----------+\n | 1  | m1.tiny | 512       | 1    | 0         |      | 1     | 1.0         | True      |\n +----+---------+-----------+------+-----------+------+-------+-------------+-----------+\n\nTempest is not only for gate/check tests of Jenkins.\nWe can use Tempest for production environments also.\n\nIf applying this patch, this test fails in some environments which don\u0027t contain m1.tiny.\nI guess that is reason why Tempest has configurable flavor in etc/tempest.conf.\n\nSo we cannot add this test.","commit_id":"898cbbc8016a3a3619f2bf61a78769ccf3b6608d"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"320dde87087bde00436215df30ade32a537165c0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def test_create_server_with_default_flavor_name(self):"},{"line_number":133,"context_line":"        # use_default_flavor_name m1.tiny"},{"line_number":134,"context_line":"        resp, server \u003d self.create_test_server(flavor\u003d\u0027m1.tiny\u0027,"},{"line_number":135,"context_line":"                                               wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":136,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":137,"context_line":"        resp, server \u003d self.client.get_server(server[\u0027id\u0027])"},{"line_number":138,"context_line":"        flavor_id \u003d server[\u0027flavor\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FuvI%3D","line":135,"in_reply_to":"AAAAUH%2F%2Fuv8%3D","updated":"2014-01-09 04:04:43.000000000","message":"Thanks.\nI got u and I will abandon this test.","commit_id":"898cbbc8016a3a3619f2bf61a78769ccf3b6608d"}]}