)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d7d1edae7dedfb7904ce0a99dc09f4b920e11e16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix invalid filter passed to list_volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"display_name is not a valid filter for list_volumes, i.e.,"},{"line_number":10,"context_line":"no matter what value we set for display_name filter, all volumes"},{"line_number":11,"context_line":"will be returned. We should use name filter instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib25f4767b74d4494edfafa211d5884a01c1b6488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_8be06d98","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"updated":"2019-04-16 15:54:20.000000000","message":"yeah, display_name is not in valid filter list for volume list but it works as DB still has this field \n\nBut i agree that we should use \u0027name\u0027 instead. I am  +2 once you update this line :)\n\nhttps://github.com/openstack/cinder/blob/master/doc/source/admin/generalized_filters.rst","commit_id":"e1739ecdab0509f94187100f53d4263cc5f3233d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d31ae77e45681d40dc40d87f55dc5a7fd0f1e685","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix invalid filter passed to list_volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"display_name is not a valid filter for list_volumes, i.e.,"},{"line_number":10,"context_line":"no matter what value we set for display_name filter, all volumes"},{"line_number":11,"context_line":"will be returned. We should use name filter instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib25f4767b74d4494edfafa211d5884a01c1b6488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_a328e5e1","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"3fce034c_430901db","updated":"2019-04-17 01:50:51.000000000","message":"Yes I tested just now and what you said is True.\nWith non-admin \u0027display_name\u0027 filter will return all and with admin \u0027display_name\u0027 filter will return one.","commit_id":"e1739ecdab0509f94187100f53d4263cc5f3233d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fbd647f8fe42ebd47ee7c09091662da2a9605a6e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix invalid filter passed to list_volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"display_name is not a valid filter for list_volumes, i.e.,"},{"line_number":10,"context_line":"no matter what value we set for display_name filter, all volumes"},{"line_number":11,"context_line":"will be returned. We should use name filter instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib25f4767b74d4494edfafa211d5884a01c1b6488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_430901db","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"3fce034c_63c0bd7c","updated":"2019-04-17 01:35:18.000000000","message":"is it? I tested locally and display_name work fine same as name. are you running with admin or non-admin? because for non-admin cinder will ignore the \u0027display_name\u0027 and return all.","commit_id":"e1739ecdab0509f94187100f53d4263cc5f3233d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"18131c9ffd8411c3a837c6e9d281d9f635c6aeb3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix invalid filter passed to list_volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"display_name is not a valid filter for list_volumes, i.e.,"},{"line_number":10,"context_line":"no matter what value we set for display_name filter, all volumes"},{"line_number":11,"context_line":"will be returned. We should use name filter instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib25f4767b74d4494edfafa211d5884a01c1b6488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_63c0bd7c","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"3fce034c_8be06d98","updated":"2019-04-17 01:29:24.000000000","message":"\"no matter what value we set for display_name filter, all volumes\nwill be returned\" is the conclusion after I test it in the environment:)\nself.volumes_client.list_volumes(params\u003d{\u0027name\u0027: v_name})\nreturns one volume,\nand self.volumes_client.list_volumes(params\u003d{\u0027display_name\u0027: v_name})\nreturns all volumes.","commit_id":"e1739ecdab0509f94187100f53d4263cc5f3233d"}]}