)]}'
{"tools/verify_tempest_config.py":[{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"57263f3404fb253e54e2c81b61ac55a986ad3e63","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027nova_v3\u0027: os.extensions_v3_client,"},{"line_number":43,"context_line":"        \u0027cinder\u0027: os.volumes_extension_client,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"    if service not in extensions_client.keys():"},{"line_number":46,"context_line":"        print(\u0027No tempest extensions client for %s\u0027 % service)"},{"line_number":47,"context_line":"        exit(1)"},{"line_number":48,"context_line":"    return extensions_client.get(service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWyE%3D","line":45,"updated":"2014-01-14 17:52:39.000000000","message":"You\u0027re creating a list uselessly. It would be better if you just tested like this:\n\nif service not in extensions_client:\n   ...","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69f959b2c93d44cbb87cf9534e218a636f41cdf6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027nova_v3\u0027: os.extensions_v3_client,"},{"line_number":43,"context_line":"        \u0027cinder\u0027: os.volumes_extension_client,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"    if service not in extensions_client.keys():"},{"line_number":46,"context_line":"        print(\u0027No tempest extensions client for %s\u0027 % service)"},{"line_number":47,"context_line":"        exit(1)"},{"line_number":48,"context_line":"    return extensions_client.get(service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWow%3D","line":45,"in_reply_to":"AAAAUH%2F%2FWyE%3D","updated":"2014-01-14 18:22:25.000000000","message":"Done","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"57263f3404fb253e54e2c81b61ac55a986ad3e63","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if service not in extensions_client.keys():"},{"line_number":46,"context_line":"        print(\u0027No tempest extensions client for %s\u0027 % service)"},{"line_number":47,"context_line":"        exit(1)"},{"line_number":48,"context_line":"    return extensions_client.get(service)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_enabled_extensions(service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWyA%3D","line":48,"updated":"2014-01-14 17:52:39.000000000","message":"(minor nitpick) Since we\u0027re sure that service is in extensions_client, why not simply return extensions_client[service] ?","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69f959b2c93d44cbb87cf9534e218a636f41cdf6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if service not in extensions_client.keys():"},{"line_number":46,"context_line":"        print(\u0027No tempest extensions client for %s\u0027 % service)"},{"line_number":47,"context_line":"        exit(1)"},{"line_number":48,"context_line":"    return extensions_client.get(service)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_enabled_extensions(service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWos%3D","line":48,"in_reply_to":"AAAAUH%2F%2FWyA%3D","updated":"2014-01-14 18:22:25.000000000","message":"Done","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"57263f3404fb253e54e2c81b61ac55a986ad3e63","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \u0027nova_v3\u0027: CONF.compute_feature_enabled.api_v3_extensions,"},{"line_number":55,"context_line":"        \u0027cinder\u0027: CONF.volume_feature_enabled.api_extensions,"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"    if service not in extensions_options.keys():"},{"line_number":58,"context_line":"        print(\u0027No supported extensions list option for %s\u0027 % service)"},{"line_number":59,"context_line":"        exit(1)"},{"line_number":60,"context_line":"    return extensions_options.get(service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWx8%3D","line":57,"updated":"2014-01-14 17:52:39.000000000","message":"Same as above.","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69f959b2c93d44cbb87cf9534e218a636f41cdf6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \u0027nova_v3\u0027: CONF.compute_feature_enabled.api_v3_extensions,"},{"line_number":55,"context_line":"        \u0027cinder\u0027: CONF.volume_feature_enabled.api_extensions,"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"    if service not in extensions_options.keys():"},{"line_number":58,"context_line":"        print(\u0027No supported extensions list option for %s\u0027 % service)"},{"line_number":59,"context_line":"        exit(1)"},{"line_number":60,"context_line":"    return extensions_options.get(service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWoo%3D","line":57,"in_reply_to":"AAAAUH%2F%2FWx8%3D","updated":"2014-01-14 18:22:25.000000000","message":"Done","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"57263f3404fb253e54e2c81b61ac55a986ad3e63","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if service not in extensions_options.keys():"},{"line_number":58,"context_line":"        print(\u0027No supported extensions list option for %s\u0027 % service)"},{"line_number":59,"context_line":"        exit(1)"},{"line_number":60,"context_line":"    return extensions_options.get(service)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def verify_extensions(os, service, results):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWx4%3D","line":60,"updated":"2014-01-14 17:52:39.000000000","message":"(minor nitpick) Same as above.","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69f959b2c93d44cbb87cf9534e218a636f41cdf6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if service not in extensions_options.keys():"},{"line_number":58,"context_line":"        print(\u0027No supported extensions list option for %s\u0027 % service)"},{"line_number":59,"context_line":"        exit(1)"},{"line_number":60,"context_line":"    return extensions_options.get(service)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def verify_extensions(os, service, results):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWok%3D","line":60,"in_reply_to":"AAAAUH%2F%2FWx4%3D","updated":"2014-01-14 18:22:25.000000000","message":"Done","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"57263f3404fb253e54e2c81b61ac55a986ad3e63","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if extension in extensions:"},{"line_number":79,"context_line":"            results[service][extension] \u003d True"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            results[service][extension] \u003d False"},{"line_number":82,"context_line":"    # Verify that there aren\u0027t additional extensions enabled that aren\u0027t"},{"line_number":83,"context_line":"    # specified in the config list"},{"line_number":84,"context_line":"    for extension in extensions:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWxg%3D","line":81,"updated":"2014-01-14 17:52:39.000000000","message":"(minor nitpick) Wouldn\u0027t it be simpler to simply write?\n\nresults[service][extension] \u003d extension in extensions","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69f959b2c93d44cbb87cf9534e218a636f41cdf6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if extension in extensions:"},{"line_number":79,"context_line":"            results[service][extension] \u003d True"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            results[service][extension] \u003d False"},{"line_number":82,"context_line":"    # Verify that there aren\u0027t additional extensions enabled that aren\u0027t"},{"line_number":83,"context_line":"    # specified in the config list"},{"line_number":84,"context_line":"    for extension in extensions:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FWuE%3D","line":81,"in_reply_to":"AAAAUH%2F%2FWxg%3D","updated":"2014-01-14 18:22:25.000000000","message":"Done","commit_id":"a0a33fe4f00c10a382b10d0915344e51a926147e"}]}