)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"399fcef1ac9ea7b9e5b5d4ef03567f48e614f064","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to be used in cleanup of Neutron resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c394d3219e16f653343d7043d36f55048f211dd"},{"line_number":15,"context_line":"Closes-Bug: #1824018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_19bda8d7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"updated":"2019-04-17 03:30:03.000000000","message":"In which it says \"cleanup of neutron resources (e.g. network, subnet, port or router) may fail because DELETE request will be processed for very long time by neutron and retried request will got response 404\", and I\u0027m curious about whether this is True?\n\nUsually we use call_and_ignore_notfound_exc for resources that may be deleted in other steps in testcases, but for those resources that are obviously nowhere else to delete them, to add call_and_ignore_notfound_exc seems strange.","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d26ec3639716949712ddcfd3e5e5bde31a14a298","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to be used in cleanup of Neutron resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c394d3219e16f653343d7043d36f55048f211dd"},{"line_number":15,"context_line":"Closes-Bug: #1824018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_95f38d0a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3fce034c_19bda8d7","updated":"2019-04-17 15:39:48.000000000","message":"But having failed test just because response from neutron was slow is not odd?\nIMO in cleanup method it shouldn\u0027t be so big problem to ignore 404 responses.","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d40bca194c006f9f8149754a5c0f2937f41435d6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to be used in cleanup of Neutron resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c394d3219e16f653343d7043d36f55048f211dd"},{"line_number":15,"context_line":"Closes-Bug: #1824018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_dcba926c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3fce034c_95f38d0a","updated":"2019-04-18 08:22:53.000000000","message":"Yes it\u0027s no big problem to ignore 404 in cleanup, and I just want to make the things clear, after all, to get 404 because neutron is slow is a bit odd:)","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"743b1f5a34aee75d4693518aa67f1681def71d75","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to be used in cleanup of Neutron resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c394d3219e16f653343d7043d36f55048f211dd"},{"line_number":15,"context_line":"Closes-Bug: #1824018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_d7da6b49","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3fce034c_9c5e4a42","updated":"2019-04-18 08:51:43.000000000","message":"I see, so I won\u0027t block this and let\u0027s just wait for more opinions:)","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to be used in cleanup of Neutron resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c394d3219e16f653343d7043d36f55048f211dd"},{"line_number":15,"context_line":"Closes-Bug: #1824018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_496644f0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3fce034c_d7da6b49","updated":"2019-04-22 21:34:48.000000000","message":"I am ok to add the 404-ignore in addCleanup methods which are added mainly to cleanup the test env not for the test verification. \n\nThough zhufl has good point about why that happens. so as long as we have specific delete test verifying the delete behaviour we should be good here. We will go case by case for the modified test and check if 404-ignore is bad there.","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"20fb55c2ad9151c7f4cad44566cadf67d1356c8c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to be used in cleanup of Neutron resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2c394d3219e16f653343d7043d36f55048f211dd"},{"line_number":15,"context_line":"Closes-Bug: #1824018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_9c5e4a42","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3fce034c_dcba926c","updated":"2019-04-18 08:25:56.000000000","message":"I agree that this is only workaround of problem which root cause is in neutron. But we don\u0027t have solution for it (at least for now) so I think that this is better than nothing :)","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}],"tempest/api/network/base_security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        group_create_body \u003d ("},{"line_number":27,"context_line":"            self.security_groups_client.create_security_group(name\u003dname))"},{"line_number":28,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":29,"context_line":"                        self._delete_security_group,"},{"line_number":30,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":31,"context_line":"        self.assertEqual(group_create_body[\u0027security_group\u0027][\u0027name\u0027], name)"},{"line_number":32,"context_line":"        return group_create_body, name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_4452a969","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":52},"updated":"2019-04-22 21:34:48.000000000","message":"this method is being used to verify the delete sec grp operation also. for example this test - https://github.com/openstack/tempest/blob/682965e392575a3f7ce0a15e397f691eec188c3f/tempest/api/network/test_security_groups.py#L82\n\neither we can leave this method to ignore the 404 or modify the test to explicitly test the delete request via calling self._delete_security_group() directly.","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8e543f28d914dc178656624191857bedff8f36","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        group_create_body \u003d ("},{"line_number":27,"context_line":"            self.security_groups_client.create_security_group(name\u003dname))"},{"line_number":28,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":29,"context_line":"                        self._delete_security_group,"},{"line_number":30,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":31,"context_line":"        self.assertEqual(group_create_body[\u0027security_group\u0027][\u0027name\u0027], name)"},{"line_number":32,"context_line":"        return group_create_body, name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_0bed4b24","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":52},"in_reply_to":"ffb9cba7_4452a969","updated":"2019-04-26 11:16:51.000000000","message":"Added deletion of SG in https://github.com/openstack/tempest/blob/682965e392575a3f7ce0a15e397f691eec188c3f/tempest/api/network/test_security_groups.py#L82","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}],"tempest/api/network/test_floating_ips.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            floating_network_id\u003dself.ext_net_id,"},{"line_number":79,"context_line":"            port_id\u003dself.ports[0][\u0027id\u0027])"},{"line_number":80,"context_line":"        created_floating_ip \u003d body[\u0027floatingip\u0027]"},{"line_number":81,"context_line":"        self.addCleanup("},{"line_number":82,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":83,"context_line":"            self.floating_ips_client.delete_floatingip,"},{"line_number":84,"context_line":"            created_floating_ip[\u0027id\u0027])"},{"line_number":85,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":87,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_c4677925","line":84,"range":{"start_line":81,"start_character":0,"end_line":84,"end_character":38},"updated":"2019-04-22 21:34:48.000000000","message":"this test needs to verify the delete operation also. \n\n+1 on adding 404-ignore in cleanup but can you add the explicit call to delete FIP at the end of this test.","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8e543f28d914dc178656624191857bedff8f36","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            floating_network_id\u003dself.ext_net_id,"},{"line_number":79,"context_line":"            port_id\u003dself.ports[0][\u0027id\u0027])"},{"line_number":80,"context_line":"        created_floating_ip \u003d body[\u0027floatingip\u0027]"},{"line_number":81,"context_line":"        self.addCleanup("},{"line_number":82,"context_line":"            test_utils.call_and_ignore_notfound_exc,"},{"line_number":83,"context_line":"            self.floating_ips_client.delete_floatingip,"},{"line_number":84,"context_line":"            created_floating_ip[\u0027id\u0027])"},{"line_number":85,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027id\u0027])"},{"line_number":86,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027tenant_id\u0027])"},{"line_number":87,"context_line":"        self.assertIsNotNone(created_floating_ip[\u0027floating_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_8bd85b7f","line":84,"range":{"start_line":81,"start_character":0,"end_line":84,"end_character":38},"in_reply_to":"ffb9cba7_c4677925","updated":"2019-04-26 11:16:51.000000000","message":"done","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}],"tempest/api/network/test_networks.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Create a network"},{"line_number":162,"context_line":"        network \u003d self.create_network()"},{"line_number":163,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":164,"context_line":"                        self.networks_client.delete_network, network[\u0027id\u0027])"},{"line_number":165,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":166,"context_line":"        self.assertEqual(\u0027ACTIVE\u0027, network[\u0027status\u0027])"},{"line_number":167,"context_line":"        # Verify network update"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_6921c89f","line":164,"range":{"start_line":164,"start_character":24,"end_line":164,"end_character":75},"updated":"2019-04-22 21:34:48.000000000","message":"this is delete test and ignoring the delete failure will modify this test behaviour. \n\nI am not sure why we do not have delete call explicitly.\n\nCan you add the delete call at the end of the test also then this ignoring 404 in addCleanup is good to go.","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8e543f28d914dc178656624191857bedff8f36","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Create a network"},{"line_number":162,"context_line":"        network \u003d self.create_network()"},{"line_number":163,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":164,"context_line":"                        self.networks_client.delete_network, network[\u0027id\u0027])"},{"line_number":165,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":166,"context_line":"        self.assertEqual(\u0027ACTIVE\u0027, network[\u0027status\u0027])"},{"line_number":167,"context_line":"        # Verify network update"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_6bc6479d","line":164,"range":{"start_line":164,"start_character":24,"end_line":164,"end_character":75},"in_reply_to":"ffb9cba7_6921c89f","updated":"2019-04-26 11:16:51.000000000","message":"Done","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}],"tempest/api/network/test_ports.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self._create_subnet(network, cidr\u003daddress,"},{"line_number":119,"context_line":"                            mask_bits\u003daddress.prefixlen,"},{"line_number":120,"context_line":"                            **allocation_pools)"},{"line_number":121,"context_line":"        body \u003d self.ports_client.create_port(network_id\u003dnet_id)"},{"line_number":122,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":123,"context_line":"                        self.ports_client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":124,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":125,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":126,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_e47f1da9","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":30},"updated":"2019-04-22 21:34:48.000000000","message":"ditto","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8e543f28d914dc178656624191857bedff8f36","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self._create_subnet(network, cidr\u003daddress,"},{"line_number":119,"context_line":"                            mask_bits\u003daddress.prefixlen,"},{"line_number":120,"context_line":"                            **allocation_pools)"},{"line_number":121,"context_line":"        body \u003d self.ports_client.create_port(network_id\u003dnet_id)"},{"line_number":122,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":123,"context_line":"                        self.ports_client.delete_port, body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":124,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":125,"context_line":"        ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":126,"context_line":"        start_ip_address \u003d allocation_pools[\u0027allocation_pools\u0027][0][\u0027start\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_0b3b0b9c","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":30},"in_reply_to":"ffb9cba7_e47f1da9","updated":"2019-04-26 11:16:51.000000000","message":"Done","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        interface \u003d self.routers_client.add_router_interface("},{"line_number":129,"context_line":"            router[\u0027id\u0027],"},{"line_number":130,"context_line":"            port_id\u003dport_body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":131,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":132,"context_line":"                        self.routers_client.remove_router_interface,"},{"line_number":133,"context_line":"                        router[\u0027id\u0027], port_id\u003dport_body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":134,"context_line":"        self.assertIn(\u0027subnet_id\u0027, interface.keys())"},{"line_number":135,"context_line":"        self.assertIn(\u0027port_id\u0027, interface.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_64456d70","line":132,"range":{"start_line":131,"start_character":24,"end_line":132,"end_character":68},"updated":"2019-04-22 21:34:48.000000000","message":"ditto","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8e543f28d914dc178656624191857bedff8f36","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        interface \u003d self.routers_client.add_router_interface("},{"line_number":129,"context_line":"            router[\u0027id\u0027],"},{"line_number":130,"context_line":"            port_id\u003dport_body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":131,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":132,"context_line":"                        self.routers_client.remove_router_interface,"},{"line_number":133,"context_line":"                        router[\u0027id\u0027], port_id\u003dport_body[\u0027port\u0027][\u0027id\u0027])"},{"line_number":134,"context_line":"        self.assertIn(\u0027subnet_id\u0027, interface.keys())"},{"line_number":135,"context_line":"        self.assertIn(\u0027port_id\u0027, interface.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_0b646bb8","line":132,"range":{"start_line":131,"start_character":24,"end_line":132,"end_character":68},"in_reply_to":"ffb9cba7_64456d70","updated":"2019-04-26 11:16:51.000000000","message":"Done","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}],"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e96cae342a88cbda3013c2062eb8758b45f9abd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        sec_group_rule \u003d rule_create_body[\u0027security_group_rule\u0027]"},{"line_number":53,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":54,"context_line":"                        self._delete_security_group_rule, sec_group_rule[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        expected \u003d {\u0027direction\u0027: direction, \u0027protocol\u0027: protocol,"},{"line_number":57,"context_line":"                    \u0027ethertype\u0027: ethertype, \u0027port_range_min\u0027: port_range_min,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_a6212aa2","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":79},"updated":"2019-04-22 21:34:48.000000000","message":"I am ok to modify this if we can add self._delete_security_group_rule call in test_create_show_delete_security_group_rule","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8e543f28d914dc178656624191857bedff8f36","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        sec_group_rule \u003d rule_create_body[\u0027security_group_rule\u0027]"},{"line_number":53,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":54,"context_line":"                        self._delete_security_group_rule, sec_group_rule[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        expected \u003d {\u0027direction\u0027: direction, \u0027protocol\u0027: protocol,"},{"line_number":57,"context_line":"                    \u0027ethertype\u0027: ethertype, \u0027port_range_min\u0027: port_range_min,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_4b5023d5","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":79},"in_reply_to":"ffb9cba7_a6212aa2","updated":"2019-04-26 11:16:51.000000000","message":"Done","commit_id":"4be232830df7e3437935b972701dfff57c389aa6"}]}