)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e81f804bfc560caffb94e12cb68be9e9dbe12ac6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the bug of deleting security group after testing changing password."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the function of addCleanup for deleting"},{"line_number":10,"context_line":"the instance after creating."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1826301"},{"line_number":13,"context_line":"Change-Id: I3d4a3816196f42af3ea3f891473d09208651ae68"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffb9cba7_dab626fb","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":28},"updated":"2019-04-26 01:33:40.000000000","message":"nit: This doesn\u0027t explain why we should add addCleanup, but after all, adding addCleanup is not an odd thing.","commit_id":"b8331efc399e3e291a362e7a38f329db051a217c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a2309ea0743bffb8a9602738bbf8988352269573","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the bug of deleting security group after testing changing password."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to solve \u0027the security group is in use\u0027 error when deleting"},{"line_number":10,"context_line":"virtual machines."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"To ensure the normal deletion of virtual machines, we add the logic of"},{"line_number":13,"context_line":"function addCleanup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ffb9cba7_772937e4","line":10,"range":{"start_line":9,"start_character":55,"end_line":10,"end_character":17},"updated":"2019-04-28 02:55:50.000000000","message":"Not when deleting vm, but when deleting security group:)\n\nDo you mean\n\"When deleting security group before vm is deleted, we will get \u0027the security group is in use\u0027 error, so this is to add addCleanup to ensure the vm is deleted before deleting security group.\" ?","commit_id":"40085dc9d0c153d93f3e9255b22cbf19b47efe3b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f6ab595508882008cc646cb9ed6b999486a6bd70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangyangyang \u003czhangyangyang@unionpay.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-28 03:07:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the bug of deleting security group after testing changing password."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting security group before vm is deleted, we will get \u0027the"},{"line_number":10,"context_line":"security group is in use\u0027 error, so this is to add addCleanup to ensure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ffb9cba7_d6281098","line":7,"updated":"2019-04-29 22:26:58.000000000","message":"very nit: The trailing period can be removed.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"c248f5962ec4abfd716822c3b3ba496fe0e9cfbb"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"393118a67c2aff683cfcde3a2ec132a2e33f0d74","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # server unreachable, it should create its own server"},{"line_number":89,"context_line":"        validation_resources \u003d self.get_test_validation_resources("},{"line_number":90,"context_line":"            self.os_primary)"},{"line_number":91,"context_line":"        newserver \u003d self.create_test_server("},{"line_number":92,"context_line":"            validatable\u003dTrue,"},{"line_number":93,"context_line":"            validation_resources\u003dvalidation_resources,"},{"line_number":94,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":95,"context_line":"        # The server\u0027s password should be set to the provided password"},{"line_number":96,"context_line":"        new_password \u003d \u0027Newpass1234\u0027"},{"line_number":97,"context_line":"        self.client.change_password(newserver[\u0027id\u0027], adminPass\u003dnew_password)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffb9cba7_dde1562c","line":94,"range":{"start_line":91,"start_character":0,"end_line":94,"end_character":32},"updated":"2019-04-25 02:44:14.000000000","message":"Instead of removing security_group at the end of testcase, we\u0027d better use\nself.addCleanup(self.delete_server, newserver[\u0027id\u0027]) after this.","commit_id":"ec1aa9bf0997415a8aba94039d3b0845427fcb6d"}]}