)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"586846830e021e1edd67fafa483e342072a7cc63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiao Chen \u003cchenxiao@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-10 10:56:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test case about volume-show and volume-rename"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add two test cases"},{"line_number":10,"context_line":"  * rename volume when name is same with original value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2FZ2A%3D","line":7,"updated":"2014-01-14 04:01:50.000000000","message":"Any changes about \"volume-show\"","commit_id":"bb6e7fd9a30657ec92aedb81ababdd82c742e5b4"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"6c52c1c4f1523993a746914e5da2bdbf462052f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiao Chen \u003cchenxiao@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-10 10:56:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test case about volume-show and volume-rename"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add two test cases"},{"line_number":10,"context_line":"  * rename volume when name is same with original value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2FZss%3D","line":7,"in_reply_to":"AAAAUH%2F%2FZ2A%3D","updated":"2014-01-14 05:23:47.000000000","message":"Thanks :) Lei","commit_id":"bb6e7fd9a30657ec92aedb81ababdd82c742e5b4"}],"tempest/api/volume/test_volumes_get.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"556ea6d2fcf18a6503891107051b80ef316c431a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                      availability_zone\u003dvolume["},{"line_number":123,"context_line":"                                      \u0027availability_zone\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":125,"context_line":"        self.assertIn(\u0027id\u0027, new_volume)"},{"line_number":126,"context_line":"        self.addCleanup(self._delete_volume, new_volume[\u0027id\u0027])"},{"line_number":127,"context_line":"        self.client.wait_for_volume_status(new_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":128,"context_line":"        resp, update_volume \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B2fk%3D","line":125,"updated":"2014-01-21 12:45:17.000000000","message":"Why do you do such check here? Is not it better to check\n\n    self.assertIsNotNone(new_volume[\u0027id\u0027])?","commit_id":"075058320bd75c6ef805b786cf1026ec9ec269c5"},{"author":{"_account_id":8651,"name":"Chen Xiao","email":"chenxiao@cn.ibm.com","username":"chenxiao"},"change_message_id":"ec6fd14a035cbc7210182b1fc55fb0cbdc091e25","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                      availability_zone\u003dvolume["},{"line_number":123,"context_line":"                                      \u0027availability_zone\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":125,"context_line":"        self.assertIn(\u0027id\u0027, new_volume)"},{"line_number":126,"context_line":"        self.addCleanup(self._delete_volume, new_volume[\u0027id\u0027])"},{"line_number":127,"context_line":"        self.client.wait_for_volume_status(new_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":128,"context_line":"        resp, update_volume \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BxVo%3D","line":125,"in_reply_to":"AAAAUH%2F%2B2fk%3D","updated":"2014-01-22 10:02:16.000000000","message":"Hi, Ann, thanks, need to use new_volume[\u0027id\u0027] in following lines, so check whether new_volume contains \u0027id\u0027. if new_volume does not contain \u0027id\u0027, not sure \"self.assertIsNotNone(new_volume[\u0027id\u0027])\" can work.","commit_id":"075058320bd75c6ef805b786cf1026ec9ec269c5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8b9f7d3927553ecd83901d8893e629dff77139c7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                      availability_zone\u003dvolume["},{"line_number":123,"context_line":"                                      \u0027availability_zone\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":125,"context_line":"        self.assertIn(\u0027id\u0027, new_volume)"},{"line_number":126,"context_line":"        self.addCleanup(self._delete_volume, new_volume[\u0027id\u0027])"},{"line_number":127,"context_line":"        self.client.wait_for_volume_status(new_volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":128,"context_line":"        resp, update_volume \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BxOc%3D","line":125,"in_reply_to":"AAAAUH%2F%2BxVo%3D","updated":"2014-01-22 10:30:02.000000000","message":"In my opinion, check self.assertIsNotNone(new_volume[\u0027id\u0027]) is reasonable may be after self.assertIn(\u0027id\u0027, new_volume), but as I see in this test it was not used before.","commit_id":"075058320bd75c6ef805b786cf1026ec9ec269c5"}]}