)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"3a86f8f7768816f17140a4ce984718a233460049","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        if not name:"},{"line_number":350,"context_line":"            class_name \u003d self.__class__.__name__"},{"line_number":351,"context_line":"            name \u003d data_utils.rand_name(class_name + \u0027-volume-type\u0027)"},{"line_number":352,"context_line":"        randomized_name \u003d data_utils.rand_name(\u0027scenario-type-\u0027 + name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        LOG.debug(\"Creating a volume type: %s on backend %s\","},{"line_number":355,"context_line":"                  randomized_name, backend_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_d9267fb8","line":352,"range":{"start_line":352,"start_character":37,"end_line":352,"end_character":46},"updated":"2019-05-05 03:56:26.000000000","message":"Maybe it\u0027s better for callers to ensure either not passing name or passing random name, because usually we\u0027ll have below expection:\n    name \u003d \"name_xxxx\"\n    volume_type \u003d self.create_volume_type(name\u003dname)\n    self.assertEqual(volume_type[\u0027name\u0027], name)\n\nSo I think maybe we can fix those callings passing fixed name which may cause confict.","commit_id":"514495b1a0a44f03ddb870c7946bbd2101506e8b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6a934c271e5338c780962f1fc77f1232592b7007","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        if not name:"},{"line_number":350,"context_line":"            class_name \u003d self.__class__.__name__"},{"line_number":351,"context_line":"            name \u003d data_utils.rand_name(class_name + \u0027-volume-type\u0027)"},{"line_number":352,"context_line":"        randomized_name \u003d data_utils.rand_name(\u0027scenario-type-\u0027 + name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        LOG.debug(\"Creating a volume type: %s on backend %s\","},{"line_number":355,"context_line":"                  randomized_name, backend_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_b2ab8fd4","line":352,"range":{"start_line":352,"start_character":37,"end_line":352,"end_character":46},"in_reply_to":"dfbec78f_5ceeef22","updated":"2019-05-07 03:50:16.000000000","message":"I admit that the original code is not perfect, but at least it can fix the issue.\nSo I don\u0027t object to revert it for now, and later maybe we can do some improvements.","commit_id":"514495b1a0a44f03ddb870c7946bbd2101506e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2222351ca772060ba5e194ccc7c075bd2d50f95d","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        if not name:"},{"line_number":350,"context_line":"            class_name \u003d self.__class__.__name__"},{"line_number":351,"context_line":"            name \u003d data_utils.rand_name(class_name + \u0027-volume-type\u0027)"},{"line_number":352,"context_line":"        randomized_name \u003d data_utils.rand_name(\u0027scenario-type-\u0027 + name)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        LOG.debug(\"Creating a volume type: %s on backend %s\","},{"line_number":355,"context_line":"                  randomized_name, backend_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_5ceeef22","line":352,"range":{"start_line":352,"start_character":37,"end_line":352,"end_character":46},"in_reply_to":"dfbec78f_d9267fb8","updated":"2019-05-06 16:45:22.000000000","message":"\u003e because usually we\u0027ll have below expection\n\nWe do? If that were true, tempest would be failing on this change. That also seems like an exceptionally brittle piece of test code that shouldn\u0027t be approved.\n\n\u003e So I think maybe we can fix those callings passing fixed name which may cause confict.\n\nBut this fixes the issue, regardless of what the callers pass.","commit_id":"514495b1a0a44f03ddb870c7946bbd2101506e8b"}]}