)]}'
{"tempest/api/network/test_fwaas_extensions.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"26ebf1fe1c36eecb3b3f11430f1ddcbdd875b72a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if not test.is_extension_enabled(\u0027fwaas\u0027, \u0027network\u0027):"},{"line_number":41,"context_line":"            msg \u003d \"fwaas extension not enabled.\""},{"line_number":42,"context_line":"            raise cls.skipException(msg)"},{"line_number":43,"context_line":"        cls.firewall \u003d cls.create_firewall(data_utils.rand_name(\"firewall-\"))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":46,"context_line":"    def test_list_firewalls(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FoAI%3D","line":43,"updated":"2014-01-10 11:13:36.000000000","message":"name\u003d","commit_id":"cd761812006e3faa6816910f7727a9c8cf7ce5ea"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4122171565ea2fe32748767cbc07f97983a231ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2014 eNovance SAS \u003clicensing@enovance.com\u003e"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Emilien Macchi \u003cemilien.macchi@enovance.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FFwg%3D","line":4,"updated":"2014-01-17 15:07:19.000000000","message":"I would suggest adding your name here.","commit_id":"a6c3dc8ad14a946723482bea7932a017b43c3804"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7cfcfe3bc2d15c108e1e6d7e7925e95d47809f8c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(rule_id)"},{"line_number":56,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":57,"context_line":"        # Asserting that the rule is not found in the list after deletion"},{"line_number":58,"context_line":"        resp, list_body \u003d self.client.list_firewall_rules()"},{"line_number":59,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":60,"context_line":"        rules_list \u003d list()"},{"line_number":61,"context_line":"        for rule in list_body[\u0027firewall_rules\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FBZ0%3D","line":58,"updated":"2014-01-18 18:29:32.000000000","message":"I know I\u0027ve left similar comment on other review:\nit\u0027s better to use list filters here that will result in 1 or 0 items returned.\nSame for other calls for lists and checking for item presense","commit_id":"96aae3662b9c5b0aa1a0148d0e6cbb2f8983c280"},{"author":{"_account_id":8861,"name":"Joris Roovers","email":"jroovers@cisco.com","username":"joris.roovers"},"change_message_id":"a80bbea0130c441c57d2a29c5fe18514dd7a9d91","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        resp, _ \u003d self.client.delete_firewall_rule(rule_id)"},{"line_number":56,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":57,"context_line":"        # Asserting that the rule is not found in the list after deletion"},{"line_number":58,"context_line":"        resp, list_body \u003d self.client.list_firewall_rules()"},{"line_number":59,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":60,"context_line":"        rules_list \u003d list()"},{"line_number":61,"context_line":"        for rule in list_body[\u0027firewall_rules\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B%2Fts%3D","line":58,"in_reply_to":"AAAAUH%2F%2FBZ0%3D","updated":"2014-01-19 20:10:28.000000000","message":"Makes sense, will update. Thanks!","commit_id":"96aae3662b9c5b0aa1a0148d0e6cbb2f8983c280"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"583412370b332969543a2b1ac8a38b9e96453162","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        body \u003d json.loads(body)"},{"line_number":516,"context_line":"        return resp, body"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def list_firewalls(self):"},{"line_number":519,"context_line":"        uri \u003d \u0027%s/fw/firewalls\u0027 % (self.uri_prefix)"},{"line_number":520,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":521,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Folo%3D","line":518,"updated":"2014-01-10 09:09:28.000000000","message":"With auto-generated CRUD methods you don\u0027t need to define these methods manually. Please check this patch https://review.openstack.org/#/c/62865/","commit_id":"cf2a58f2a51e49e297cddf08c1190cc1f8fab0e8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6fc30668f907de162729036f9f11a07f28057e4a","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        body \u003d json.loads(body)"},{"line_number":516,"context_line":"        return resp, body"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def list_firewalls(self):"},{"line_number":519,"context_line":"        uri \u003d \u0027%s/fw/firewalls\u0027 % (self.uri_prefix)"},{"line_number":520,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":521,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fog4%3D","line":518,"in_reply_to":"AAAAUH%2F%2Folo%3D","updated":"2014-01-10 09:29:07.000000000","message":"Done","commit_id":"cf2a58f2a51e49e297cddf08c1190cc1f8fab0e8"}]}