)]}'
{"tempest/api/volume/test_volumes_list.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"666a7033ef3ca4a7ba32c2796acee85de5c13ce0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"},{"line_number":114,"context_line":"                    matchee \u003d set(params[key].items())"},{"line_number":115,"context_line":"                    matcher \u003d set(volume[key].items())"},{"line_number":116,"context_line":"                    self.assertTrue(matchee.issubset(matcher), msg)"},{"line_number":117,"context_line":"                else:"},{"line_number":118,"context_line":"                    self.assertEqual(params[key], volume[key], msg)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fiuw%3D","line":116,"updated":"2014-01-12 01:58:57.000000000","message":"The dictionary subset matcher seems like something we should make as a base method on TestCase.","commit_id":"2d9a9f9fef15de366b469bd85d9a5815d1c30e9d"},{"author":{"_account_id":9485,"name":"Jerry Cai","email":"caimin@cn.ibm.com","username":"jerrycai"},"change_message_id":"60791d6e3135b5256576f0ea68d922851a286f10","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"},{"line_number":114,"context_line":"                    matchee \u003d set(params[key].items())"},{"line_number":115,"context_line":"                    matcher \u003d set(volume[key].items())"},{"line_number":116,"context_line":"                    self.assertTrue(matchee.issubset(matcher), msg)"},{"line_number":117,"context_line":"                else:"},{"line_number":118,"context_line":"                    self.assertEqual(params[key], volume[key], msg)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FgpU%3D","line":116,"in_reply_to":"AAAAUH%2F%2Fiuw%3D","updated":"2014-01-13 06:25:49.000000000","message":"I got your idea now. Please review the patch 4 again. Thank you.","commit_id":"2d9a9f9fef15de366b469bd85d9a5815d1c30e9d"},{"author":{"_account_id":9485,"name":"Jerry Cai","email":"caimin@cn.ibm.com","username":"jerrycai"},"change_message_id":"cc4cd3811c1e150d90a7aa3e0592707a1d338769","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"},{"line_number":114,"context_line":"                    matchee \u003d set(params[key].items())"},{"line_number":115,"context_line":"                    matcher \u003d set(volume[key].items())"},{"line_number":116,"context_line":"                    self.assertTrue(matchee.issubset(matcher), msg)"},{"line_number":117,"context_line":"                else:"},{"line_number":118,"context_line":"                    self.assertEqual(params[key], volume[key], msg)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fh8A%3D","line":116,"in_reply_to":"AAAAUH%2F%2Fiuw%3D","updated":"2014-01-12 13:09:07.000000000","message":"Thanks for comment. I agree to do so but currently all the assert methods are provided by Python default packages.\n/tempest/tempest/test.py#BaseTestCase seems the base TestCase file but there is not any assert method existed in it but only initialization process for testcases, not sure if it\u0027s proper to add the matcher method there. Any comment or other place in tempest do you think is proper to include this matcher method, or it\u0027s a tiny matcher that doesn\u0027t deserve a base method, which can be by replaced by assertTrue()?","commit_id":"2d9a9f9fef15de366b469bd85d9a5815d1c30e9d"}]}