)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"3abbaec7765787533ee24fa78cdffc7f47f07f09","unresolved":false,"context_lines":[{"line_number":13,"context_line":" - Update a pool description and confirm it was changed with a show"},{"line_number":14,"context_line":" - Update the lb_method of a pool to other than Round_robin"},{"line_number":15,"context_line":" - Update the list of health monitors a pool is associated with"},{"line_number":16,"context_line":" - List or show the members is a pool"},{"line_number":17,"context_line":" - Update the admin_state_up of a pool to false and confirm with show"},{"line_number":18,"context_line":" - Confirm with show the status of a pool is ACTIVE"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAAUH%2F%2Bvt4%3D","line":16,"updated":"2014-01-22 15:25:40.000000000","message":"It\u0027s not really clear what does it mean. Could you please reword the description so it\u0027ll be something like \"List or show members of a pool\"?","commit_id":"fef7a7e825f212942d2e054619c41fc43f57b8ec"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"3abbaec7765787533ee24fa78cdffc7f47f07f09","unresolved":false,"context_lines":[{"line_number":15,"context_line":" - Update the list of health monitors a pool is associated with"},{"line_number":16,"context_line":" - List or show the members is a pool"},{"line_number":17,"context_line":" - Update the admin_state_up of a pool to false and confirm with show"},{"line_number":18,"context_line":" - Confirm with show the status of a pool is ACTIVE"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1dea0fad3ccf54a8f6844c4c71a542b4ee0e82cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAAUH%2F%2Bvvg%3D","line":18,"updated":"2014-01-22 15:25:40.000000000","message":"The change does not contain this test so please remove this line.","commit_id":"fef7a7e825f212942d2e054619c41fc43f57b8ec"}],"tempest/api/network/admin/test_load_balancer_admin_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a1f35484adcc0e642b1eca7eb7f3654193952b3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":100,"context_line":"        self.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":101,"context_line":"        self.assertIsNotNone(pool[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.assertEqual(pool[\u0027tenant_id\u0027], self.tenant_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class LoadBalancerAdminTestXML(LoadBalancerAdminTestJSON):"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAWH%2F%2Bi6g%3D","line":102,"updated":"2014-03-26 01:46:18.000000000","message":"Please change the order of parameter - (expected, actual)","commit_id":"31bf28c84f105e161679f68e97f4be5c29444a3b"}],"tempest/api/network/test_load_balancer.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e3c596bb67db7cfbb002d1e222f5a1003dd1abfc","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @classmethod"},{"line_number":338,"context_line":"    def setUpClass(cls):"},{"line_number":339,"context_line":"        super(LoadBalancerAdminJSON, cls).setUpClass()"},{"line_number":340,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":341,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FdRA%3D","line":339,"updated":"2014-01-13 17:41:37.000000000","message":"please make this test extensions-aware","commit_id":"e27e29e166f6c78deedfad4bce3f22da6fe7b761"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a498053f4731090867842ff1d9a3ca1d003c72ba","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        health_monitors \u003d body[\u0027pool\u0027][\u0027health_monitors\u0027]"},{"line_number":302,"context_line":"        for health_monitor_id in health_monitors:"},{"line_number":303,"context_line":"            resp, body \u003d self.client.show_health_monitor(health_monitor_id)"},{"line_number":304,"context_line":"            self.assertEqual(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027], False)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":307,"context_line":"    def test_update_admin_state_up_of_pool(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FNqc%3D","line":304,"updated":"2014-01-16 10:00:54.000000000","message":"It would probably be better to use\n\n    self.assertFalse(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027])","commit_id":"3800e6a2a8bbf4623448146233b2d16224bfbc38"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5a0d5739fd1582cfb3512b06923472a19591963a","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        health_monitors \u003d body[\u0027pool\u0027][\u0027health_monitors\u0027]"},{"line_number":302,"context_line":"        for health_monitor_id in health_monitors:"},{"line_number":303,"context_line":"            resp, body \u003d self.client.show_health_monitor(health_monitor_id)"},{"line_number":304,"context_line":"            self.assertEqual(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027], False)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":307,"context_line":"    def test_update_admin_state_up_of_pool(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FNVo%3D","line":304,"in_reply_to":"AAAAUH%2F%2FNqc%3D","updated":"2014-01-16 11:44:09.000000000","message":"This lines are equal. There is no point to change this.","commit_id":"3800e6a2a8bbf4623448146233b2d16224bfbc38"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a498053f4731090867842ff1d9a3ca1d003c72ba","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                             admin_state_up\u003dFalse)"},{"line_number":310,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":311,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":312,"context_line":"        self.assertEqual(pool[\u0027admin_state_up\u0027], False)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":315,"context_line":"    def test_show_vip_associated_with_pool(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FNqQ%3D","line":312,"updated":"2014-01-16 10:00:54.000000000","message":"same here","commit_id":"3800e6a2a8bbf4623448146233b2d16224bfbc38"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0aa79a33fec3becac867aab1d3e2bf5f18d2816d","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc-\u0027)"},{"line_number":351,"context_line":"        cls.tenant \u003d cls.identity_admin_client.create_tenant("},{"line_number":352,"context_line":"            name\u003ddata_utils.rand_name(\u0027tenant-\u0027),"},{"line_number":353,"context_line":"            description\u003dtest_description)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":356,"context_line":"    def test_create_pool_from_admin_user_other_tenant(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BoGg%3D","line":353,"updated":"2014-01-23 19:41:56.000000000","message":"You forgot to clean-up the newly created tenant. Something like this will do the trick:\n\nself.addCleanup(cls.identity_admin_client.delete_tenant, cls.tenant[\u0027id\u0027])","commit_id":"4469ceb3510d68558d80c54aee0f66acc84b38f6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0aa79a33fec3becac867aab1d3e2bf5f18d2816d","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            tenant_id\u003dself.tenant[1][\u0027id\u0027])"},{"line_number":361,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":362,"context_line":"        self.assertIsNotNone(pool[\u0027id\u0027])"},{"line_number":363,"context_line":"        self.assertEqual(pool[\u0027tenant_id\u0027], self.tenant[1][\u0027id\u0027])"},{"line_number":364,"context_line":"        self.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2Bn8o%3D","line":363,"updated":"2014-01-23 19:41:56.000000000","message":"Does the identity client return a list when you create a tenant? I am looking at \n\nhttp://docs.openstack.org/api/openstack-identity-service/2.0/content/POST_addTenant_v2.0_tenants_Tenant_Operations_OS-KSADM.html\n\nand I see that it returns a straight dictionary","commit_id":"4469ceb3510d68558d80c54aee0f66acc84b38f6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"772a7bc4b40bb4e8b60ef703c7fca001ed786b57","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            tenant_id\u003dself.tenant[1][\u0027id\u0027])"},{"line_number":361,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":362,"context_line":"        self.assertIsNotNone(pool[\u0027id\u0027])"},{"line_number":363,"context_line":"        self.assertEqual(pool[\u0027tenant_id\u0027], self.tenant[1][\u0027id\u0027])"},{"line_number":364,"context_line":"        self.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BlE4%3D","line":363,"in_reply_to":"AAAAUH%2F%2Bn8o%3D","updated":"2014-01-24 07:12:07.000000000","message":"This is so because I create tenant as\n\n    cls.tenant \u003d cls.identity_admin_client.create_tenant\n\nnot \n\n    resp, cls.tenant \u003d cls.identity_admin_client.create_tenant\n\nIf this doesn\u0027t look good, I\u0027ll correct this.","commit_id":"4469ceb3510d68558d80c54aee0f66acc84b38f6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0aa79a33fec3becac867aab1d3e2bf5f18d2816d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":362,"context_line":"        self.assertIsNotNone(pool[\u0027id\u0027])"},{"line_number":363,"context_line":"        self.assertEqual(pool[\u0027tenant_id\u0027], self.tenant[1][\u0027id\u0027])"},{"line_number":364,"context_line":"        self.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027])"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"class LoadBalancerXML(LoadBalancerJSON):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2Bn9s%3D","line":364,"updated":"2014-01-23 19:41:56.000000000","message":"Wouldn\u0027t it be better to have:\n\nself.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])\n\npool \u003d body[\u0027pool\u0027]\n\nself.addCleanup(self.admin_client.delete_pool, pool[\u0027id\u0027])\n\n\nRight after you create the pool (line 360)? This way, regardless of what happens with the other asserts, you clean-up","commit_id":"4469ceb3510d68558d80c54aee0f66acc84b38f6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ae9a305103c879a5464b108238298ac14069fbbf","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc-\u0027)"},{"line_number":349,"context_line":"        resp, cls.tenant \u003d cls.identity_admin_client.create_tenant("},{"line_number":350,"context_line":"            name\u003ddata_utils.rand_name(\u0027tenant-\u0027),"},{"line_number":351,"context_line":"            description\u003dtest_description)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    @classmethod"},{"line_number":354,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2BPbc%3D","line":351,"updated":"2014-01-28 19:12:50.000000000","message":"mhhhh..... Am I mising something? Is there a reason not to call:\n\nself.addCleanup(cls.identity_admin_client.delete_tenant, cls.tenant[\u0027id\u0027])","commit_id":"972673157cacf2864453349ab0d63cb085ff4524"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1967de512bae1fd7fbb7ab8466420d0c64699bc9","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc-\u0027)"},{"line_number":349,"context_line":"        resp, cls.tenant \u003d cls.identity_admin_client.create_tenant("},{"line_number":350,"context_line":"            name\u003ddata_utils.rand_name(\u0027tenant-\u0027),"},{"line_number":351,"context_line":"            description\u003dtest_description)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    @classmethod"},{"line_number":354,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2BMik%3D","line":351,"in_reply_to":"AAAAUH%2F%2BPbc%3D","updated":"2014-01-29 06:48:29.000000000","message":"I create tearDownClass where I delete it. When I do as you suggest test fails with\nFile \"tempest/api/network/test_load_balancer.py\", line 353, in setUpClass\n    cls.tenant[\u0027id\u0027])\nTypeError: unbound method addCleanup() must be called with LoadBalancerAdminJSON instance as first argument (got instancemethod instance instead) and the same for LoadBalancerAdminXML\nAlso I didn\u0027t find any examples where cleanUp used in setupClass.","commit_id":"972673157cacf2864453349ab0d63cb085ff4524"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":363,"context_line":"    def test_update_list_of_health_monitors_associated_with_pool(self):"},{"line_number":364,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":365,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":366,"context_line":"        resp, body \u003d self.client.update_health_monitor("},{"line_number":367,"context_line":"            self.health_monitor[\u0027id\u0027], admin_state_up\u003dFalse)"},{"line_number":368,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lSg%3D","line":365,"updated":"2014-02-05 21:51:59.000000000","message":"We could add:\n\nself.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])\n\nValidating we get the expected response is part of testing the api, in my opinion. Same comment below in several places","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":365,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":366,"context_line":"        resp, body \u003d self.client.update_health_monitor("},{"line_number":367,"context_line":"            self.health_monitor[\u0027id\u0027], admin_state_up\u003dFalse)"},{"line_number":368,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":369,"context_line":"        health_monitors \u003d body[\u0027pool\u0027][\u0027health_monitors\u0027]"},{"line_number":370,"context_line":"        for health_monitor_id in health_monitors:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lSc%3D","line":367,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":375,"context_line":"    def test_update_admin_state_up_of_pool(self):"},{"line_number":376,"context_line":"        resp, body \u003d self.client.update_pool(self.pool[\u0027id\u0027],"},{"line_number":377,"context_line":"                                             admin_state_up\u003dFalse)"},{"line_number":378,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":379,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":380,"context_line":"        self.assertFalse(pool[\u0027admin_state_up\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lRo%3D","line":377,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    def test_update_admin_state_up_of_pool(self):"},{"line_number":376,"context_line":"        resp, body \u003d self.client.update_pool(self.pool[\u0027id\u0027],"},{"line_number":377,"context_line":"                                             admin_state_up\u003dFalse)"},{"line_number":378,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":379,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":380,"context_line":"        self.assertFalse(pool[\u0027admin_state_up\u0027])"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lRk%3D","line":378,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":383,"context_line":"    def test_show_vip_associated_with_pool(self):"},{"line_number":384,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":385,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":386,"context_line":"        resp, body \u003d self.client.show_vip(pool[\u0027vip_id\u0027])"},{"line_number":387,"context_line":"        vip \u003d body[\u0027vip\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lRc%3D","line":384,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def test_show_vip_associated_with_pool(self):"},{"line_number":384,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":385,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":386,"context_line":"        resp, body \u003d self.client.show_vip(pool[\u0027vip_id\u0027])"},{"line_number":387,"context_line":"        vip \u003d body[\u0027vip\u0027]"},{"line_number":388,"context_line":"        self.assertIsNotNone(vip[\u0027name\u0027])"},{"line_number":389,"context_line":"        self.assertIsNotNone(vip[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lRU%3D","line":386,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        resp, body \u003d self.client.show_vip(pool[\u0027vip_id\u0027])"},{"line_number":387,"context_line":"        vip \u003d body[\u0027vip\u0027]"},{"line_number":388,"context_line":"        self.assertIsNotNone(vip[\u0027name\u0027])"},{"line_number":389,"context_line":"        self.assertIsNotNone(vip[\u0027id\u0027])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":392,"context_line":"    def test_show_members_associated_with_pool(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lVM%3D","line":389,"updated":"2014-02-05 21:51:59.000000000","message":"Wouldn\u0027t it be a more robust test to do the following assert:?\n\nself.assertEquals(self.vip[\u0027id\u0027], vip[\u0027id\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":392,"context_line":"    def test_show_members_associated_with_pool(self):"},{"line_number":393,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":394,"context_line":"        members \u003d body[\u0027pool\u0027][\u0027members\u0027]"},{"line_number":395,"context_line":"        for member_id in members:"},{"line_number":396,"context_line":"            resp, body \u003d self.client.show_member(member_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lRQ%3D","line":393,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":394,"context_line":"        members \u003d body[\u0027pool\u0027][\u0027members\u0027]"},{"line_number":395,"context_line":"        for member_id in members:"},{"line_number":396,"context_line":"            resp, body \u003d self.client.show_member(member_id)"},{"line_number":397,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027status\u0027])"},{"line_number":398,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027id\u0027])"},{"line_number":399,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027admin_state_up\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lRI%3D","line":396,"updated":"2014-02-05 21:51:59.000000000","message":"self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5e06924b3c569ad0f156c35b897a26c66a62695f","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            resp, body \u003d self.client.show_member(member_id)"},{"line_number":397,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027status\u0027])"},{"line_number":398,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027id\u0027])"},{"line_number":399,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027admin_state_up\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"class LoadBalancerAdminJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F9lUc%3D","line":399,"updated":"2014-02-05 21:51:59.000000000","message":"Wouldn\u0027t it be a more robust test to do the following assert:?\n\nself.assertEquals(self.member[\u0027id\u0027], member_id)","commit_id":"bbe6a296fcff1b34d0e6401a655c5d46b9bbd1e5"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"69c6c3097c7af19c75d5b3653f054c1181504085","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":387,"context_line":"    def test_show_vip_associated_with_pool(self):"},{"line_number":388,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"},{"line_number":389,"context_line":"        pool \u003d body[\u0027pool\u0027]"},{"line_number":390,"context_line":"        resp, body \u003d self.client.show_vip(pool[\u0027vip_id\u0027])"},{"line_number":391,"context_line":"        vip \u003d body[\u0027vip\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F9iGQ%3D","line":388,"updated":"2014-02-06 08:49:59.000000000","message":"two more status checks are left to be added :)","commit_id":"c4ffdccc97832ffbce30d7dbc666141f3680ba70"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b1c81f487739478abe7de66d465e6f13da95f5a3","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            self.assertIsNotNone(body[\u0027member\u0027][\u0027admin_state_up\u0027])"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"class LoadBalancerAdminJSON(base.BaseAdminNetworkTest):"},{"line_number":411,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2F2Fs%3D","line":410,"updated":"2014-02-10 13:19:17.000000000","message":"I guess it\u0027ll be better to rename the class to LoadBalancerAdminTestJSON so it\u0027ll look more unified.","commit_id":"b5fe8dd9d7e778a5b7364b03c1acffd31effffb6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b1c81f487739478abe7de66d465e6f13da95f5a3","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    _interface \u003d \u0027xml\u0027"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"class LoadBalancerAdminXML(LoadBalancerAdminJSON):"},{"line_number":454,"context_line":"    _interface \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2F2Fg%3D","line":453,"updated":"2014-02-10 13:19:17.000000000","message":"Same here","commit_id":"b5fe8dd9d7e778a5b7364b03c1acffd31effffb6"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2722f68528003332328b92431a5e7c98ca3c61ed","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":363,"context_line":"    def test_update_list_of_health_monitors_associated_with_pool(self):"},{"line_number":364,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":365,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":366,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":367,"context_line":"        resp, body \u003d self.client.update_health_monitor("}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FbtA%3D","line":364,"updated":"2014-02-13 08:50:10.000000000","message":"it looks like we never do the opposite operation. Should we?","commit_id":"1d9aa8962607aa60cee0c6a1e913ddafb3455520"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"173b8f65967a95ab57ca8bcaea06804076e2b1ba","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":363,"context_line":"    def test_update_list_of_health_monitors_associated_with_pool(self):"},{"line_number":364,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":365,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":366,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":367,"context_line":"        resp, body \u003d self.client.update_health_monitor("}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAUX%2F%2FavI%3D","line":364,"in_reply_to":"AAAAUX%2F%2FbtA%3D","updated":"2014-02-13 11:00:07.000000000","message":"It seems that I forgot to do it as the main testing operations are update and list. I will correct this in next patch.","commit_id":"1d9aa8962607aa60cee0c6a1e913ddafb3455520"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a1f35484adcc0e642b1eca7eb7f3654193952b3","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        updated_pool \u003d body[\u0027pool\u0027]"},{"line_number":164,"context_line":"        self.assertEqual(updated_pool[\u0027name\u0027], new_name)"},{"line_number":165,"context_line":"        self.assertEqual(updated_pool[\u0027description\u0027], \u0027new_description\u0027)"},{"line_number":166,"context_line":"        self.assertEqual(updated_pool[\u0027lb_method\u0027], \u0027LEAST_CONNECTIONS\u0027)"},{"line_number":167,"context_line":"        # Verification of pool delete"},{"line_number":168,"context_line":"        resp, body \u003d self.client.delete_pool(pool[\u0027id\u0027])"},{"line_number":169,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAWH%2F%2Bi6E%3D","line":166,"updated":"2014-03-26 01:46:18.000000000","message":"Same here. parameter order needs to be changed.","commit_id":"31bf28c84f105e161679f68e97f4be5c29444a3b"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        updated_pool \u003d body[\u0027pool\u0027]"},{"line_number":164,"context_line":"        self.assertEqual(new_name, updated_pool[\u0027name\u0027])"},{"line_number":165,"context_line":"        self.assertEqual(\u0027new_description\u0027, updated_pool[\u0027description\u0027])"},{"line_number":166,"context_line":"        self.assertEqual(\u0027LEAST_CONNECTIONS\u0027, updated_pool[\u0027lb_method\u0027])"},{"line_number":167,"context_line":"        # Verification of pool delete"},{"line_number":168,"context_line":"        resp, body \u003d self.client.delete_pool(pool[\u0027id\u0027])"},{"line_number":169,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bf%2FA%3D","line":166,"updated":"2014-03-26 12:10:53.000000000","message":"Use multiple assert... consecutive is bad practice.\nPlease change it.\nYou can do it this:\nself.assertDictContainsSubset({\"name\": new_name, \"description\": \"new_description\", \"lb_method\": \"LEAST_CONNECTIONS\"}, updated_pool)","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4348e1b1c354dfcee3892bc5b4d0490d160a44e1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        updated_pool \u003d body[\u0027pool\u0027]"},{"line_number":164,"context_line":"        self.assertEqual(new_name, updated_pool[\u0027name\u0027])"},{"line_number":165,"context_line":"        self.assertEqual(\u0027new_description\u0027, updated_pool[\u0027description\u0027])"},{"line_number":166,"context_line":"        self.assertEqual(\u0027LEAST_CONNECTIONS\u0027, updated_pool[\u0027lb_method\u0027])"},{"line_number":167,"context_line":"        # Verification of pool delete"},{"line_number":168,"context_line":"        resp, body \u003d self.client.delete_pool(pool[\u0027id\u0027])"},{"line_number":169,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2BffI%3D","line":166,"in_reply_to":"AAAAWH%2F%2Bf%2FA%3D","updated":"2014-03-26 12:55:11.000000000","message":"It is better looking and understanding when you check every parameter inline. And may be you could give a link to documentation where it is told that usage multiple asserts is a bad practice?","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":385,"context_line":"    def test_update_list_of_health_monitors_associated_with_pool(self):"},{"line_number":386,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":387,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":388,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":389,"context_line":"        resp, body \u003d self.client.update_health_monitor("}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bf9Q%3D","line":386,"updated":"2014-03-26 12:10:53.000000000","message":"unused variables \"body\"","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4348e1b1c354dfcee3892bc5b4d0490d160a44e1","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":385,"context_line":"    def test_update_list_of_health_monitors_associated_with_pool(self):"},{"line_number":386,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":387,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":388,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":389,"context_line":"        resp, body \u003d self.client.update_health_monitor("}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2BfdE%3D","line":386,"in_reply_to":"AAAAWH%2F%2Bf9Q%3D","updated":"2014-03-26 12:55:11.000000000","message":"I think it\u0027s better to keep all method calls and variable names consistent to avoid confusion.","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        resp, body \u003d (self.client.associate_health_monitor_with_pool"},{"line_number":387,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":388,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":389,"context_line":"        resp, body \u003d self.client.update_health_monitor("},{"line_number":390,"context_line":"            self.health_monitor[\u0027id\u0027], admin_state_up\u003dFalse)"},{"line_number":391,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":392,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bf9A%3D","line":389,"updated":"2014-03-26 12:10:53.000000000","message":"analogically","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":394,"context_line":"        health_monitors \u003d body[\u0027pool\u0027][\u0027health_monitors\u0027]"},{"line_number":395,"context_line":"        for health_monitor_id in health_monitors:"},{"line_number":396,"context_line":"            resp, body \u003d self.client.show_health_monitor(health_monitor_id)"},{"line_number":397,"context_line":"            self.assertFalse(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027])"},{"line_number":398,"context_line":"        resp, body \u003d (self.client.disassociate_health_monitor_with_pool"},{"line_number":399,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bfx8%3D","line":396,"updated":"2014-03-26 12:10:53.000000000","message":"The response code verification is a good practice. Please add this verification.","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4348e1b1c354dfcee3892bc5b4d0490d160a44e1","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":394,"context_line":"        health_monitors \u003d body[\u0027pool\u0027][\u0027health_monitors\u0027]"},{"line_number":395,"context_line":"        for health_monitor_id in health_monitors:"},{"line_number":396,"context_line":"            resp, body \u003d self.client.show_health_monitor(health_monitor_id)"},{"line_number":397,"context_line":"            self.assertFalse(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027])"},{"line_number":398,"context_line":"        resp, body \u003d (self.client.disassociate_health_monitor_with_pool"},{"line_number":399,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bfeg%3D","line":396,"in_reply_to":"AAAAWH%2F%2Bfx8%3D","updated":"2014-03-26 12:55:11.000000000","message":"Thanks, correct this","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        for health_monitor_id in health_monitors:"},{"line_number":396,"context_line":"            resp, body \u003d self.client.show_health_monitor(health_monitor_id)"},{"line_number":397,"context_line":"            self.assertFalse(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027])"},{"line_number":398,"context_line":"        resp, body \u003d (self.client.disassociate_health_monitor_with_pool"},{"line_number":399,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":400,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bf8E%3D","line":398,"updated":"2014-03-26 12:10:53.000000000","message":"unused variables \"body\"","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":403,"context_line":"    def test_update_admin_state_up_of_pool(self):"},{"line_number":404,"context_line":"        resp, body \u003d self.client.update_pool(self.pool[\u0027id\u0027],"},{"line_number":405,"context_line":"                                             admin_state_up\u003dFalse)"},{"line_number":406,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":407,"context_line":"        resp, body \u003d self.client.show_pool(self.pool[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bfxs%3D","line":404,"updated":"2014-03-26 12:10:53.000000000","message":"unused variables \"body\"","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"cba4d9a896f2098f5e9eed7886ca563e9143edde","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        resp, body \u003d self.client.show_vip(pool[\u0027vip_id\u0027])"},{"line_number":418,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":419,"context_line":"        vip \u003d body[\u0027vip\u0027]"},{"line_number":420,"context_line":"        self.assertEqual(self.vip[\u0027name\u0027], vip[\u0027name\u0027])"},{"line_number":421,"context_line":"        self.assertEqual(self.vip[\u0027id\u0027], vip[\u0027id\u0027])"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":36,"id":"AAAAWH%2F%2Bfws%3D","line":420,"updated":"2014-03-26 12:10:53.000000000","message":"Analogically with comment to line 166","commit_id":"48c280ae1c5f7ebc68ceb482531636fe5bc63e31"},{"author":{"_account_id":7126,"name":"Vadim Rovachev","email":"vrovachev@mirantis.com","username":"vrovachev"},"change_message_id":"eb712157a36261459f8620d3c09cfa40142c2b5b","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            resp, body \u003d self.client.show_health_monitor(health_monitor_id)"},{"line_number":397,"context_line":"            self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":398,"context_line":"            self.assertFalse(body[\u0027health_monitor\u0027][\u0027admin_state_up\u0027])"},{"line_number":399,"context_line":"        resp, body \u003d (self.client.disassociate_health_monitor_with_pool"},{"line_number":400,"context_line":"                     (self.health_monitor[\u0027id\u0027], self.pool[\u0027id\u0027]))"},{"line_number":401,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"AAAAWH%2F%2BOck%3D","line":399,"updated":"2014-03-28 09:22:58.000000000","message":"minor note: unused variable \"body\"","commit_id":"5b92b775cbd0d1632241552264d829697762e670"}]}