)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4bea478a505092105fb7ceb5c51f4d477f7f8e92","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        # others considered \"legacy\".  Use \u0027ipv6-icmp\u0027 as the API could"},{"line_number":176,"context_line":"        # change to return only that value, see"},{"line_number":177,"context_line":"        # https://review.opendev.org/#/c/453346/"},{"line_number":178,"context_line":"        # The neutron-tempest-plugin API tests pass all three and verify"},{"line_number":179,"context_line":"        # the output, so there is no need to duplicate that here."},{"line_number":180,"context_line":"        protocol \u003d \u0027ipv6-icmp\u0027 if self._ip_version \u003d\u003d 6 else \u0027icmp\u0027"},{"line_number":181,"context_line":"        icmp_type_codes \u003d [(3, 2), (3, 0), (8, 0), (0, 0), (11, None)]"},{"line_number":182,"context_line":"        for icmp_type, icmp_code in icmp_type_codes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_c690454d","line":179,"range":{"start_line":178,"start_character":0,"end_line":179,"end_character":65},"updated":"2019-05-29 03:19:32.000000000","message":"I remember this test change during old patch[1], ML[2] also and we had a concern to test the all allowed protocol for the backward compatibility check. Those check has been added on neutron-tempest-plugin side[3] which is enough now. Thanks for doing that. \n\n[1] https://review.opendev.org/#/c/431276/21\n[2] http://lists.openstack.org/pipermail/openstack-dev/2017-March/114614.html\n[3] https://review.opendev.org/#/c/660206/2","commit_id":"13731b02064c6fcc37e4dcd335b84b22f3eeac00"}]}