)]}'
{"tempest/api/identity/admin/v3/test_endpoints.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9f0224134ddbe1f6762e3b79c567901975a9d5dd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            endpoint \u003d cls.client.create_endpoint("},{"line_number":50,"context_line":"                service_id\u003dcls.service_ids[i], interface\u003dinterfaces[i],"},{"line_number":51,"context_line":"                url\u003durl, region\u003dregion_name, enabled\u003dTrue)[\u0027endpoint\u0027]"},{"line_number":52,"context_line":"            region \u003d cls.regions_client.show_region(region_name)[\u0027region\u0027]"},{"line_number":53,"context_line":"            cls.addClassResourceCleanup("},{"line_number":54,"context_line":"                cls.regions_client.delete_region, region[\u0027id\u0027])"},{"line_number":55,"context_line":"            cls.addClassResourceCleanup("},{"line_number":56,"context_line":"                cls.client.delete_endpoint, endpoint[\u0027id\u0027])"},{"line_number":57,"context_line":"            cls.setup_endpoint_ids.append(endpoint[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b54e43bf","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":63},"updated":"2019-06-03 06:45:49.000000000","message":"I am wondering whether we can put region_names into a list, and then remove all regions in resource_cleanup.","commit_id":"1a457ac530a24968212865d594ec87943d883d9d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"085abca04dea2a28dbb82b0b7e804e23cfc4acba","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            endpoint \u003d cls.client.create_endpoint("},{"line_number":50,"context_line":"                service_id\u003dcls.service_ids[i], interface\u003dinterfaces[i],"},{"line_number":51,"context_line":"                url\u003durl, region\u003dregion_name, enabled\u003dTrue)[\u0027endpoint\u0027]"},{"line_number":52,"context_line":"            region \u003d cls.regions_client.show_region(region_name)[\u0027region\u0027]"},{"line_number":53,"context_line":"            cls.addClassResourceCleanup("},{"line_number":54,"context_line":"                cls.regions_client.delete_region, region[\u0027id\u0027])"},{"line_number":55,"context_line":"            cls.addClassResourceCleanup("},{"line_number":56,"context_line":"                cls.client.delete_endpoint, endpoint[\u0027id\u0027])"},{"line_number":57,"context_line":"            cls.setup_endpoint_ids.append(endpoint[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_91ed458d","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":63},"in_reply_to":"9fb8cfa7_b54e43bf","updated":"2019-06-18 10:23:22.000000000","message":"addClassResourceCleanup does the same by appending the cleanup in _class_cleanups which will be removed in resource_cleanup().","commit_id":"1a457ac530a24968212865d594ec87943d883d9d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"085abca04dea2a28dbb82b0b7e804e23cfc4acba","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                               enabled\u003dFalse)[\u0027endpoint\u0027]"},{"line_number":189,"context_line":"        region2 \u003d self.regions_client.show_region(region2_name)[\u0027region\u0027]"},{"line_number":190,"context_line":"        self.addCleanup(self.regions_client.delete_region, region2[\u0027id\u0027])"},{"line_number":191,"context_line":"        self.addCleanup(self.client.delete_endpoint, endpoint_for_update[\u0027id\u0027])"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # Asserting if the attributes of endpoint are updated"},{"line_number":194,"context_line":"        self.assertEqual(service2[\u0027id\u0027], endpoint[\u0027service_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d1c17de6","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":79},"updated":"2019-06-18 10:23:22.000000000","message":"you can move this just after create_endpoint() so that we clean up the endpoint if any assertion happens on region delete or update endpoint. after L176","commit_id":"1a457ac530a24968212865d594ec87943d883d9d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"73cd9fea39534df659d0102e3c99035298dcdc8d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                               enabled\u003dFalse)[\u0027endpoint\u0027]"},{"line_number":189,"context_line":"        region2 \u003d self.regions_client.show_region(region2_name)[\u0027region\u0027]"},{"line_number":190,"context_line":"        self.addCleanup(self.regions_client.delete_region, region2[\u0027id\u0027])"},{"line_number":191,"context_line":"        self.addCleanup(self.client.delete_endpoint, endpoint_for_update[\u0027id\u0027])"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # Asserting if the attributes of endpoint are updated"},{"line_number":194,"context_line":"        self.assertEqual(service2[\u0027id\u0027], endpoint[\u0027service_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_47e2af03","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":79},"in_reply_to":"9fb8cfa7_d1c17de6","updated":"2019-06-18 11:44:34.000000000","message":"please ignore this comment. we cannot delete the region till it is associated with endpoint.","commit_id":"1a457ac530a24968212865d594ec87943d883d9d"}]}