)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2d89467c4256bb94814c785c7c73d8dab3ad278c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertEqual(int(sec_group_rule[\u0027port_range_max\u0027]), port_range_max)"},{"line_number":111,"context_line":"        self.addCleanup(self._delete_security_group_rule,"},{"line_number":112,"context_line":"                        sec_group_rule[\u0027id\u0027]"},{"line_number":113,"context_line":"                        )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class SecGroupTestXML(SecGroupTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FTzA%3D","line":113,"updated":"2014-01-15 07:36:10.000000000","message":"self.addCleanup should be moved to line 104 as it would not be called if assert fails.","commit_id":"2ac94412e40c85a3eea7449e400c26c4abf43fe5"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"3ff3c2655152888c4c1dff5a869d6c06511bfee7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertEqual(int(sec_group_rule[\u0027port_range_max\u0027]), port_range_max)"},{"line_number":111,"context_line":"        self.addCleanup(self._delete_security_group_rule,"},{"line_number":112,"context_line":"                        sec_group_rule[\u0027id\u0027]"},{"line_number":113,"context_line":"                        )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class SecGroupTestXML(SecGroupTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FTR4%3D","line":113,"in_reply_to":"AAAAUH%2F%2FTzA%3D","updated":"2014-01-15 10:04:24.000000000","message":"thanks zhikun","commit_id":"2ac94412e40c85a3eea7449e400c26c4abf43fe5"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"39f61c60b5d5ee13118acd44d4dae5da561cc4e0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":105,"context_line":"        self.addCleanup(self._delete_security_group_rule,"},{"line_number":106,"context_line":"                        sec_group_rule[\u0027id\u0027]"},{"line_number":107,"context_line":"                        )"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        sec_group_rule \u003d rule_create_body[\u0027security_group_rule\u0027]"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FSWk%3D","line":107,"updated":"2014-01-15 13:29:59.000000000","message":"as pep8 tests pointed, sec_group_rule in undefined (in fact defined in the line below), so swap these lines or use rule_create_body[\u0027security_group_rule\u0027][\u0027id\u0027]","commit_id":"1eca2b419f2434bb0e45e1ffbb09171f867da77b"},{"author":{"_account_id":7930,"name":"jun xie","email":"easonxie160@163.com","username":"jeffreycoho"},"change_message_id":"603daf4ee966f6a85bfc79d22987951bcd4ab730","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":105,"context_line":"        self.addCleanup(self._delete_security_group_rule,"},{"line_number":106,"context_line":"                        sec_group_rule[\u0027id\u0027]"},{"line_number":107,"context_line":"                        )"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        sec_group_rule \u003d rule_create_body[\u0027security_group_rule\u0027]"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FSP8%3D","line":107,"in_reply_to":"AAAAUH%2F%2FSWk%3D","updated":"2014-01-15 13:55:51.000000000","message":"thanks. sorry for the mistake. the cleanup function  was at the end of the tesecase in the previous patch. my carelessness.","commit_id":"1eca2b419f2434bb0e45e1ffbb09171f867da77b"}]}